From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80ECDEB64D9 for ; Tue, 4 Jul 2023 15:25:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1FE4F280088; Tue, 4 Jul 2023 11:25:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1AE64280076; Tue, 4 Jul 2023 11:25:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 076B8280088; Tue, 4 Jul 2023 11:25:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id EB0A0280076 for ; Tue, 4 Jul 2023 11:25:04 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id BD1131C821A for ; Tue, 4 Jul 2023 15:25:04 +0000 (UTC) X-FDA: 80974302528.08.0757843 Received: from mail-yw1-f182.google.com (mail-yw1-f182.google.com [209.85.128.182]) by imf04.hostedemail.com (Postfix) with ESMTP id DCABE4000E for ; Tue, 4 Jul 2023 15:25:02 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=u6+RlUTi; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf04.hostedemail.com: domain of surenb@google.com designates 209.85.128.182 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688484302; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=nRVjez6bgppshVEv1zv8OJxqfsYiWmRHBZwKVvdKFi4=; b=jcUVA2HoK2/kB9Bps2zr7TFpmW5WtlDfW+vY/hW4urocC3DP713zR/z5g/4fpX9vghTXUE 6lQcoFBLSHdDBjJrCqwHO3+E4WfwXqoXyBB/SdasnOOEPUJkQn+CbqQW5ZXgZxdQvhGc9a gXnBHALz1p4un5XSGMtzHJSDGrb7uos= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=u6+RlUTi; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf04.hostedemail.com: domain of surenb@google.com designates 209.85.128.182 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688484302; a=rsa-sha256; cv=none; b=fM7zL6dy5669q5NUBSmKw2QimRgkQ7+OH8i0nhJ5AkintZSENm2k3amCv92CI0JuU3tAfX ygw/mBzII7Yh05cmflLRn5x8ZnJFyfvkqgl10tgUpLy/UPMuvOfpgUHcZm26WG/BRvSLfM YSW8P3wDxfIBUzrPRtbQaxskc5rgHu4= Received: by mail-yw1-f182.google.com with SMTP id 00721157ae682-579ef51428eso38394707b3.2 for ; Tue, 04 Jul 2023 08:25:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1688484301; x=1691076301; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=nRVjez6bgppshVEv1zv8OJxqfsYiWmRHBZwKVvdKFi4=; b=u6+RlUTig1ia9cv6dyCij7K7/0ttxBG27k6Tys6WTbeSHrDDTt/1fzNv1/TTIka7VL /JYIgNm7m7Z40FJVWQlebDCztWVz9epKbtisC83pj3YIoJOMj8ACtA07DmA31luBA1en AMo8eRJlqy2JulC8eLdFsBQX48Vy0fJkFrygV4xG+kpEFuRWbIvrZ50Y9mHgOGyEyCay KiBcWpuPg+V/LKvmegMDnQXWpuf6vFOj6bjLKpws3ZUxyWA0CprQ6lxmZK7EfO9dZsTj JacLXs59Vkfk4EZK2BJGw0tERTke9p3tfOz8xfRISkT127K/tBLsrWKbPQrDgBIjZsWh YiCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688484301; x=1691076301; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nRVjez6bgppshVEv1zv8OJxqfsYiWmRHBZwKVvdKFi4=; b=hntGZB+fwFqm1NOyg7Xbbu29ls0fZpS77U9XbVjsrBJuQNFOegQRnAcO9OZvFjHnpP FPEdtiMA/dBPjeJmv8KSQOr1+oAv1lMqHhwhUJ28pCvH6CLgXrLTZaKCLDckwzVZfio+ 6gEpY7HFrx0AwvLsD6Rz+JLhp5NssJrbCiCyemGWH4n7Py2atOF405TUfdtgiLVyvF1f 8q+zx5FoRj1Ox86D8JXt25LjUFs518TuWiFDiiezC1S6Ri/4F07KjaF/qzz2fpbj6uj2 XY1RsBZmzXmEVrq/Hgy4SmEYkKO+LuPV3Id3rh6I3byRQWBicGK4B5BHfFlNFZ1g4+M6 +HOA== X-Gm-Message-State: ABy/qLbSIL7fy5MDI//9z5VCztUx6WufaGIW+HQQYSzTgJZnmhuHSpP+ /yHpmZmtr3ahsnKfqpqpvtKuH96SIhncbC0vMED03Q== X-Google-Smtp-Source: APBJJlGkVSEE3WXJ32g2I5hnp9aTVYjCucT+dufLbMNuejE+M1/LwAuRB9QjA41AnvAMB5QbTqGtdiFkMmETZErqAf8= X-Received: by 2002:a25:15c1:0:b0:bfe:d93a:8f2b with SMTP id 184-20020a2515c1000000b00bfed93a8f2bmr12077887ybv.60.1688484301543; Tue, 04 Jul 2023 08:25:01 -0700 (PDT) MIME-Version: 1.0 References: <20230703182150.2193578-1-surenb@google.com> <5c99b5f1-b001-7ce9-050d-bb21edfe36bb@redhat.com> In-Reply-To: <5c99b5f1-b001-7ce9-050d-bb21edfe36bb@redhat.com> From: Suren Baghdasaryan Date: Tue, 4 Jul 2023 08:24:50 -0700 Message-ID: Subject: Re: [PATCH 1/1] mm: disable CONFIG_PER_VMA_LOCK by default until its fixed To: Hans de Goede Cc: akpm@linux-foundation.org, jirislaby@kernel.org, jacobly.alt@gmail.com, holger@applied-asynchrony.com, michel@lespinasse.org, jglisse@google.com, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, mgorman@techsingularity.net, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, peterz@infradead.org, ldufour@linux.ibm.com, paulmck@kernel.org, mingo@redhat.com, will@kernel.org, luto@kernel.org, songliubraving@fb.com, peterx@redhat.com, david@redhat.com, dhowells@redhat.com, hughd@google.com, bigeasy@linutronix.de, kent.overstreet@linux.dev, punit.agrawal@bytedance.com, lstoakes@gmail.com, peterjung1337@gmail.com, rientjes@google.com, chriscli@google.com, axelrasmussen@google.com, joelaf@google.com, minchan@google.com, rppt@kernel.org, jannh@google.com, shakeelb@google.com, tatashin@google.com, edumazet@google.com, gthelen@google.com, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Stat-Signature: ztst7pt17h9r49i9g76mgcg8ntg5p5j8 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: DCABE4000E X-HE-Tag: 1688484302-908670 X-HE-Meta: U2FsdGVkX18HlNs+2gChZyCF4vUVUQR21R+ZjQ+L39DvB3Tc1iFFyct2UYJdUfOVSRfCEVH0mDKoaKodDR3r8h4CYRtQIyyujcrQX3nA69xoRI5qsqVK3FpcecfPBqDa7vwNm1kW6pKCt4DUuvKwD64gWYNjOoWtn/aXP4rPKlhqus1Gb6sld7weo3aaTkMoD+F3mqt5DvQg0xQQW9fkyA2HfMOfOKTkHdZeH9wYjVB6yG2D6UYdjoP0FGMykK0+W58xZHIgBXoI/5zKqLcJ8QBINBpNHbG/imYqzQCHLm/GmQFZyofTcLbU+bbt0YSmCDhJOFIMHI+vRtCKNJ96MYwnD4W2jttVPkFZvVXAhgVG8Sw5lbXv26Ei/c2sTaoR7BoFp6nQ97wGRlSRBrrQWWGCz9aZ6RqM4h5aBXouDF8OurOx0OjF5roY9nKjDCHI6xOYmZyosb96nDg3SOOFU8Mh1bSZLXwri/bygjv77ilZ12BDdnWU+MY7Mh550G537LBJvkmoJOJ4jnGX0JUWsEZRz/uboHdkuFwcbg1UwUAfzB09HdwU5ojAPBQrELvCEmnIsg+aIIUZ00r70yoPG1zq519L2YQeme5CNH8eVI7kmD40fH11lxAeiNMCv36jddjh8Zr1lsY1MuMHB2KxW+1wvWuUZKN08UbDFc7YVH31XfpTATJgQmmrirCjpvH1w4wHXQzRoBeHQCsxzafTx1Jlu1lGD8d5E0Znqne/TWLRzGVY8v3mUCWdOqVDJUZ2WZU0ApJS5saJPmRE2/u5JH3okGJcjkIFV/UT4qGZ3P+FDE/kvt5C06Aw96MhWQFfte9W+NOeQMULiRJ71jngfeu6tPorDD0ox1NwvJSnsr5hSxroYa1RCXD7/NHEpW4Kl4oZCCYncoblR7f7aXPhqSrVszBsAgoplFcSQcUPciBGuLIyMB/VyAQ2fEe3iXIXOm4uW/quL3LG6hYk6Io bzhWUPEI b0WWZUn6DGbkoTTC1SzQoBKdQ8ag+bT3QMSHv0LA0YxGXodWQ8cuGAd9cCSwQld8bIfOtZJO0d16CSY8FLVksfcBs3uFGWkdkDaxB5RdaEajDENerji3ubvkkmsnc81VT0YHQqonIrJ964zmNddCk0HL4qHg1NnOGKOt2vF0boTBcsnUFn4SosPwFxFv+ZA2gnpiFI3sF3R17dtOhRp2hGQG6kRc74R/Krxr7LtdXwDeWYUrr2eFScOLiYjU174DRbrUdvDdzXAiND99CDOF7cMOFtx4nWrwKUQUrlTCZpmp/HJHLWNp36eNozV8iTiRy6tC17ji0IxCKnxR7IFQl0DxdFRV2eO1H30RPAwgp/qzPGx/GV8WiTq9nHFINf6NMUzFDgYS+7gTk2zAa+bdEkN1DB0oP5gsuz6k7jJNHWiIe7SdnOxKLEQe0Q89J3CR+1PRjPRT8Ir8VcqjgqMmnKnWgPxTt7L1BlDqi X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jul 4, 2023 at 1:18=E2=80=AFAM Hans de Goede = wrote: > > Hi Suren, > > Thank you for your patch. > > On 7/3/23 20:21, Suren Baghdasaryan wrote: > > A memory corruption was reported in [1] with bisection pointing to the > > patch [2] enabling per-VMA locks for x86. > > Disable per-VMA locks config to prevent this issue while the problem is > > being investigated. This is expected to be a temporary measure. > > > > [1] https://bugzilla.kernel.org/show_bug.cgi?id=3D217624 > > [2] https://lore.kernel.org/all/20230227173632.3292573-30-surenb@google= .com > > > > Reported-by: Jiri Slaby > > Reported-by: Jacob Young > > Fixes: 0bff0aaea03e ("x86/mm: try VMA lock-based page fault handling fi= rst") > > Signed-off-by: Suren Baghdasaryan > > --- > > mm/Kconfig | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/mm/Kconfig b/mm/Kconfig > > index 09130434e30d..de94b2497600 100644 > > --- a/mm/Kconfig > > +++ b/mm/Kconfig > > @@ -1224,7 +1224,7 @@ config ARCH_SUPPORTS_PER_VMA_LOCK > > def_bool n > > > > config PER_VMA_LOCK > > - def_bool y > > + bool "Enable per-vma locking during page fault handling." > > depends on ARCH_SUPPORTS_PER_VMA_LOCK && MMU && SMP > > help > > Allow per-vma locking during page fault handling. > > > This does not disable the option it only makes it user selectable > and for users with an existing .config which already has this > it changes nothing. Hmm. Yes, I didn't think about a case when kernel would be updated and .config would not... > > IMHO you should add a "depends on BROKEN" here until this is fixed, > so that this really gets disabled. Agree, that would be a sure way to disable it. I'll use it if the proper fix still does not work. Thanks! > > Or maybe just revert 0bff0aaea03e2a3ed6bfa302155cca8a432a1829 > for now? That would disable it only for x86 while keeping it for all other supported platforms, so we would have to revert several patches. I wanted the simplest way to temporarily disable the feature until a fix is in place. Let me test it a bit and if that works I'll send patches to fix and re-enable CONFIG_PER_VMA_LOCK instead of disabling it. Thanks, Suren. > > Regards, > > Hans > >