From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E943EC352AA for ; Tue, 1 Oct 2019 16:01:10 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8C8BF2168B for ; Tue, 1 Oct 2019 16:01:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8C8BF2168B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arndb.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 1E2FE8E0005; Tue, 1 Oct 2019 12:01:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 195BB8E0001; Tue, 1 Oct 2019 12:01:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0AB4B8E0005; Tue, 1 Oct 2019 12:01:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0035.hostedemail.com [216.40.44.35]) by kanga.kvack.org (Postfix) with ESMTP id DD2768E0001 for ; Tue, 1 Oct 2019 12:01:08 -0400 (EDT) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with SMTP id 90B928E50 for ; Tue, 1 Oct 2019 16:01:08 +0000 (UTC) X-FDA: 75995679816.08.beast63_61340b3ed7823 X-HE-Tag: beast63_61340b3ed7823 X-Filterd-Recvd-Size: 2822 Received: from mail-qt1-f195.google.com (mail-qt1-f195.google.com [209.85.160.195]) by imf15.hostedemail.com (Postfix) with ESMTP for ; Tue, 1 Oct 2019 16:01:07 +0000 (UTC) Received: by mail-qt1-f195.google.com with SMTP id o12so22283303qtf.3 for ; Tue, 01 Oct 2019 09:01:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=x01awrD5TSlsk6NlvH+kQSXg+iJmGObI88cW5UgsE3c=; b=iPYZrjdVC2eRjEWONn8jDKmbjD4I5T4NRVBrKxeTJiCOHIklUy1N780bHngdj+Gsq5 zE//OeCKQSeswtEhlAE0ow3aegfnimwxpFAHJ0t019/AGe5ZClvsxTb7WI5B4Mtvixma 0lw3/F6RbWJMEab/wKZ7bvKxrGSRDiqgYOxCtcO+SraAWc1INgQi0MDNZj+IAnuR/y4t n8LUtbwXqna/m5xXYLUfhOde2BB7spyt5v/bcih/fO4APocHxiOe5MMsmyGXX/HFGKVn 4anZEMtAptvw4v3VCFwHlEmF4T619JmjYuhgydErrtaISfc+7mTWugfdtoQuPRLyhfwM nsTg== X-Gm-Message-State: APjAAAUnAyiQBhqBby2KcpWRcgyxOWtrKaKqeVb12NhMj3ul5VG9gko8 PQhff3t4BV1N8EDxWXaEhuqWl4/7ZvwtAEgVXH8= X-Google-Smtp-Source: APXvYqwXNQ85AMQ82y5yVifrvbRIc55eAUjhwij0+sTOJVCU6PWFQrAXLde5ogB+7LJPke763XickWNjc6/9cst2GW4= X-Received: by 2002:a05:6214:2b0:: with SMTP id m16mr25953761qvv.45.1569945667079; Tue, 01 Oct 2019 09:01:07 -0700 (PDT) MIME-Version: 1.0 References: <20191001142227.1227176-1-arnd@arndb.de> <1569940805.5576.257.camel@lca.pw> In-Reply-To: <1569940805.5576.257.camel@lca.pw> From: Arnd Bergmann Date: Tue, 1 Oct 2019 18:00:50 +0200 Message-ID: Subject: Re: [PATCH] mm/memcontrol.c: fix another unused function warning To: Qian Cai Cc: Johannes Weiner , Michal Hocko , Vladimir Davydov , Michal Hocko , Andrew Morton , Roman Gushchin , Shakeel Butt , Chris Down , Tejun Heo , cgroups@vger.kernel.org, Linux-MM , "linux-kernel@vger.kernel.org" , clang-built-linux Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Oct 1, 2019 at 4:40 PM Qian Cai wrote: > > On Tue, 2019-10-01 at 16:22 +0200, Arnd Bergmann wrote: > > Removing the mem_cgroup_id_get() stub function introduced a new warning > > of the same kind when CONFIG_MMU is disabled: > > Shouldn't CONFIG_MEMCG depends on CONFIG_MMU instead? Maybe. Generally we allow building a lot of stuff without CONFIG_MMU that may not make sense, so I just followed the same idea here. Arnd