From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A990C43216 for ; Tue, 27 Jul 2021 18:50:11 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 17BCD60FC2 for ; Tue, 27 Jul 2021 18:50:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 17BCD60FC2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 8ED808D0001; Tue, 27 Jul 2021 14:50:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 89E276B005D; Tue, 27 Jul 2021 14:50:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 765378D0001; Tue, 27 Jul 2021 14:50:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0001.hostedemail.com [216.40.44.1]) by kanga.kvack.org (Postfix) with ESMTP id 5A7056B0036 for ; Tue, 27 Jul 2021 14:50:10 -0400 (EDT) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id F09651813BCDB for ; Tue, 27 Jul 2021 18:50:09 +0000 (UTC) X-FDA: 78409257738.26.1F6F696 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf21.hostedemail.com (Postfix) with ESMTP id 8C932D015A92 for ; Tue, 27 Jul 2021 18:50:09 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id B10DC60FD8 for ; Tue, 27 Jul 2021 18:50:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1627411808; bh=FEnwgSbKVXqz/f02D+yC03c3XbgdHc6UQnZBnRvCJ/M=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=Wk8r1n/mSx+0i6AQUY//rrzvo7u0iykvI3DdMwAU6Fm/5wRnd0aHGo1bytx3xXu7k V3PJdlxpsKgFsAEaS7uZWfUIfFWVaBrx69vXh2hfyWYRH5NQn1716X5tqJilSuZ/e/ tk9muKXJu5/49yxCwj4RAo/tsrlbDsU3fovK01uescBB4yrZKqeKS15WHtt2DGx9Oj iF4Q3naxYhPj2AJoJR+3fqqmyczVP5rEm8K8D5fNCTblk5yGa//Rl7ecC05qjuI/co nrA0rgBAydBUwU9/kObE3BP78Eet9E5cwms/Ir0jmCUxjomE9KSZ5F3f5kYLyoIl/1 zl2MNoEU9+ykQ== Received: by mail-lf1-f51.google.com with SMTP id a26so23320691lfr.11 for ; Tue, 27 Jul 2021 11:50:08 -0700 (PDT) X-Gm-Message-State: AOAM531XtY1uMC6Wt5JNZ2qBz/zQDx6jsrOvpTa3J2axvJFh3EVNdLJ7 SmvpiNCQQ0b/QBXLo4HTBW5kWzDMhZg58SAy6gg= X-Google-Smtp-Source: ABdhPJyJoGfE0vjMAu17Dx3oLfkZN1O26Yflb54n4xga3o5XuLKsejT/cbFSiPGK2CJQqQHqBmqSL7vlY8Dk6BlYaZM= X-Received: by 2002:adf:e107:: with SMTP id t7mr26004543wrz.165.1627411796641; Tue, 27 Jul 2021 11:49:56 -0700 (PDT) MIME-Version: 1.0 References: <20210727144859.4150043-1-arnd@kernel.org> <20210727144859.4150043-5-arnd@kernel.org> In-Reply-To: From: Arnd Bergmann Date: Tue, 27 Jul 2021 20:49:40 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v5 4/6] mm: simplify compat numa syscalls To: Heiko Carstens Cc: Andrew Morton , Arnd Bergmann , Catalin Marinas , Will Deacon , Thomas Bogendoerfer , "James E.J. Bottomley" , Helge Deller , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Vasily Gorbik , Christian Borntraeger , "David S. Miller" , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "the arch/x86 maintainers" , "H. Peter Anvin" , Al Viro , "Eric W. Biederman" , Christoph Hellwig , Feng Tang , Linux ARM , Linux Kernel Mailing List , "open list:BROADCOM NVRAM DRIVER" , Parisc List , linuxppc-dev , linux-s390 , sparclinux , linux-arch , Linux API , Linux-MM , Christoph Hellwig Content-Type: text/plain; charset="UTF-8" Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="Wk8r1n/m"; spf=pass (imf21.hostedemail.com: domain of arnd@kernel.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=arnd@kernel.org; dmarc=pass (policy=none) header.from=kernel.org X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 8C932D015A92 X-Stat-Signature: 7wnxum8atmkzuf1z7qfmdqm1wfscfi6q X-HE-Tag: 1627411809-670792 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jul 27, 2021 at 8:38 PM Heiko Carstens wrote: > > -268 common mbind sys_mbind compat_sys_mbind > -269 common get_mempolicy sys_get_mempolicy compat_sys_get_mempolicy > -270 common set_mempolicy sys_set_mempolicy compat_sys_set_mempolicy > +268 common mbind sys_mbind sys_mbind > +269 common get_mempolicy sys_get_mempolicy sys_get_mempolicy > +270 common set_mempolicy sys_set_mempolicy sys_set_mempolicy > > would remove compat_ptr() conversion from nmask above if I'm not mistaken. Maybe I'm misremembering how compat syscalls work on s390. Doesn't SYSCALL_DEFINEx(sys_mbind) still create two entry points __s390x_sys_mbind() and __s390_sys_mbind() with different argument conversion (__SC_CAST vs __SC_COMPAT_CAST)? I thought that was the whole point of the macros. Arnd