From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D02BC433EF for ; Tue, 15 Feb 2022 08:10:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B29C46B0078; Tue, 15 Feb 2022 03:10:25 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AD7206B007B; Tue, 15 Feb 2022 03:10:25 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9ED856B007D; Tue, 15 Feb 2022 03:10:25 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0096.hostedemail.com [216.40.44.96]) by kanga.kvack.org (Postfix) with ESMTP id 91F4B6B0078 for ; Tue, 15 Feb 2022 03:10:25 -0500 (EST) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 519DB181AC9C6 for ; Tue, 15 Feb 2022 08:10:25 +0000 (UTC) X-FDA: 79144292010.17.701221F Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf22.hostedemail.com (Postfix) with ESMTP id C35F6C0005 for ; Tue, 15 Feb 2022 08:10:24 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D30D36164F for ; Tue, 15 Feb 2022 08:10:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4811AC340F4 for ; Tue, 15 Feb 2022 08:10:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1644912623; bh=SSSBFam0X7wa1ZiCw7Mbgc9666G5ScJGR2eDM1GsaRo=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=GJaH8HwE/nyR+qQa8REdT0IBd6a1g1vdC7TjCVH+QKxG8exdyUSWaCsUK7KWHphPk tvJwSqnUx64jqz1n54LIqFenzDmCCidLTJduU74Q5vlyWYX7j4DNZDwpt3yWI1yggy uVAjNKpsQ/55wU4crkdhGYsBR6jczZb92p557GB19rCppp2hQm8idjgMHrieouMtUe BGFgP4YI3u/k4JjEKZvMFZMxgpcGVMSueNUds/WuePg8tSzQQwECVHk/BraBvFWKRw FVODNRMCkDbhgL/OgkzDyZhbXNvkdebH3pAU3g7SFEv2xKk93G1ExuOBsZgVpcgC1j wml0zK2sDBkbQ== Received: by mail-wr1-f54.google.com with SMTP id d27so30663961wrc.6 for ; Tue, 15 Feb 2022 00:10:23 -0800 (PST) X-Gm-Message-State: AOAM530xeqLLmObFLjFV8WnyBFoop9lKvuQS1A9Ud2xaZTjqyouqfJ0+ bVIK3GIl+i/ZF8xwgbintg9DVtTZGVRAxj3PPZI= X-Google-Smtp-Source: ABdhPJykY+dvL+1GXmktnHDS2zXI387Vsr5YXEveY1d8rit1tT/hQTTS9CD1dDWxxX5ce3jmiS7RoOoUcfODSGZmbh0= X-Received: by 2002:a5d:58d1:: with SMTP id o17mr2237862wrf.407.1644912621613; Tue, 15 Feb 2022 00:10:21 -0800 (PST) MIME-Version: 1.0 References: <20220214163452.1568807-1-arnd@kernel.org> <20220214163452.1568807-15-arnd@kernel.org> <215c0ddc-54b1-bcb1-c5aa-bd17c6b100a8@gmx.de> In-Reply-To: <215c0ddc-54b1-bcb1-c5aa-bd17c6b100a8@gmx.de> From: Arnd Bergmann Date: Tue, 15 Feb 2022 09:10:05 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 14/14] uaccess: drop set_fs leftovers To: Helge Deller Cc: Al Viro , Linus Torvalds , Christoph Hellwig , linux-arch , Linux-MM , Linux API , Arnd Bergmann , Linux Kernel Mailing List , Russell King - ARM Linux , Will Deacon , Guo Ren , Brian Cain , Geert Uytterhoeven , Michal Simek , Thomas Bogendoerfer , Nick Hu , Greentime Hu , Dinh Nguyen , Stafford Horne , Michael Ellerman , Peter Zijlstra , Ingo Molnar , Mark Rutland , Heiko Carstens , Rich Felker , David Miller , Richard Weinberger , "the arch/x86 maintainers" , Max Filippov , "Eric W . Biederman" , Andrew Morton , Ard Biesheuvel , alpha , "open list:SYNOPSYS ARC ARCHITECTURE" , Linux ARM , linux-csky@vger.kernel.org, "open list:QUALCOMM HEXAGON..." , linux-ia64@vger.kernel.org, linux-m68k , "open list:BROADCOM NVRAM DRIVER" , Openrisc , Parisc List , linuxppc-dev , linux-riscv , linux-s390 , Linux-sh list , sparclinux , linux-um , "open list:TENSILICA XTENSA PORT (xtensa)" Content-Type: text/plain; charset="UTF-8" Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=GJaH8HwE; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf22.hostedemail.com: domain of arnd@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=arnd@kernel.org X-Rspam-User: X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: C35F6C0005 X-Stat-Signature: skuzy63s51xbkbx7uso3rsrwyxubjass X-HE-Tag: 1644912624-472598 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Feb 15, 2022 at 8:46 AM Helge Deller wrote: > > On 2/15/22 04:03, Al Viro wrote: > > On Mon, Feb 14, 2022 at 05:34:52PM +0100, Arnd Bergmann wrote: > >> diff --git a/arch/parisc/include/asm/futex.h b/arch/parisc/include/asm/futex.h > >> index b5835325d44b..2f4a1b1ef387 100644 > >> --- a/arch/parisc/include/asm/futex.h > >> +++ b/arch/parisc/include/asm/futex.h > >> @@ -99,7 +99,7 @@ futex_atomic_cmpxchg_inatomic(u32 *uval, u32 __user *uaddr, > >> /* futex.c wants to do a cmpxchg_inatomic on kernel NULL, which is > >> * our gateway page, and causes no end of trouble... > >> */ > >> - if (uaccess_kernel() && !uaddr) > >> + if (!uaddr) > >> return -EFAULT; > > > > Huh? uaccess_kernel() is removed since it becomes always false now, > > so this looks odd. > > > > AFAICS, the comment above that check refers to futex_detect_cmpxchg() > > -> cmpxchg_futex_value_locked() -> futex_atomic_cmpxchg_inatomic() call chain. > > Which had been gone since commit 3297481d688a (futex: Remove futex_cmpxchg > > detection). The comment *and* the check should've been killed off back > > then. > > Let's make sure to get both now... > > Right. Arnd, can you drop this if() and the comment above it? Done. Arnd