From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC08EC388F7 for ; Tue, 3 Nov 2020 09:46:16 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 15B9A22409 for ; Tue, 3 Nov 2020 09:46:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="NfOl8d72" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 15B9A22409 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 646106B005C; Tue, 3 Nov 2020 04:46:15 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5F6656B005D; Tue, 3 Nov 2020 04:46:15 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4BF966B0068; Tue, 3 Nov 2020 04:46:15 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0217.hostedemail.com [216.40.44.217]) by kanga.kvack.org (Postfix) with ESMTP id 1E62F6B005C for ; Tue, 3 Nov 2020 04:46:15 -0500 (EST) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id B0C81181AEF00 for ; Tue, 3 Nov 2020 09:46:14 +0000 (UTC) X-FDA: 77442626268.11.robin05_0a02b81272b7 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin11.hostedemail.com (Postfix) with ESMTP id 9D832180F8B81 for ; Tue, 3 Nov 2020 09:46:14 +0000 (UTC) X-HE-Tag: robin05_0a02b81272b7 X-Filterd-Recvd-Size: 3540 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf41.hostedemail.com (Postfix) with ESMTP for ; Tue, 3 Nov 2020 09:46:13 +0000 (UTC) Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 882C822447 for ; Tue, 3 Nov 2020 09:46:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604396772; bh=XYLjUb/wt/Qh/YwIScTOgSYD1ESCUFNNtg4rDkz2sZI=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=NfOl8d72y9ApjD47h6GqNUWNwdCatoOIwZ1fJLqqbGdH0qE8lOPsHWz9sDg5F9xO8 VJ2a/P2mI1mYRYL8kEuvW8lIKRYtXh2HEnjFPN5s83Hj5qCIAzNz2wjxLij0NXolCa nsUiN6PAkqr73M2gfIlPMVC788X5Tjn4AKF/+QLk= Received: by mail-wr1-f54.google.com with SMTP id k10so16426499wrw.13 for ; Tue, 03 Nov 2020 01:46:12 -0800 (PST) X-Gm-Message-State: AOAM531a8+fD0RlqN+hQLyttNmjV7QiEtwyePLpuWnEUBnJNdhIKlWv/ jMnzWT6PW1sWehbXDWzCIXwLakUJHI3rORjGDHc= X-Google-Smtp-Source: ABdhPJz5/pmJbk1avpEhMdak9TfFmMuhdl1BuBXo90BhZ5viZ969NVVvRVPq/4iJo0zCBjuw7Ekvw0+pHt+H1AfrHvc= X-Received: by 2002:adf:eb4f:: with SMTP id u15mr18835987wrn.165.1604396770994; Tue, 03 Nov 2020 01:46:10 -0800 (PST) MIME-Version: 1.0 References: <20201102123151.2860165-1-arnd@kernel.org> <20201102123151.2860165-5-arnd@kernel.org> <20201103083703.GD9092@infradead.org> In-Reply-To: <20201103083703.GD9092@infradead.org> From: Arnd Bergmann Date: Tue, 3 Nov 2020 10:45:54 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 4/4] compat: remove some compat entry points To: Christoph Hellwig Cc: linux-arch , Arnd Bergmann , Alexander Viro , Andrew Morton , Andy Lutomirski , Borislav Petkov , Brian Gerst , Eric Biederman , Ingo Molnar , "H . Peter Anvin" , Thomas Gleixner , Linux ARM , "linux-kernel@vger.kernel.org" , Linux-MM , kexec@lists.infradead.org Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Nov 3, 2020 at 9:38 AM Christoph Hellwig wrote: > > On Mon, Nov 02, 2020 at 01:31:51PM +0100, Arnd Bergmann wrote: > > From: Arnd Bergmann > > > > These are all handled correctly when calling the native > > system call entry point, so remove the special cases. > > Ok, this is where you do it. I think this belongs into the main > patches. I had it there originally, I guess I should have left it there ;-) When I changed it, I was considering to do the same for additional syscalls that have very small differences now (timer_create, rt_sigqueueinfo, rt_sigpending, recvmsg, sendmsg) and use in_compat_syscall() there, but then I decided against that. In the end, I did like the split, as I found the smaller three patches that contain the real change easier to review, and it turns the larger patch at the end into a more obvious transformation. Arnd