From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC684C56201 for ; Wed, 11 Nov 2020 09:33:49 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 20E4F20756 for ; Wed, 11 Nov 2020 09:33:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="aFqME1+y" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 20E4F20756 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 71BD86B006E; Wed, 11 Nov 2020 04:33:48 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6CB106B0070; Wed, 11 Nov 2020 04:33:48 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 592376B0072; Wed, 11 Nov 2020 04:33:48 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0158.hostedemail.com [216.40.44.158]) by kanga.kvack.org (Postfix) with ESMTP id 28D7A6B006E for ; Wed, 11 Nov 2020 04:33:48 -0500 (EST) Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id CAFB4181AC9B6 for ; Wed, 11 Nov 2020 09:33:47 +0000 (UTC) X-FDA: 77471625294.18.slope82_0709a81272fc Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin18.hostedemail.com (Postfix) with ESMTP id AFD85100ED3CD for ; Wed, 11 Nov 2020 09:33:47 +0000 (UTC) X-HE-Tag: slope82_0709a81272fc X-Filterd-Recvd-Size: 3206 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf28.hostedemail.com (Postfix) with ESMTP for ; Wed, 11 Nov 2020 09:33:47 +0000 (UTC) Received: from mail-ot1-f51.google.com (mail-ot1-f51.google.com [209.85.210.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1B5A520809 for ; Wed, 11 Nov 2020 09:33:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1605087226; bh=E237N15UI1ysnqV/JxNmaeLL0fcS/FkbrJoOjVJ1psY=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=aFqME1+yN+KU2Nt9S6yZcEm52VyTjJ8wmdTtg3SrTtrl/eB/ywcNh4PeEy/49DnR3 Iezir2EAtxu5Cj8aLqc1br7JjffWZ7L6HamYE3tVKqisnpoo1Xm4nk1M1vhINW5JZW 8fwi/esP7Vfw/xBLf7Jqo+XFVMY+oOLjhEAxU/GE= Received: by mail-ot1-f51.google.com with SMTP id j14so1564812ots.1 for ; Wed, 11 Nov 2020 01:33:46 -0800 (PST) X-Gm-Message-State: AOAM530auPqZtBm+NH35rQ+ivChLebbzPSvjKub5j8QfB6LOO8DqMVzu hxUHdacxhncswR5uSCViZZ1DpDR8lGZQ6xEdHXU= X-Google-Smtp-Source: ABdhPJxHhfffJss6qDNCrB9I8V47wTYNH5uSQtOjQSwA5P8Q0YnHiXAeer1/2N8UdzHqo7F1LPkN1sd9Y1i4jTL5e4o= X-Received: by 2002:a9d:65d5:: with SMTP id z21mr15868652oth.251.1605087225231; Wed, 11 Nov 2020 01:33:45 -0800 (PST) MIME-Version: 1.0 References: <20201108064659.GD301837@kernel.org> <7782fb694a6b0c500e8f32ecf895b2bf@agner.ch> <20201110095806.GH301837@kernel.org> <20201110162155.GA4758@kernel.org> In-Reply-To: <20201110162155.GA4758@kernel.org> From: Arnd Bergmann Date: Wed, 11 Nov 2020 10:33:29 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] mm/zsmalloc: include sparsemem.h for MAX_PHYSMEM_BITS To: Mike Rapoport Cc: Stefan Agner , Minchan Kim , ngupta@vflare.org, Sergey Senozhatsky , Andrew Morton , sjenning@linux.vnet.ibm.com, gregkh , Arnd Bergmann , Linux-MM , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Nov 10, 2020 at 5:21 PM Mike Rapoport wrote: > On Tue, Nov 10, 2020 at 12:21:11PM +0100, Arnd Bergmann wrote: > > > > To be on the safe side, we could provoke a compile-time error > > when CONFIG_PHYS_ADDR_T_64BIT is set on a 32-bit > > architecture, but MAX_POSSIBLE_PHYSMEM_BITS is not set. > > Maybe compile time warning and a runtime error in zs_init() if 32 bit > machine has memory above 4G? If the fix is as easy as adding a single line in a header, I think a compile-time error makes it easier, no need to wait for someone to boot a broken system before fixing it. Arnd