From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0882DC433EF for ; Mon, 14 Feb 2022 19:26:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5F4526B0071; Mon, 14 Feb 2022 14:26:25 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5A4486B007B; Mon, 14 Feb 2022 14:26:25 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 46C306B007D; Mon, 14 Feb 2022 14:26:25 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0079.hostedemail.com [216.40.44.79]) by kanga.kvack.org (Postfix) with ESMTP id 383546B0071 for ; Mon, 14 Feb 2022 14:26:25 -0500 (EST) Received: from smtpin25.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id ED973181AC9C6 for ; Mon, 14 Feb 2022 19:26:24 +0000 (UTC) X-FDA: 79142366688.25.8347E72 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf08.hostedemail.com (Postfix) with ESMTP id 6709416000D for ; Mon, 14 Feb 2022 19:25:44 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7C6AE6114A for ; Mon, 14 Feb 2022 19:25:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0EA7DC340FF for ; Mon, 14 Feb 2022 19:25:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1644866742; bh=zLWY4rc6tKJzkfOHU66+tSLIxceIVdBozj8MWHl9tz8=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=kef99plJmuYw4+xkVKjHbJ8RXGvyybTnXQDMmKGuMwYH3/LUNKfOLbMGOTNdCPfXp BtEJsj6DYpCsxsYumvPki+GrzEdCUmQjIa9Ms2cTdE+9n1sPJsc6rPFxsW48oZUghv q1wuh+/sDwjPvQ3ZIMAcGINRMuLFHY/FE7HrVEh1H1q9BaZNFRK0jn/BEvAnXg5VGR YMUCWZVrdqDizj4YOgkQegV0CX8rjZlGuB1vetZMaUoiALcA08p7GZ2T6CA0teouHm 6uuUC+TpuqgAvC+EUYbReFNt+9La4V2S9XF3jHsRK06usjMz95PQHWVBOx6D9u0oGD GbzJNvK4XO07A== Received: by mail-wr1-f41.google.com with SMTP id j26so17689686wrb.7 for ; Mon, 14 Feb 2022 11:25:41 -0800 (PST) X-Gm-Message-State: AOAM532MhrCo/aJTx4SVpu5S6tgXZAaVn3n6Wv/dbmo6TfMsT4iy3BLV E3/emsPZEpki4wXodtKvbbBsXqQlHs1jS6yWAbs= X-Google-Smtp-Source: ABdhPJwrOpkav7UeztG9pweW7/OWsS+hZNYg7RZgUDmgoSoPSixwWLgUERuof4XivnroH6SdfUIEp08YoMpfbv7qa3w= X-Received: by 2002:a5d:5446:: with SMTP id w6mr422520wrv.12.1644866740020; Mon, 14 Feb 2022 11:25:40 -0800 (PST) MIME-Version: 1.0 References: <20220214163452.1568807-1-arnd@kernel.org> <20220214163452.1568807-8-arnd@kernel.org> In-Reply-To: From: Arnd Bergmann Date: Mon, 14 Feb 2022 20:25:24 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 07/14] uaccess: generalize access_ok() To: Al Viro Cc: Linus Torvalds , Christoph Hellwig , linux-arch , Linux-MM , Linux API , Arnd Bergmann , Linux Kernel Mailing List , Russell King - ARM Linux , Will Deacon , Guo Ren , Brian Cain , Geert Uytterhoeven , Michal Simek , Thomas Bogendoerfer , Nick Hu , Greentime Hu , Dinh Nguyen , Stafford Horne , Helge Deller , Michael Ellerman , Peter Zijlstra , Ingo Molnar , Mark Rutland , Heiko Carstens , Rich Felker , David Miller , Richard Weinberger , "the arch/x86 maintainers" , Max Filippov , "Eric W . Biederman" , Andrew Morton , Ard Biesheuvel , alpha , "open list:SYNOPSYS ARC ARCHITECTURE" , Linux ARM , linux-csky@vger.kernel.org, "open list:QUALCOMM HEXAGON..." , linux-ia64@vger.kernel.org, linux-m68k , "open list:BROADCOM NVRAM DRIVER" , Openrisc , Parisc List , linuxppc-dev , linux-riscv , linux-s390 , Linux-sh list , sparclinux , linux-um , "open list:TENSILICA XTENSA PORT (xtensa)" Content-Type: text/plain; charset="UTF-8" Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=kef99plJ; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf08.hostedemail.com: domain of arnd@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=arnd@kernel.org X-Rspam-User: X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 6709416000D X-Stat-Signature: soaub6c9fku93ajxf9dsjj1r3e9kfofx X-HE-Tag: 1644866744-183703 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Feb 14, 2022 at 6:15 PM Al Viro wrote: > > On Mon, Feb 14, 2022 at 05:34:45PM +0100, Arnd Bergmann wrote: > > > diff --git a/arch/csky/kernel/signal.c b/arch/csky/kernel/signal.c > > index c7b763d2f526..8867ddf3e6c7 100644 > > --- a/arch/csky/kernel/signal.c > > +++ b/arch/csky/kernel/signal.c > > @@ -136,7 +136,7 @@ static inline void __user *get_sigframe(struct ksignal *ksig, > > static int > > setup_rt_frame(struct ksignal *ksig, sigset_t *set, struct pt_regs *regs) > > { > > - struct rt_sigframe *frame; > > + struct rt_sigframe __user *frame; > > int err = 0; > > > > frame = get_sigframe(ksig, regs, sizeof(*frame)); > > Minor nit: might make sense to separate annotations (here, on nios2, etc.) from the rest... Done. > > -} > > - > > -static inline int access_ok(const void __user * addr, unsigned long size) > > -{ > > - return 1; > > -} > > +#define __range_not_ok(addr, size, limit) (!__access_ok(addr, size)) > > is really wrong. For sparc64, access_ok() should always be true. > This __range_not_ok() thing is used *only* for valid_user_frame() in > arch/sparc/kernel/perf_event.c - it's not a part of normal access_ok() > there. > > sparc64 has separate address spaces for kernel and for userland; access_ok() > had never been useful there. Ok, fixed as well now. I had the access_ok() bit right, the definition just moved around here so it comes before the #include, but I missed the bit about __range_not_ok(), which I have now reverted back to the correct version in my tree. Arnd