From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F00FC433F5 for ; Wed, 6 Apr 2022 17:28:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2A7DB6B0071; Wed, 6 Apr 2022 13:28:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 256476B0073; Wed, 6 Apr 2022 13:28:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0D06A6B0074; Wed, 6 Apr 2022 13:28:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0061.hostedemail.com [216.40.44.61]) by kanga.kvack.org (Postfix) with ESMTP id EFBB96B0071 for ; Wed, 6 Apr 2022 13:28:40 -0400 (EDT) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id AE8201842190D for ; Wed, 6 Apr 2022 17:28:30 +0000 (UTC) X-FDA: 79327138380.26.A963C4B Received: from mail-lf1-f47.google.com (mail-lf1-f47.google.com [209.85.167.47]) by imf24.hostedemail.com (Postfix) with ESMTP id 4228C180017 for ; Wed, 6 Apr 2022 17:28:29 +0000 (UTC) Received: by mail-lf1-f47.google.com with SMTP id e16so5249566lfc.13 for ; Wed, 06 Apr 2022 10:28:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=WJLYFFwKJzu0AzBejzceyC93Fh4AhvIk3A/MNZXzKIU=; b=nHoFYmIVcbUdYBuRBczLdRhO5AcYZ6GHHFtKpS9G1n5vNIpBGLipmKmQ40hQnwfBEK 9YcCx5HGe8T4NG1UPywpqZKblDsiU8Uam6EvTYaei53mUEV7gX/X6QEIMPDVNdTe1RsC lSqUADllCjDlRJ3aqfDHj4gGsZ5WvTndElsOvm3ukXbURNWbOjm9tS3FKy9TW5JIte+s iqchodtdlLO+0839AsHapTHL+am4rmkQFqKuweIuQiuTq0iA/dxkHoEkiJl793SmXbAL d6FIVbXVTWtg6j4nPkHK8I7vb1+rBuBMN5T4ZVmgoa+qulAgS9/S0AV92hnwAdWJS/in gNUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=WJLYFFwKJzu0AzBejzceyC93Fh4AhvIk3A/MNZXzKIU=; b=L/vYJzM0enRK6GkiwnN3gStB/OiUCH0JwApaR0SCRw2SRpYtoZS/pVHWggcAZTr7eG Y7sENVG87wj4rPF60VWao09kUovK4wv8qIfHRNESskF+/40CKiP8jH74699qH3X1VUE3 45mE0VhZy3qBj6uFROyFu2UTj7cHAvPT7SzY26aFAB8i87uMnEhoJ54TAAHVD5QsLd3t zQI3kfbqMzEp0tjYAkN6yeJgrwr8qLq6X3q3r0+4ic/AUDvLHDubjJz3FNA+fb2EoyTj fCqXuJ6uh9k6McsimUuJy3+fTBZVs0y/3Cvq232nZZhvrS8UKzusQRuLpTvEJv6oG3f4 b2KQ== X-Gm-Message-State: AOAM530eCUDUWItKGc6k0hD3vdhCwuz77b4W10RLS946aIrvCCBEZyNM RpQkqNeR2mUk+KQIXG7+NByK2vrWzLguwpwr9As= X-Google-Smtp-Source: ABdhPJxvT7YhfWN8QbCVz4oydCsKwT/zbXQ5089WXaSZlqzdjbFflulVc086iBmKtewP4KtbC66vp+jW8qrWjcRFTmg= X-Received: by 2002:ac2:5f4d:0:b0:43e:da3e:4529 with SMTP id 13-20020ac25f4d000000b0043eda3e4529mr6768924lfz.627.1649266108188; Wed, 06 Apr 2022 10:28:28 -0700 (PDT) MIME-Version: 1.0 References: <20220406060516.409838-1-hch@lst.de> <20220406060516.409838-24-hch@lst.de> In-Reply-To: <20220406060516.409838-24-hch@lst.de> From: Ryusuke Konishi Date: Thu, 7 Apr 2022 02:28:15 +0900 Message-ID: Subject: Re: [PATCH 23/27] block: add a bdev_max_discard_sectors helper To: Christoph Hellwig Cc: Andreas Gruenbacher , Jens Axboe , device-mapper development , linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-um@lists.infradead.org, linux-block@vger.kernel.org, drbd-dev@lists.linbit.com, nbd@other.debian.org, ceph-devel@vger.kernel.org, virtualization@lists.linux-foundation.org, xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org, linux-raid@vger.kernel.org, linux-mmc@vger.kernel.org, linux-mtd@lists.infradead.org, linux-nvme@lists.infradead.org, linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, jfs-discussion@lists.sourceforge.net, linux-nilfs , ntfs3@lists.linux.dev, ocfs2-devel@oss.oracle.com, Linux MM Content-Type: text/plain; charset="UTF-8" Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=nHoFYmIV; spf=pass (imf24.hostedemail.com: domain of konishi.ryusuke@gmail.com designates 209.85.167.47 as permitted sender) smtp.mailfrom=konishi.ryusuke@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspam-User: X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 4228C180017 X-Stat-Signature: 7sf3enbxxkqg9nha3s1pdn5bg7p8jem8 X-HE-Tag: 1649266109-52713 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Apr 6, 2022 at 11:05 PM Christoph Hellwig wrote: > > Add a helper to query the number of sectors support per each discard bio > based on the block device and use this helper to stop various places from > poking into the request_queue to see if discard is supported and if so how > much. This mirrors what is done e.g. for write zeroes as well. > > Signed-off-by: Christoph Hellwig > --- ... > diff --git a/drivers/target/target_core_device.c b/drivers/target/target_core_device.c > index 16e775bcf4a7c..7d510e4231713 100644 > --- a/drivers/target/target_core_device.c > +++ b/drivers/target/target_core_device.c > @@ -829,9 +829,7 @@ struct se_device *target_alloc_device(struct se_hba *hba, const char *name) > } > > /* > - * Check if the underlying struct block_device request_queue supports > - * the QUEUE_FLAG_DISCARD bit for UNMAP/WRITE_SAME in SCSI + TRIM > - * in ATA and we need to set TPE=1 > + * Check if the underlying struct block_device request_queue supports disard. > */ Here was a typo: s/disard/discard/ On Thu, Apr 7, 2022 at 12:19 AM Andreas Gruenbacher wrote: > If I'm misreading things, could you please document that > bdev_max_discard_sectors() != 0 implies that discard is supported? I got the same impression. Checking the discard support with bdev_max_discard_sectors() != 0 seems a bit unclear than before. Thanks, Ryusuke Konishi