From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B00BC56201 for ; Fri, 23 Oct 2020 09:13:08 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8F7DF24182 for ; Fri, 23 Oct 2020 09:13:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="Xxk1aGPW" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8F7DF24182 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 9C0E86B005D; Fri, 23 Oct 2020 05:13:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 96FB56B0062; Fri, 23 Oct 2020 05:13:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 810956B0068; Fri, 23 Oct 2020 05:13:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0117.hostedemail.com [216.40.44.117]) by kanga.kvack.org (Postfix) with ESMTP id 52E486B005D for ; Fri, 23 Oct 2020 05:13:06 -0400 (EDT) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id DB0E2181AC9CC for ; Fri, 23 Oct 2020 09:13:05 +0000 (UTC) X-FDA: 77402625930.11.sheet06_5d0677c27258 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin11.hostedemail.com (Postfix) with ESMTP id AD687180F8B86 for ; Fri, 23 Oct 2020 09:13:05 +0000 (UTC) X-HE-Tag: sheet06_5d0677c27258 X-Filterd-Recvd-Size: 5510 Received: from mail-oi1-f194.google.com (mail-oi1-f194.google.com [209.85.167.194]) by imf01.hostedemail.com (Postfix) with ESMTP for ; Fri, 23 Oct 2020 09:13:04 +0000 (UTC) Received: by mail-oi1-f194.google.com with SMTP id k65so577663oih.8 for ; Fri, 23 Oct 2020 02:13:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=qM5nhEMYeFdEA7QerSEffOkMoRD8vG6Y+rmNtsxnjd4=; b=Xxk1aGPWSfFkpkis6OoEqJ2gCaQ0ahlPrRIzd5LTpnMwyB8U4J5r+K0BKl7hDE+eYN 3FcbH6Xq/dGBMGOJztPD8i+0aPOjlnDIfmE3yk5nKc52BxNSLHg2zElLlqf99LJUx8Jn jnSHwE5Y+hs0wMvh4+/GAgohgcKexUIqGABys= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=qM5nhEMYeFdEA7QerSEffOkMoRD8vG6Y+rmNtsxnjd4=; b=bbU0KGZAmy+ipARe7ZJtjMbxQdPP/Enx8H9wC/Ykk8RfC2tCNfRLnUx0I/cpfCofjx Eedzy8s+Ye9OV/vBYIqH1+ewngC4qYAFINP/PRJyxKvAsz1uEBQTIoohRyE7gDT+//8n WH1v4ugyyJ4PwVa4sdm0M6rhz1U0zEaM9Go8Mki0mCJuWmK/DTj1/NotNmNrUVj6V1WL oAviDogPIRjXkR385namAc49bYVqd0QijGtDHGtwsFhC8D/z7yF85Ey6aaRm6r61SobQ QyySxrisgHVfZVe/u1dRM6VR9W4okUA+H8+gia/HKKlGyP/Y0FQbXS6CoxahtVvt2N6d ZMrw== X-Gm-Message-State: AOAM533Dy+xSW2WlqGVIRC61CIDxrOI6qdKLI4/DfN6z1Z2UMU/E+LDe dUOziUzPcyhSLZ9ANvSkz/ah8ToQF1Q53gwEg6Bd2w== X-Google-Smtp-Source: ABdhPJxJfW2e7RMT1o53fgdROAZNOXDUkt9dx9afCHGb/w0gAtXuC9OHLmkK0ZV4M3byXb+A+RT/xRPrOH90bLENhKU= X-Received: by 2002:aca:39d6:: with SMTP id g205mr958482oia.14.1603444384107; Fri, 23 Oct 2020 02:13:04 -0700 (PDT) MIME-Version: 1.0 References: <20201021085655.1192025-1-daniel.vetter@ffwll.ch> <20201021085655.1192025-5-daniel.vetter@ffwll.ch> In-Reply-To: <20201021085655.1192025-5-daniel.vetter@ffwll.ch> From: Daniel Vetter Date: Fri, 23 Oct 2020 11:12:52 +0200 Message-ID: Subject: Re: [PATCH v3 04/16] misc/habana: Use FOLL_LONGTERM for userptr To: DRI Development , LKML Cc: KVM list , Linux MM , Linux ARM , linux-samsung-soc , "open list:DMA BUFFER SHARING FRAMEWORK" , linux-s390 , Daniel Vetter , Jason Gunthorpe , Andrew Morton , John Hubbard , =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , Jan Kara , Dan Williams , Oded Gabbay , Omer Shpigelman , Ofir Bitton , Tomer Tayar , Moti Haimovski , Greg Kroah-Hartman , Pawel Piskorski , Daniel Vetter Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Oded, Did testing on your end turn up anything, or can I put an ack&tested-by from you on the two habana patches for the next round? Thanks, Daniel On Wed, Oct 21, 2020 at 10:57 AM Daniel Vetter wro= te: > > These are persistent, not just for the duration of a dma operation. > > Signed-off-by: Daniel Vetter > Cc: Jason Gunthorpe > Cc: Andrew Morton > Cc: John Hubbard > Cc: J=C3=A9r=C3=B4me Glisse > Cc: Jan Kara > Cc: Dan Williams > Cc: linux-mm@kvack.org > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-samsung-soc@vger.kernel.org > Cc: linux-media@vger.kernel.org > Cc: Oded Gabbay > Cc: Omer Shpigelman > Cc: Ofir Bitton > Cc: Tomer Tayar > Cc: Moti Haimovski > Cc: Daniel Vetter > Cc: Greg Kroah-Hartman > Cc: Pawel Piskorski > Signed-off-by: Daniel Vetter > --- > drivers/misc/habanalabs/common/memory.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/misc/habanalabs/common/memory.c b/drivers/misc/haban= alabs/common/memory.c > index 327b64479f97..767d3644c033 100644 > --- a/drivers/misc/habanalabs/common/memory.c > +++ b/drivers/misc/habanalabs/common/memory.c > @@ -1288,7 +1288,8 @@ static int get_user_memory(struct hl_device *hdev, = u64 addr, u64 size, > return -ENOMEM; > } > > - rc =3D pin_user_pages_fast(start, npages, FOLL_FORCE | FOLL_WRITE= , > + rc =3D pin_user_pages_fast(start, npages, > + FOLL_FORCE | FOLL_WRITE | FOLL_LONGTERM, > userptr->pages); > > if (rc !=3D npages) { > -- > 2.28.0 > --=20 Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch