From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65EC9C4338F for ; Mon, 9 Aug 2021 14:08:41 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D0F4F60F38 for ; Mon, 9 Aug 2021 14:08:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org D0F4F60F38 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 575886B006C; Mon, 9 Aug 2021 10:08:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 525F78D0001; Mon, 9 Aug 2021 10:08:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 414C26B0073; Mon, 9 Aug 2021 10:08:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0217.hostedemail.com [216.40.44.217]) by kanga.kvack.org (Postfix) with ESMTP id 280776B006C for ; Mon, 9 Aug 2021 10:08:40 -0400 (EDT) Received: from smtpin02.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id C6C16181CBC31 for ; Mon, 9 Aug 2021 14:08:39 +0000 (UTC) X-FDA: 78455722758.02.65405BF Received: from mail-ej1-f51.google.com (mail-ej1-f51.google.com [209.85.218.51]) by imf13.hostedemail.com (Postfix) with ESMTP id 8AF5E100F0C4 for ; Mon, 9 Aug 2021 14:08:39 +0000 (UTC) Received: by mail-ej1-f51.google.com with SMTP id w5so5057904ejq.2 for ; Mon, 09 Aug 2021 07:08:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=zR6+b4jMQHu+xJ/A9TlI8gnwYind6t4cL5CmTg0J/sg=; b=laQXcY5+l2yqZ9bgjlwSlIh613HtIDArhrDi5bmvioCLPLweoajCRMFawJpgJDsC3C s8KladoRM2g6c7xOCe6VjpAuP5eh79bw0GdM8eWYtRACCZjEHjHMZqVCSTxmXDWJ+vUz FWv1LJdCNk4/TF0UFzvsNTzy4tDDAPsR53mstI20F0Ry+jyesy8fxEtCrzNpMTShAGfd tUGZKXwNFdaVPqoIaJ3/n90RHpL4C0jKEyuPFIyTMJTlFOazUZI9bfO7vusiM4JUi3ts cuWxU1vc0xSyqgSgXvFEUO6at1JDkZKFWdkJ6MnqUTdOvzf8GI+RcV5/OilNBicyUKk2 OkCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=zR6+b4jMQHu+xJ/A9TlI8gnwYind6t4cL5CmTg0J/sg=; b=LESCsiv6bIGs2Qb8PvrrgwBoDSbL2qmaiy7IY95PnYxfOjUB2VOvxYW1UtHsWR22YZ dEZLFIrWq6ZQUQbK3KMjRRuxtypkE5pu0veXoFwZ4blZeS/vicG9S12b8ovl9X4L6o7F J/22mntdWfOqOYZUAPzRg2ae4XnvG2dlVk+2/gPoL4Bz1pkU2fww0PNDHiKDPA2HDkLK 0xdB+MIjQ3OGxt+9LoEvRJ8e/5uUdZ5AhPZ0Qh6Dcv2YRD7mCgXq1K/iz1MIxpscpLmw vBZ+1N+PMAJh16/CbCFvJnanF/pPL+5vbiLDzV4ZW3UBgSOGGj7jVLbBmtGJRafF7IMK TCoQ== X-Gm-Message-State: AOAM532gVfcxMlw3HO9qHsd+R9U7s4rUxR6oLJcUl01WE9AwpQLKVwTu PC+XTtCu5EbdLvErOR5vDUxl3ClP6K3lOhbWSUQ= X-Google-Smtp-Source: ABdhPJwTh+xvPOetWpwQq87E8NuXpPo+Arodp6MN1X8piZv3IFZ/2VSBmQdMIXxfBXGnLDrhZ3HSqMJvjpRDf3vl7Ok= X-Received: by 2002:a17:907:9851:: with SMTP id jj17mr5002781ejc.489.1628518117708; Mon, 09 Aug 2021 07:08:37 -0700 (PDT) MIME-Version: 1.0 References: <20210805190253.2795604-1-zi.yan@sent.com> <20210805190253.2795604-12-zi.yan@sent.com> In-Reply-To: <20210805190253.2795604-12-zi.yan@sent.com> From: Alexander Duyck Date: Mon, 9 Aug 2021 07:08:26 -0700 Message-ID: Subject: Re: [RFC PATCH 11/15] mm/page_reporting: report pages at section size instead of MAX_ORDER. To: Zi Yan Cc: David Hildenbrand , linux-mm , Matthew Wilcox , Vlastimil Babka , "Kirill A . Shutemov" , Mike Kravetz , Michal Hocko , John Hubbard , LKML Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 8AF5E100F0C4 Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=laQXcY5+; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf13.hostedemail.com: domain of alexanderduyck@gmail.com designates 209.85.218.51 as permitted sender) smtp.mailfrom=alexanderduyck@gmail.com X-Stat-Signature: brn7ben9y81km8qq7m3fekfh934nmpd8 X-HE-Tag: 1628518119-286604 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Aug 5, 2021 at 12:04 PM Zi Yan wrote: > > From: Zi Yan > > page_reporting_order was set to MAX_ORDER, which is always smaller than > a memory section size. An upcoming change will make MAX_ORDER larger > than a memory section size. Set page_reporting_order to > PFN_SECTION_SHIFT to match existing size assumption. > > Signed-off-by: Zi Yan > Cc: David Hildenbrand > Cc: linux-mm@kvack.org > Cc: linux-kernel@vger.kernel.org > --- > mm/page_reporting.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/mm/page_reporting.c b/mm/page_reporting.c > index 382958eef8a9..dc4a2d699862 100644 > --- a/mm/page_reporting.c > +++ b/mm/page_reporting.c > @@ -11,7 +11,8 @@ > #include "page_reporting.h" > #include "internal.h" > > -unsigned int page_reporting_order = MAX_ORDER; > +/* Set page_reporting_order at section size */ > +unsigned int page_reporting_order = PFN_SECTION_SHIFT; > module_param(page_reporting_order, uint, 0644); > MODULE_PARM_DESC(page_reporting_order, "Set page reporting order"); The MAX_ORDER assumption is correct. The general idea with this being set to MAX_ORDER is that the processing is from page_reporting_order to MAX_ORDER. So with it set to MAX_ORDER then page reporting is disabled.