From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9DEEAC432BE for ; Mon, 9 Aug 2021 14:12:18 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3737F60F6F for ; Mon, 9 Aug 2021 14:12:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 3737F60F6F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 91BA76B006C; Mon, 9 Aug 2021 10:12:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8CB4F6B0071; Mon, 9 Aug 2021 10:12:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7BB036B0073; Mon, 9 Aug 2021 10:12:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0171.hostedemail.com [216.40.44.171]) by kanga.kvack.org (Postfix) with ESMTP id 612406B006C for ; Mon, 9 Aug 2021 10:12:17 -0400 (EDT) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 0DF47182301E6 for ; Mon, 9 Aug 2021 14:12:17 +0000 (UTC) X-FDA: 78455731914.19.7CAD484 Received: from mail-ej1-f42.google.com (mail-ej1-f42.google.com [209.85.218.42]) by imf09.hostedemail.com (Postfix) with ESMTP id B342F300011D for ; Mon, 9 Aug 2021 14:12:16 +0000 (UTC) Received: by mail-ej1-f42.google.com with SMTP id qk33so29175099ejc.12 for ; Mon, 09 Aug 2021 07:12:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=kbEqHeQWK/LPgTWzyZ8GR03WKkNPEpinF3U/H1OFgTs=; b=RbTqP57SNdmg5Ko5v7a25j0pgLWHyoDmSCsQjeMU2i49vbQMJICtocflgalQRqHRs0 lEvT48OXxeQ9ibQ6Gjv5vyej3Lv2FwAFXNj/7NRodGJzAz5ghStneYJDUfhYbMebVhSd L8ZD3o1nWWP0s14+kHaSf/JgElr9+lFf1CIXhBm/LhLlD8BfhKpcWZHTe0FXSGCiXFN8 XVBdzBoC8xkXoN+62PZCEQxFEtC15pyzcd2fumav9m4LDOlEYY+8skzWQRhFHy9fllUY IU4UjiqZGp6jco3OXDD1OhNDhD2AixumFyyGaj4jodo+k5pRnntsFFTBXWZNfmHo3fMI 5FeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=kbEqHeQWK/LPgTWzyZ8GR03WKkNPEpinF3U/H1OFgTs=; b=fx5M3ad0MKWachdpjUtyUAX9n6svC0U9wshs/4Qthi2Z+AyR5DtzVIvE5SW2QeuHGJ PEZ1KFyVO8FuMMHkjNtCMjeH08tuhAcWsun920AmuWb+XfHKfgVKhhIVtaSvJYskEvNl Se3AtD2LJwViO6930cbpZr1fvqJNTYGKNwQWvRUoKkUbNqiWzhkZ/7gDeYdBsAKCe5nF wSgAErn5s38F1boJbvDTfY6RSh0XzkEn2Ttg04x81nv2jbzyasNakrwf6PR27Cwts7DT pmbkJ8LH5IHJ81gVPcbDmKvOS78p6M74PRgsmeUxzPoflReG+UUStACjMOlibN4Xlx+7 SKQw== X-Gm-Message-State: AOAM531PKy/TD5RUJrPq6Mj3W2AnbVDtIZlgaQOoijFEMJMP5aBNnz4h uCHDdX9h8vcya0t2T1ENiiKjdMhwPMFhOc/A3Yo= X-Google-Smtp-Source: ABdhPJyz+W3DDmMJVT1/YdURzVnHR41n2Hf20CNB9uEXLrdkdPYLu3UdLVhAoJAGLNoggNO0I2dHnRirOk9Z8mLyzcY= X-Received: by 2002:a17:906:d0d5:: with SMTP id bq21mr3824098ejb.470.1628518335552; Mon, 09 Aug 2021 07:12:15 -0700 (PDT) MIME-Version: 1.0 References: <20210805190253.2795604-1-zi.yan@sent.com> <20210805190253.2795604-12-zi.yan@sent.com> In-Reply-To: From: Alexander Duyck Date: Mon, 9 Aug 2021 07:12:04 -0700 Message-ID: Subject: Re: [RFC PATCH 11/15] mm/page_reporting: report pages at section size instead of MAX_ORDER. To: David Hildenbrand Cc: Zi Yan , linux-mm , Matthew Wilcox , Vlastimil Babka , "Kirill A . Shutemov" , Mike Kravetz , Michal Hocko , John Hubbard , LKML Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: B342F300011D Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=RbTqP57S; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf09.hostedemail.com: domain of alexanderduyck@gmail.com designates 209.85.218.42 as permitted sender) smtp.mailfrom=alexanderduyck@gmail.com X-Stat-Signature: ongqfhwcqrsiz9mourz5p515635aq5eo X-HE-Tag: 1628518336-541177 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Aug 9, 2021 at 12:25 AM David Hildenbrand wrote: > > On 05.08.21 21:02, Zi Yan wrote: > > From: Zi Yan > > > > page_reporting_order was set to MAX_ORDER, which is always smaller than > > a memory section size. An upcoming change will make MAX_ORDER larger > > than a memory section size. Set page_reporting_order to > > PFN_SECTION_SHIFT to match existing size assumption. > > > > Signed-off-by: Zi Yan > > Cc: David Hildenbrand > > Cc: linux-mm@kvack.org > > Cc: linux-kernel@vger.kernel.org > > --- > > mm/page_reporting.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/mm/page_reporting.c b/mm/page_reporting.c > > index 382958eef8a9..dc4a2d699862 100644 > > --- a/mm/page_reporting.c > > +++ b/mm/page_reporting.c > > @@ -11,7 +11,8 @@ > > #include "page_reporting.h" > > #include "internal.h" > > > > -unsigned int page_reporting_order = MAX_ORDER; > > +/* Set page_reporting_order at section size */ > > +unsigned int page_reporting_order = PFN_SECTION_SHIFT; > > module_param(page_reporting_order, uint, 0644); > > MODULE_PARM_DESC(page_reporting_order, "Set page reporting order"); > > > > > > If you look closely, this is only a placeholder and will get overwritten > in page_reporting_register(). I don't recall why we have the module > parameter at all. Most probably, to adjust the reporting order after we > already registered a user. Can't we just initialize that to 0 ? Yeah, it is pretty much there for debugging in the event that we are on an architecture that is misconfigured.