From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 164CBC2B9F4 for ; Wed, 23 Jun 2021 00:53:06 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 9608860BD3 for ; Wed, 23 Jun 2021 00:53:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9608860BD3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 7A9C56B0011; Tue, 22 Jun 2021 20:53:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 758E66B0036; Tue, 22 Jun 2021 20:53:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5F9A56B006C; Tue, 22 Jun 2021 20:53:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0199.hostedemail.com [216.40.44.199]) by kanga.kvack.org (Postfix) with ESMTP id 29F656B0011 for ; Tue, 22 Jun 2021 20:53:04 -0400 (EDT) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 4D748181AF5D0 for ; Wed, 23 Jun 2021 00:53:04 +0000 (UTC) X-FDA: 78283164288.10.95717E6 Received: from mail-ej1-f51.google.com (mail-ej1-f51.google.com [209.85.218.51]) by imf14.hostedemail.com (Postfix) with ESMTP id 0C293C01C08A for ; Wed, 23 Jun 2021 00:53:03 +0000 (UTC) Received: by mail-ej1-f51.google.com with SMTP id hq39so1202359ejc.5 for ; Tue, 22 Jun 2021 17:53:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=jH7iUURrAiDk+cT3IrPOIgrQxuyayPVjMUhca6ijBQs=; b=FqOJyN82v2J9evYhR+wrWK0aYaeePp5ma7L26fb58iyUltTfha5jAs4IOzZGtbCJJ+ U+xWkWbMSknVrZsitnh/riIFzHPSY6/TwmKYRAcklBpMncFa9oEHmi8rHXx0AZRbqwcV KIPAO15XpA7pMr2PIYJNigTxp1bwrnN2Vj5tVfRFhtjxRUA6GxP2ZPuDolVdVNQ3F5rw TDwKSb6+3YcGubEBNtOiqNXK30QNHpY2PGmq8Pz45HR0O/6htwRIgGkAm1Kq7AjTnGdu JmS8N4Ryxjd5pXs1CTIyKSFwz5GglDTrcDaAsEML/qKcxaiO/YDDBKOzSrHMRC0W7PdU LKOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=jH7iUURrAiDk+cT3IrPOIgrQxuyayPVjMUhca6ijBQs=; b=S0AJdxkTrB6CY01lZi2fXkot1Ky6g8KXCQ2z5+WHVAUP5dSQZiz0jRZ7NIaM2J+F8d wOHnQDRRXkvGI228K6syR095fLh68YQeMXi9SoQo8lkXAPHg7r1JyTVAC9wT6ovTx+Ga y6ffQlV6zb1DaC1gey6bEY8hxjbfOxH7uH/rsQ0UKGrhuhdOOc3ViyBchvW8bgexlx4g 7mwpOnojPyLUT0W/F9WFXcJ7kOg6fT60rNw0o90GdKZFHNPGjjl/uQnldVOghgnybaAS yel29Jx1MQXKeL8mKhuhoOnzeArxJUU0E9ZCBtaegote0NBaz+8dMUezfvVS2K3Om9DU oLzw== X-Gm-Message-State: AOAM530HZDy8wLu4HSThg9hsU8TD8c6uRS5p2luvndT3dh2rtsbO1AVx F4aqZwoIa3MOhgRk+yb7UGLECMI/hegC6XTG9zA= X-Google-Smtp-Source: ABdhPJyuBXFdSe/E++xVsFW4b3BeOoSVo/dFWWRcoPERyiY00elF5kXK0SCMQInHjnsscq+7XOt8+nunQ6TJiHFKhow= X-Received: by 2002:a17:906:1f11:: with SMTP id w17mr6866670ejj.33.1624409582771; Tue, 22 Jun 2021 17:53:02 -0700 (PDT) MIME-Version: 1.0 References: <20210623023418.350616-1-gshan@redhat.com> In-Reply-To: <20210623023418.350616-1-gshan@redhat.com> From: Alexander Duyck Date: Tue, 22 Jun 2021 17:52:51 -0700 Message-ID: Subject: Re: [PATCH v3 0/4] mm/page_reporting: Make page reporting work on arm64 with 64KB page size To: Gavin Shan Cc: linux-mm , David Hildenbrand , "Michael S. Tsirkin" , Andrew Morton , Anshuman Khandual , Catalin Marinas , Will Deacon , shan.gavin@gmail.com Content-Type: text/plain; charset="UTF-8" Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=FqOJyN82; spf=pass (imf14.hostedemail.com: domain of alexanderduyck@gmail.com designates 209.85.218.51 as permitted sender) smtp.mailfrom=alexanderduyck@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 0C293C01C08A X-Stat-Signature: 8xy9bbcoa5uw6jcd6mrdusf9tcqx5dtn X-HE-Tag: 1624409583-159030 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: So the series looks okay, although I would strongly suggest getting to work on the virtio_ballon patches to enable reporting the min_order of the host so that you can override the value in cases where the host is actually using 512M pages. For the series: Reviewed-by: Alexander Duyck On Tue, Jun 22, 2021 at 5:34 PM Gavin Shan wrote: > > The page reporting threshold is currently equal to @pageblock_order, which > is 13 and 512MB on arm64 with 64KB base page size selected. The page > reporting won't be triggered if the freeing page can't come up with a free > area like that huge. The condition is hard to be met, especially when the > system memory becomes fragmented. > > This series intends to solve the issue by having page reporting threshold > as 5 (2MB) on arm64 with 64KB base page size. The patches are organized as: > > PATCH[1/4] Fix some coding style in __page_reporting_request(). > PATCH[2/4] Represents page reporting order with variable so that it can > be exported as module parameter. > PATCH[3/4] Allows the device driver (e.g. virtio_balloon) to specify > the page reporting order when the device info is registered. > PATCH[4/4] Specifies the page reporting order to 5, corresponding to > 2MB in size on ARM64 when 64KB base page size is used. > > Changelog > ========= > v3: > * Avoid overhead introduced by function all (Alex) > * Export page reporting order as module parameter (Gavin) > v2: > * Rewrite the patches as Alex suggested (Alex) > > Gavin Shan (4): > mm/page_reporting: Fix code style in __page_reporting_request() > mm/page_reporting: Export reporting order as module parameter > mm/page_reporting: Allow driver to specify reporting order > virtio_balloon: Specify page reporting order if needed > > Documentation/admin-guide/kernel-parameters.txt | 6 ++++++ > drivers/virtio/virtio_balloon.c | 17 +++++++++++++++++ > include/linux/page_reporting.h | 3 +++ > mm/page_reporting.c | 16 ++++++++++++---- > mm/page_reporting.h | 5 ++--- > 5 files changed, 40 insertions(+), 7 deletions(-) > > -- > 2.23.0 >