From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9BD0BC433EF for ; Fri, 4 Feb 2022 13:21:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BF5236B0072; Fri, 4 Feb 2022 08:21:52 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B7D086B0073; Fri, 4 Feb 2022 08:21:52 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9F6946B0074; Fri, 4 Feb 2022 08:21:52 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0046.hostedemail.com [216.40.44.46]) by kanga.kvack.org (Postfix) with ESMTP id 8A1186B0072 for ; Fri, 4 Feb 2022 08:21:52 -0500 (EST) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 2AD4B998CF for ; Fri, 4 Feb 2022 13:21:52 +0000 (UTC) X-FDA: 79105160064.06.0393AC1 Received: from mail-yb1-f170.google.com (mail-yb1-f170.google.com [209.85.219.170]) by imf03.hostedemail.com (Postfix) with ESMTP id C1F6E20008 for ; Fri, 4 Feb 2022 13:21:51 +0000 (UTC) Received: by mail-yb1-f170.google.com with SMTP id j2so18818693ybu.0 for ; Fri, 04 Feb 2022 05:21:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eclypsium.com; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=+kHxAPwxyZEcImebt/hCxo31GYUl4Y9JyOP0KTd0RjQ=; b=Xk+XdovZ9A6qq+rxZKTZ2zFvnkt4TLtrm+p3BP7FGwRMLKm2/kzYFkkKSBaPHgehn0 ZX/lCNP2k5uePIG4/RAMYbe2LE6DkvtaUo9MH7gbmNmx0WKi/+Ec3KT9z07csS2ASm4U rXyvUirAiPY/KhaQRx5/aIPjPZILen3VccmkM3sT5nKGu2W7e7ugtzkOS1AnkSWHxFg1 Ma6qPtGcbSS/5HrMaVgXH8WctYtelboEsr6w9+88bFbmwXKLwoGcglwehyK+X5DnK+Ml 4IbdbjalA4JIuAtfZ7INJ/RzlrLNM06YUg/LEgSKcTYh7sUd4H4EQsHgZOa8p7zcM6j4 ij8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=+kHxAPwxyZEcImebt/hCxo31GYUl4Y9JyOP0KTd0RjQ=; b=LBiH7OBOULIRX3CgP5Gb2ynE6OFAA+RrhfBI80FKXE+pAo9yX116/e/9aFterD8/eC f43UNP4Gza2CJ0B0towSBT+U+QiIdz3jMdp5wRmnWWykxyUC2HYZM9fJvINlEykcbUpB /ewhIQZWM5C61R7RGJ3o4okQ2i0863TUhVWiB1lWcYMM9G9yCCYpWpvNYXXdgZnVRobQ khfCdEuGufkoi5Hr/WQUY5y+ftacl+YQ1kg6LcgqfalU39UW2M4dof7SlPhuYFl4N7KP fXhxvJtjGsiWYOuGnBpr2KviFAFDiNGgMZTUBiCHr/p6blPJWJTRoGypfclzV/OEB3Ym y44A== X-Gm-Message-State: AOAM530dc8yEc9BZNbnKmRsqNaziIa/cUwmunnh7ikifX8+wDgBeDCzS 9cvk/eKQrQEgHj3hWPq/p+ayVovvPqY0weS9T8+4gw== X-Google-Smtp-Source: ABdhPJxtI9yIZAtwdVT04ufmqMOyAiqHsH0A4Hy4uwN6eFDfMocj5rHcvKETbFuiByKZy35TW0cJK+HFULlj9RIdImk= X-Received: by 2002:a25:b805:: with SMTP id v5mr2552677ybj.266.1643980910826; Fri, 04 Feb 2022 05:21:50 -0800 (PST) MIME-Version: 1.0 Received: by 2002:a81:1756:0:0:0:0:0 with HTTP; Fri, 4 Feb 2022 05:21:50 -0800 (PST) In-Reply-To: <67d2711b-200c-0894-4ff7-beb3eb304399@amd.com> References: <20220203164328.203629-1-martin.fernandez@eclypsium.com> <20220203164328.203629-7-martin.fernandez@eclypsium.com> <67d2711b-200c-0894-4ff7-beb3eb304399@amd.com> From: Martin Fernandez Date: Fri, 4 Feb 2022 10:21:50 -0300 Message-ID: Subject: Re: [PATCH v6 6/6] drivers/node: Show in sysfs node's crypto capabilities To: "Limonciello, Mario" Cc: linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-mm@kvack.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, ardb@kernel.org, dvhart@infradead.org, andy@infradead.org, gregkh@linuxfoundation.org, rafael@kernel.org, rppt@kernel.org, akpm@linux-foundation.org, daniel.gutson@eclypsium.com, hughsient@gmail.com, alex.bazhaniuk@eclypsium.com, alison.schofield@intel.com, keescook@chromium.org, "Lendacky, Thomas" Content-Type: text/plain; charset="UTF-8" X-Stat-Signature: 1s7gxquibnz93uxa9tn7rkofgas53ycn X-Rspam-User: nil Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=eclypsium.com header.s=google header.b=Xk+XdovZ; spf=pass (imf03.hostedemail.com: domain of martin.fernandez@eclypsium.com designates 209.85.219.170 as permitted sender) smtp.mailfrom=martin.fernandez@eclypsium.com; dmarc=pass (policy=quarantine) header.from=eclypsium.com X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: C1F6E20008 X-HE-Tag: 1643980911-345466 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2/4/22, Limonciello, Mario wrote: > On 2/3/2022 10:43, Martin Fernandez wrote: >> +static ssize_t crypto_capable_show(struct device *dev, >> + struct device_attribute *attr, char *buf) >> +{ >> + struct pglist_data *pgdat = NODE_DATA(dev->id); >> + >> + return sysfs_emit(buf, "%d\n", pgdat->crypto_capable); > > As there is interest in seeing these capabilities from userspace, it > seems like a logical time to also expose a `crypto_active` attribute. I planned to do something similar to this, but to show (or actually hide if inactive) tme in cpuinfo, just as Borislav Petkov suggested a few versions back. https://lore.kernel.org/linux-efi/YXrnkxgdjWbcPlJA@zn.tnic/ > Then userspace can make a judgement call if the system supports crypto > memory (`crypto_capable`) and then also whether or not it's been turned > on (`crypto_active`). > > `crypto_active` could be detected with some existing support in the > kernel of `mem_encrypt_active()`. This will then work for a variety of > architectures too that offer `mem_encrypt_active()`. I need a hand with this, I grepped for mem_encrypt_active and nothing showed up... > As it stands today the only reliable way to tell from userspace (at > least for AMD's x86 implementation) is by grepping the system log for > the line "AMD Memory Encryption Features active". Isn't enough to grep for sme/sev in cpuinfo?