From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1420EC433EF for ; Thu, 3 Feb 2022 18:24:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 72EA86B0071; Thu, 3 Feb 2022 13:24:31 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6DF546B0072; Thu, 3 Feb 2022 13:24:31 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5A5B76B0074; Thu, 3 Feb 2022 13:24:31 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0122.hostedemail.com [216.40.44.122]) by kanga.kvack.org (Postfix) with ESMTP id 4B1586B0071 for ; Thu, 3 Feb 2022 13:24:31 -0500 (EST) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 0C207180ED7B9 for ; Thu, 3 Feb 2022 18:24:31 +0000 (UTC) X-FDA: 79102293942.12.9E8FC1D Received: from mail-yb1-f175.google.com (mail-yb1-f175.google.com [209.85.219.175]) by imf20.hostedemail.com (Postfix) with ESMTP id A0D241C0007 for ; Thu, 3 Feb 2022 18:24:30 +0000 (UTC) Received: by mail-yb1-f175.google.com with SMTP id c6so11612117ybk.3 for ; Thu, 03 Feb 2022 10:24:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eclypsium.com; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=1fRhWHaiX3rkmKEuOvxk4MdWU+5ch329S/1ViDgbzuQ=; b=KX8rWrzrI4SmeeXMyhAJN94FJ/BtvuLWK+a+fEtNaIBeSUb/nXfmIj+MN9RQ0o7+mQ SwQe77+rarjoaurkLkwjWstN1NWmV+xd9D3Wn3XvJSyJukBCZpXcmD/HDqOwApqaTAak XGNvn02OrLI5jDtuy9UljW7DOLBN7KMgFEyXf/gf/4VpE4WqqiBa3B4q9wF3v5tDvzFs AqHfqKsKQt/6eF0lcKT5E8BYQjGIkPqsswV9TXkfHqhy55m1gPO5L0xwD4gXLybdIrfq zJUjnTeaQQUUkGj6vSUElVHZzCuVzQxX9ETcx+/12BQY9watxH97OYFpCpLkWbPlIgZz tXfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=1fRhWHaiX3rkmKEuOvxk4MdWU+5ch329S/1ViDgbzuQ=; b=al283Vn/Uq3bFKK6nX6z9xrbLoSOYnz17GymjETxt40oLEJvlZtEYHygRN1ZYbugdr SNsrQTlxs1Ij2LJ6mn2LvSwr7Yy5mUFoDNq/flEco0cMf4hXGzPHhGLHYpTp1M/ZYHcS PMcwUZ+ua0dGHsEIpALikIo5dTtUCGcG1FGR84AKUhjAYyvHvDQMeshIrOBkEUDIdYd3 EeDOiCbzxUfO4OkENwVAkPLzPjie89nMA6IlYaUTg+ravyeHxaNnHBVxm0Q4SpCx5ik7 DOC/cpP9ca4lxKhYbTRA/ESATE9STSPbLaM/tbWqwjjK7GkQIarXunMBUOqThHetEd5P wIgg== X-Gm-Message-State: AOAM531l/nwq7Qd7FXZsPOKlh9qgnlYUI4gL3ds9EcjIDQ6JckXAJP86 Cm7s/jpjlNTdgf+boGisaCrZusysyZ8kBeeHAUKzDw== X-Google-Smtp-Source: ABdhPJwUT60W3ByLAudmauSaRtgoF18uDF+5y3xNpKLwb86Fuj5obEj1Uw0y9+Xke1Xujg5UscpZstiv8/jNzr6gMZE= X-Received: by 2002:a81:1d8f:: with SMTP id d137mr5310092ywd.383.1643912669833; Thu, 03 Feb 2022 10:24:29 -0800 (PST) MIME-Version: 1.0 Received: by 2002:a81:1756:0:0:0:0:0 with HTTP; Thu, 3 Feb 2022 10:24:29 -0800 (PST) In-Reply-To: References: <20220203164328.203629-1-martin.fernandez@eclypsium.com> <20220203164328.203629-2-martin.fernandez@eclypsium.com> From: Martin Fernandez Date: Thu, 3 Feb 2022 15:24:29 -0300 Message-ID: Subject: Re: [PATCH v6 1/6] mm/memblock: Tag memblocks with crypto capabilities To: Mike Rapoport Cc: linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-mm@kvack.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, ardb@kernel.org, dvhart@infradead.org, andy@infradead.org, gregkh@linuxfoundation.org, rafael@kernel.org, akpm@linux-foundation.org, daniel.gutson@eclypsium.com, hughsient@gmail.com, alex.bazhaniuk@eclypsium.com, alison.schofield@intel.com, keescook@chromium.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: A0D241C0007 X-Stat-Signature: xdjdru64axtr3gaznue1a37nanq9onxe X-Rspam-User: nil Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=eclypsium.com header.s=google header.b=KX8rWrzr; spf=pass (imf20.hostedemail.com: domain of martin.fernandez@eclypsium.com designates 209.85.219.175 as permitted sender) smtp.mailfrom=martin.fernandez@eclypsium.com; dmarc=pass (policy=quarantine) header.from=eclypsium.com X-HE-Tag: 1643912670-248847 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2/3/22, Mike Rapoport wrote: > On Thu, Feb 03, 2022 at 01:43:23PM -0300, Martin Fernandez wrote: >> +/** >> + * memblock_node_is_crypto_capable - get if whole node is capable >> + * of encryption >> + * @nid: number of node >> + * >> + * Iterate over all memory memblock_type and find if all regions under >> + * node @nid are capable of hardware encryption. >> + * >> + * Return: >> + * true if every region in memory memblock_type is capable of >> + * encryption, false otherwise. >> + */ >> +bool __init_memblock memblock_node_is_crypto_capable(int nid) >> +{ >> + struct memblock_region *region; >> + bool crypto_capable = false; >> + bool not_crypto_capable = false; >> + >> + for_each_mem_region(region) { >> + if (memblock_get_region_node(region) == nid) { >> + crypto_capable = >> + crypto_capable || >> + (region->flags & MEMBLOCK_CRYPTO_CAPABLE); >> + not_crypto_capable = >> + not_crypto_capable || >> + !(region->flags & MEMBLOCK_CRYPTO_CAPABLE); > > Isn't > > if (region->flags & MEMBLOCK_CRYPTO_CAPABLE) > crypto_capable++; > else > not_crypto_capable++; > > simpler and clearer? > > (of course s/bool/int in the declaration) > Yes! It is. I like that. >> + } >> + } >> + >> + if (crypto_capable && not_crypto_capable) >> + pr_warn_once("Node %d has regions that are encryptable and regions that >> aren't", >> + nid); > > This will print only the first node with mixed regions. With a single > caller of memblock_node_is_crypto_capable() I think pr_warn() is ok. > Yes, you are correct, don't really want _once here.