From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5A23C4363A for ; Wed, 21 Oct 2020 20:23:24 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 1620121D6C for ; Wed, 21 Oct 2020 20:23:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="u9o+ks4L" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1620121D6C Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 6EAAE6B005D; Wed, 21 Oct 2020 16:23:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 674966B0062; Wed, 21 Oct 2020 16:23:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 53C6D6B0068; Wed, 21 Oct 2020 16:23:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0050.hostedemail.com [216.40.44.50]) by kanga.kvack.org (Postfix) with ESMTP id 277D46B005D for ; Wed, 21 Oct 2020 16:23:23 -0400 (EDT) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 9FAEC181AEF09 for ; Wed, 21 Oct 2020 20:23:22 +0000 (UTC) X-FDA: 77397057444.03.spade48_0b0d3a52724b Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin03.hostedemail.com (Postfix) with ESMTP id 7356928A4E8 for ; Wed, 21 Oct 2020 20:23:22 +0000 (UTC) X-HE-Tag: spade48_0b0d3a52724b X-Filterd-Recvd-Size: 4518 Received: from mail-pg1-f180.google.com (mail-pg1-f180.google.com [209.85.215.180]) by imf03.hostedemail.com (Postfix) with ESMTP for ; Wed, 21 Oct 2020 20:23:21 +0000 (UTC) Received: by mail-pg1-f180.google.com with SMTP id n16so2148232pgv.13 for ; Wed, 21 Oct 2020 13:23:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=V+s7Ur1cmG5XqfTGOC/3u1pEc/MJLj9wk8CuInHNfl0=; b=u9o+ks4LjBOspKLmy2nyynqoBHh72LwZahO4wvabcZIKXobljmI08z32I7gYeTjSv8 seryJm+J7Smc6ZmBzbscs/8VQb31DY3hgnDvlZ6xBx2A18Dol4MFV08Kme2W39g+Dgwi y9uOlIGO/TPcPqXUT1ko2Q7XS0xkxCjKR9VTvFDXsN8rJXW7G39x4yt2IIGUrK2Gs4bM I/55fD9Fw8DMf0CY2B0G8dXzK5RX5jiFDw6SpzeXeKLt2JX3SUNsLhS54aAApjuKmqIg TT8CQGejVYOPEycZFFTyY6EIfivQw+cZ5G+izSNSd2xfXKlylHUnqhUj4pZaHJ9Gst/6 qtEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=V+s7Ur1cmG5XqfTGOC/3u1pEc/MJLj9wk8CuInHNfl0=; b=BJNfhW2O5tSIFoqfYt+uXpPi7UO8STD1wOQDVBRr+dbOnaWz0mY43FP25zrKW5JEH5 Ak2j8vp9SwliH9JgnqhfhytvS9Kt9N1bVTbhFc3Ah9yyaV89hKiuymMUvpNXuDwWwOHQ muvVUUjzb2LgsRgBx2pGbIHvah9cikC4yi3ftedMooeubLwSJBXuvo+8djZ+UIYnh0kz DDx58RdPZIXkVjdoZ3wBYnGJ3dywtZu61R3/6KXoNn7nH3+y3JpoXi9GtSsJdZJvKDr4 0bVzDZj8FjWNu4jKi2IHO9+SZPQj25ZG4eZHtVwedkI6C/xv+4knL4FRjT4SBIvCIZiN 789w== X-Gm-Message-State: AOAM530f9Jh2XMnhhQOveVTtrS9lyFQaEOCSJaqAn5FMcBaXepdrMEpu KmxvnsryFF7sT1u7LNBUfwRLwI78FApDtUktpZsokQ== X-Google-Smtp-Source: ABdhPJwZ8di/I0Rw8/MnM4OjvLQmXHmKCdAD3LHxy/vTzE3YpGKvn1cDuXqKM3tMdH0hFxN1YJlF5IeIucQDHuvlJbk= X-Received: by 2002:a62:1613:0:b029:152:743c:355c with SMTP id 19-20020a6216130000b0290152743c355cmr5213068pfw.15.1603311800680; Wed, 21 Oct 2020 13:23:20 -0700 (PDT) MIME-Version: 1.0 References: <1cecfbfc853b2e71a96ab58661037c28a2f9280e.camel@perches.com> In-Reply-To: <1cecfbfc853b2e71a96ab58661037c28a2f9280e.camel@perches.com> From: Nick Desaulniers Date: Wed, 21 Oct 2020 13:23:08 -0700 Message-ID: Subject: Re: [PATCH -next] treewide: Remove stringification from __alias macro definition To: Joe Perches Cc: Ard Biesheuvel , Thomas Gleixner , Borislav Petkov , X86 ML , "H. Peter Anvin" , Miguel Ojeda , Marco Elver , Dmitry Vyukov , Herbert Xu , "David S. Miller" , Andrey Ryabinin , Alexander Potapenko , Andrew Morton , Linux Kernel Mailing List , linux-efi , kasan-dev , Linux Crypto Mailing List , linux-mm Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Oct 21, 2020 at 12:07 PM Joe Perches wrote: > > On Wed, 2020-10-21 at 21:02 +0200, Ard Biesheuvel wrote: > > On Wed, 21 Oct 2020 at 20:58, Joe Perches wrote: > > > Like the __section macro, the __alias macro uses > > > macro # stringification to create quotes around > > > the section name used in the __attribute__. > > > > > > Remove the stringification and add quotes or a > > > stringification to the uses instead. > > > > > > > Why? > > Using quotes in __section caused/causes differences > between clang and gcc. > > https://lkml.org/lkml/2020/9/29/2187 > > Using common styles for details like this is good. Luckily, there's no difference/issue here with alias as there exist with section: https://godbolt.org/z/eWxc7P So it's just a stylistic cleanup, not a bugfix. Acked-by: Nick Desaulniers $ grep -rn __attribute__ | grep alias didn't turn up any other cases that look like they don't use strings. -- Thanks, ~Nick Desaulniers