From: John Stultz <john.stultz@linaro.org>
To: Brian Starkey <brian.starkey@arm.com>
Cc: lkml <linux-kernel@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Sumit Semwal <sumit.semwal@linaro.org>,
"Andrew F. Davis" <afd@ti.com>,
Benjamin Gaignard <benjamin.gaignard@linaro.org>,
Liam Mark <lmark@codeaurora.org>,
Pratik Patel <pratikp@codeaurora.org>,
Laura Abbott <labbott@redhat.com>,
Chenbo Feng <fengc@google.com>,
Alistair Strachan <astrachan@google.com>,
Sandeep Patil <sspatil@google.com>,
Hridya Valsaraju <hridya@google.com>,
Christoph Hellwig <hch@lst.de>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Robin Murphy <robin.murphy@arm.com>,
Andrew Morton <akpm@linux-foundation.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
dri-devel <dri-devel@lists.freedesktop.org>,
linux-mm <linux-mm@kvack.org>, nd <nd@arm.com>
Subject: Re: [RFC][PATCH 2/4] mm: cma: Add dma_heap flag to cma structure
Date: Fri, 1 May 2020 11:42:28 -0700 [thread overview]
Message-ID: <CALAqxLVt0HJH5_2BvO7fRGZ_Vp9kKzj+j2=BZu_cbw=75dNoYQ@mail.gmail.com> (raw)
In-Reply-To: <20200501104810.v6oa2yhawr4iki67@DESKTOP-E1NTVVP.localdomain>
On Fri, May 1, 2020 at 3:48 AM Brian Starkey <brian.starkey@arm.com> wrote:
> On Fri, May 01, 2020 at 07:39:47AM +0000, John Stultz wrote:
> > +bool cma_dma_heap_enabled(struct cma *cma)
> > +{
> > + return !!cma->dma_heap;
>
> Stylistic thing, but I don't think the !! is really necessary. It's
> already a bool anyway.
Yea, I was using a bit field earlier and then moved to a bool for
simplicity and left this. I saw it as soon as I sent the patch, so
it's already fixed up.
> > @@ -157,6 +167,7 @@ static int __init cma_init_reserved_areas(void)
> > }
> > core_initcall(cma_init_reserved_areas);
> >
> > +
>
> nit: spurious newline
Yep. Same. The things you only see once the mail is sent. :)
Thanks so much for the review though!
-john
next prev parent reply other threads:[~2020-05-01 18:42 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-01 7:39 [RFC][PATCH 0/4] Support non-default CMA regions to the dmabuf heaps interface John Stultz
2020-05-01 7:39 ` [RFC][PATCH 1/4] devicetree: bindings: Add linux,cma-heap tag for reserved memory John Stultz
2020-05-01 10:42 ` Brian Starkey
2020-05-01 18:40 ` John Stultz
2020-05-04 8:50 ` Brian Starkey
2020-05-06 16:04 ` Andrew F. Davis
2020-05-06 16:30 ` John Stultz
2020-05-06 17:35 ` Andrew F. Davis
2020-05-06 18:34 ` John Stultz
2020-05-01 7:39 ` [RFC][PATCH 2/4] mm: cma: Add dma_heap flag to cma structure John Stultz
2020-05-01 10:48 ` Brian Starkey
2020-05-01 18:42 ` John Stultz [this message]
2020-05-01 7:39 ` [RFC][PATCH 3/4] dma-buf: cma_heap: Extend logic to export CMA regions tagged with "linux,cma-heap" John Stultz
2020-05-01 10:21 ` Brian Starkey
2020-05-01 11:08 ` Robin Murphy
2020-05-01 19:01 ` John Stultz
2020-05-04 9:06 ` Brian Starkey
2020-05-12 16:37 ` Rob Herring
2020-05-13 10:44 ` Brian Starkey
2020-05-14 14:52 ` Rob Herring
2020-05-15 9:32 ` Brian Starkey
2020-05-01 7:39 ` [RFC][PATCH 4/4] example: dts: hi3660-hikey960: Add dts entries to test cma heap binding John Stultz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALAqxLVt0HJH5_2BvO7fRGZ_Vp9kKzj+j2=BZu_cbw=75dNoYQ@mail.gmail.com' \
--to=john.stultz@linaro.org \
--cc=afd@ti.com \
--cc=akpm@linux-foundation.org \
--cc=astrachan@google.com \
--cc=benjamin.gaignard@linaro.org \
--cc=brian.starkey@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=fengc@google.com \
--cc=hch@lst.de \
--cc=hridya@google.com \
--cc=labbott@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lmark@codeaurora.org \
--cc=m.szyprowski@samsung.com \
--cc=nd@arm.com \
--cc=pratikp@codeaurora.org \
--cc=robh+dt@kernel.org \
--cc=robin.murphy@arm.com \
--cc=sspatil@google.com \
--cc=sumit.semwal@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).