From: John Stultz <john.stultz@linaro.org>
To: Suren Baghdasaryan <surenb@google.com>
Cc: "Sumit Semwal" <sumit.semwal@linaro.org>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Christoph Hellwig" <hch@infradead.org>,
"Liam Mark" <lmark@codeaurora.org>,
"Laura Abbott" <labbott@redhat.com>,
"Brian Starkey" <Brian.Starkey@arm.com>,
"Christian Koenig" <christian.koenig@amd.com>,
"Chris Goldsworthy" <cgoldswo@codeaurora.org>,
"Ørjan Eide" <orjan.eide@arm.com>,
"Robin Murphy" <robin.murphy@arm.com>,
"James Jones" <jajones@nvidia.com>,
"Minchan Kim" <minchan@kernel.org>,
"Hridya Valsaraju" <hridya@google.com>,
"Sandeep Patil" <sspatil@google.com>,
linux-media <linux-media@vger.kernel.org>,
dri-devel <dri-devel@lists.freedesktop.org>,
"moderated list:DMA BUFFER SHARING FRAMEWORK"
<linaro-mm-sig@lists.linaro.org>, linux-mm <linux-mm@kvack.org>,
lkml <linux-kernel@vger.kernel.org>,
"Android Kernel Team" <kernel-team@android.com>
Subject: Re: [PATCH v2 2/2] dma-buf: heaps: Map system heap pages as managed by linux vm
Date: Tue, 2 Feb 2021 18:07:38 -0800 [thread overview]
Message-ID: <CALAqxLWJNDDx_MFvYHszFXy=aV9bZGi50L3zDtuGaiYUbHKHSA@mail.gmail.com> (raw)
In-Reply-To: <20210203003134.2422308-2-surenb@google.com>
On Tue, Feb 2, 2021 at 4:31 PM Suren Baghdasaryan <surenb@google.com> wrote:
> Currently system heap maps its buffers with VM_PFNMAP flag using
> remap_pfn_range. This results in such buffers not being accounted
> for in PSS calculations because vm treats this memory as having no
> page structs. Without page structs there are no counters representing
> how many processes are mapping a page and therefore PSS calculation
> is impossible.
> Historically, ION driver used to map its buffers as VM_PFNMAP areas
> due to memory carveouts that did not have page structs [1]. That
> is not the case anymore and it seems there was desire to move away
> from remap_pfn_range [2].
> Dmabuf system heap design inherits this ION behavior and maps its
> pages using remap_pfn_range even though allocated pages are backed
> by page structs.
> Replace remap_pfn_range with vm_insert_page, following Laura's suggestion
> in [1]. This would allow correct PSS calculation for dmabufs.
>
> [1] https://driverdev-devel.linuxdriverproject.narkive.com/v0fJGpaD/using-ion-memory-for-direct-io
> [2] http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-October/127519.html
> (sorry, could not find lore links for these discussions)
>
> Suggested-by: Laura Abbott <labbott@kernel.org>
> Signed-off-by: Suren Baghdasaryan <surenb@google.com>
For consistency, do we need something similar for the cma heap as well?
thanks
-john
next prev parent reply other threads:[~2021-02-03 2:07 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-03 0:31 [PATCH 1/2] mm: replace BUG_ON in vm_insert_page with a return of an error Suren Baghdasaryan
2021-02-03 0:31 ` [PATCH v2 2/2] dma-buf: heaps: Map system heap pages as managed by linux vm Suren Baghdasaryan
2021-02-03 1:39 ` Minchan Kim
2021-02-03 2:02 ` Suren Baghdasaryan
2021-02-03 8:05 ` Christian König
2021-02-03 19:53 ` Suren Baghdasaryan
2021-02-03 2:07 ` John Stultz [this message]
2021-02-03 2:13 ` Suren Baghdasaryan
2021-02-03 1:27 ` [PATCH 1/2] mm: replace BUG_ON in vm_insert_page with a return of an error Miaohe Lin
2021-02-03 1:31 ` Minchan Kim
2021-02-03 1:55 ` Suren Baghdasaryan
2021-02-03 1:55 ` Matthew Wilcox
2021-02-03 2:26 ` Suren Baghdasaryan
2021-02-03 8:52 ` [Linaro-mm-sig] " Daniel Vetter
2021-02-03 20:20 ` Suren Baghdasaryan
2021-02-03 20:29 ` Daniel Vetter
2021-02-03 21:25 ` Daniel Vetter
2021-02-03 21:41 ` Suren Baghdasaryan
2021-02-04 8:16 ` Christian König
2021-02-04 15:22 ` Daniel Vetter
2021-02-04 15:54 ` Alex Deucher
2021-02-05 3:39 ` Suren Baghdasaryan
2021-02-04 7:53 ` Christian König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALAqxLWJNDDx_MFvYHszFXy=aV9bZGi50L3zDtuGaiYUbHKHSA@mail.gmail.com' \
--to=john.stultz@linaro.org \
--cc=Brian.Starkey@arm.com \
--cc=akpm@linux-foundation.org \
--cc=cgoldswo@codeaurora.org \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=hch@infradead.org \
--cc=hridya@google.com \
--cc=jajones@nvidia.com \
--cc=kernel-team@android.com \
--cc=labbott@redhat.com \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lmark@codeaurora.org \
--cc=minchan@kernel.org \
--cc=orjan.eide@arm.com \
--cc=robin.murphy@arm.com \
--cc=sspatil@google.com \
--cc=sumit.semwal@linaro.org \
--cc=surenb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).