From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17231C63777 for ; Wed, 18 Nov 2020 05:18:34 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6E42624655 for ; Wed, 18 Nov 2020 05:18:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="dhgZBRUw" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6E42624655 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 89ADF6B0068; Wed, 18 Nov 2020 00:18:32 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 84C186B006C; Wed, 18 Nov 2020 00:18:32 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 73BAC6B006E; Wed, 18 Nov 2020 00:18:32 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0085.hostedemail.com [216.40.44.85]) by kanga.kvack.org (Postfix) with ESMTP id 4374D6B0068 for ; Wed, 18 Nov 2020 00:18:32 -0500 (EST) Received: from smtpin07.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id B59C68249980 for ; Wed, 18 Nov 2020 05:18:31 +0000 (UTC) X-FDA: 77496383622.07.birds83_560d68327337 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin07.hostedemail.com (Postfix) with ESMTP id 9698A1803F9A5 for ; Wed, 18 Nov 2020 05:18:31 +0000 (UTC) X-HE-Tag: birds83_560d68327337 X-Filterd-Recvd-Size: 5924 Received: from mail-ot1-f68.google.com (mail-ot1-f68.google.com [209.85.210.68]) by imf03.hostedemail.com (Postfix) with ESMTP for ; Wed, 18 Nov 2020 05:18:30 +0000 (UTC) Received: by mail-ot1-f68.google.com with SMTP id h16so591454otq.9 for ; Tue, 17 Nov 2020 21:18:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=F7sKJwkzdbeLOyKiVuDYfrrRTcjeln31HNpMolHCz84=; b=dhgZBRUwhlMJGYy5B5kg0/hTc+PVW/P9fwbxUQJYELxJr3sFTgqZUB3YOpBKAzffVk DY8UNWEqVw/HybCxEg7v6elONW5OXpewFmWZL47EXnXpZ8KRUpN25OyEbQ9waYsX2RYx Z7M6iEvChYlW5DZl2OVnarihlbMHfZ+iw9QzaRzN3biQjmkcdmZfzEv9o1SvTTS68wEa j8YjGL9BGrbAOtVkCtPFjv7oRrzDU3i75AjHiOH8d7M/p3Fs5gn7lA76LSbCUU4yP3Pf y279jWnjt9FlaQSVf4leq5rK885Ko1y0Kv581qhqm/jDkmphNYUXOMTTDpKcLJGF9Wct d2EQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=F7sKJwkzdbeLOyKiVuDYfrrRTcjeln31HNpMolHCz84=; b=dtT5WvSgnK9y6eafol81prL1z8z0yVHJuhhcGD2j4eP2FGcz7yQZibak9j75C0Ri2v 9jqKJnAAxcioUJMB8iXvCJk31RFWP/gJTIuVERSsVg50kLnV5nUovtNREHaEfhmgL9TW n0oqRcIzddW8tKkfCcQbBAf8OecyJ1mppQK0QRA5jTGz5uMoqjyMMAQRwGEV+kRzwuBG ZWh6UuC5p3eMN3x2nPBnK2lRpIEUsruAprR+eB9h9txBCw7pAr+vwuVp6Oz2GAOcBA+y 1FzhhBaEc2L6Hi1ZCCgiM28JLIn9izhUj2oLTt2BWe3OVPaeOdFV9rsrKN7ay+zqcZf8 i1yg== X-Gm-Message-State: AOAM531NRzTkldwxiunaDfgZKKWkGleU10tQVlev6nP/mw5BmFWWe1BR HHv2r6XD+aIJABreSFzac87jq4Ik59PmvuzvSctHDA== X-Google-Smtp-Source: ABdhPJznMB7Dcm3wHiflI6UU5baKUw77SPDRMKIJ2o8sjGzcuUEIkHfXK7f360M22ZzOz3BxHb2BphgAFuVXhh6gpyE= X-Received: by 2002:a9d:64ce:: with SMTP id n14mr5354340otl.352.1605676710354; Tue, 17 Nov 2020 21:18:30 -0800 (PST) MIME-Version: 1.0 References: <20201117181935.3613581-1-minchan@kernel.org> <20201117181935.3613581-3-minchan@kernel.org> In-Reply-To: <20201117181935.3613581-3-minchan@kernel.org> From: John Stultz Date: Tue, 17 Nov 2020 21:18:17 -0800 Message-ID: Subject: Re: [PATCH 2/4] dma-buf: add export symbol for dma-heap To: Minchan Kim Cc: Andrew Morton , LKML , linux-mm , Hyesoo Yu , Matthew Wilcox , david@redhat.com, iamjoonsoo.kim@lge.com, vbabka@suse.cz, Suren Baghdasaryan , KyongHo Cho , John Dias , Hridya Valsaraju , Sumit Semwal , Brian Starkey , linux-media , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Rob Herring , Christian Koenig , "moderated list:DMA BUFFER SHARING FRAMEWORK" , Christoph Hellwig Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Nov 17, 2020 at 10:19 AM Minchan Kim wrote: > > From: Hyesoo Yu > > The heaps could be added as module, so some functions should > be exported to register dma-heaps. And dma-heap of module can use > cma area to allocate and free. However the function related cma > is not exported now. Let's export them for next patches. > > Signed-off-by: Hyesoo Yu > Signed-off-by: Minchan Kim > --- > drivers/dma-buf/dma-heap.c | 2 ++ > mm/cma.c | 3 +++ > 2 files changed, 5 insertions(+) > > diff --git a/drivers/dma-buf/dma-heap.c b/drivers/dma-buf/dma-heap.c > index afd22c9dbdcf..cc6339cbca09 100644 > --- a/drivers/dma-buf/dma-heap.c > +++ b/drivers/dma-buf/dma-heap.c > @@ -189,6 +189,7 @@ void *dma_heap_get_drvdata(struct dma_heap *heap) > { > return heap->priv; > } > +EXPORT_SYMBOL_GPL(dma_heap_get_drvdata); > > struct dma_heap *dma_heap_add(const struct dma_heap_export_info *exp_info) > { > @@ -272,6 +273,7 @@ struct dma_heap *dma_heap_add(const struct dma_heap_export_info *exp_info) > kfree(heap); > return err_ret; > } > +EXPORT_SYMBOL_GPL(dma_heap_add); > > static char *dma_heap_devnode(struct device *dev, umode_t *mode) > { Thanks so much for sending this series along! I'm ok with the dma-heap exports to support modules. > diff --git a/mm/cma.c b/mm/cma.c > index 7c11ec2dc04c..87834e2966fa 100644 > --- a/mm/cma.c > +++ b/mm/cma.c > @@ -54,6 +54,7 @@ const char *cma_get_name(const struct cma *cma) > { > return cma->name; > } > +EXPORT_SYMBOL_GPL(cma_get_name); > > static unsigned long cma_bitmap_aligned_mask(const struct cma *cma, > unsigned int align_order) > @@ -498,6 +499,7 @@ struct page *cma_alloc(struct cma *cma, size_t count, unsigned int align, > pr_debug("%s(): returned %p\n", __func__, page); > return page; > } > +EXPORT_SYMBOL_GPL(cma_alloc); > > /* > * cma_alloc_bulk() - allocate high order bulk pages from contiguous area with > @@ -641,6 +643,7 @@ bool cma_release(struct cma *cma, const struct page *pages, unsigned int count) > > return true; > } > +EXPORT_SYMBOL_GPL(cma_release); > > int cma_for_each_area(int (*it)(struct cma *cma, void *data), void *data) > { > -- Though Christoph's (cc'ed) input would probably be good for the cma ones, as I know he had concerns previously with similar patches. thanks -john