From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 076F9C4724C for ; Fri, 8 May 2020 02:14:49 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B7EB92070B for ; Fri, 8 May 2020 02:14:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gpiccoli-net.20150623.gappssmtp.com header.i=@gpiccoli-net.20150623.gappssmtp.com header.b="SfTf+OO/" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B7EB92070B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=gpiccoli.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 30134900003; Thu, 7 May 2020 22:14:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2B224900002; Thu, 7 May 2020 22:14:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1C614900003; Thu, 7 May 2020 22:14:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0078.hostedemail.com [216.40.44.78]) by kanga.kvack.org (Postfix) with ESMTP id 0325F900002 for ; Thu, 7 May 2020 22:14:47 -0400 (EDT) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id B8628181AEF00 for ; Fri, 8 May 2020 02:14:47 +0000 (UTC) X-FDA: 76791933414.28.news90_cbccc039ee12 X-HE-Tag: news90_cbccc039ee12 X-Filterd-Recvd-Size: 3769 Received: from mail-qv1-f68.google.com (mail-qv1-f68.google.com [209.85.219.68]) by imf36.hostedemail.com (Postfix) with ESMTP for ; Fri, 8 May 2020 02:14:47 +0000 (UTC) Received: by mail-qv1-f68.google.com with SMTP id di6so56666qvb.10 for ; Thu, 07 May 2020 19:14:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gpiccoli-net.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=BLKQPqjJWCXj54K1Gh8dCITWiEhj21MmdX1oJPKn5pU=; b=SfTf+OO/QBzzc8u9lKYw5BVrWzbZCxzuRxuRLTiDAfE5o84rTilZ+A2VjvwHcTRha2 GpGybnQxSAJuLCGUt5NBslWKL6ySEFyNiBzNsred3b7QFr6i/Hv4FqOCO1a7ELo+2SHt ECd6v5KiNMVhxQtpDRDYerix+AkveVMLPr/r6mSDQbU9gKZhvK+04z8hw+8HwUwA4j75 roiwguGnUtYlc2jlmhGYZ4GvMeukzaBDAIy1th69XIx36AlIwazWKyo2ZXJ9J+daZ3tC DXMRNKvv/n8CSStQF55om0CqjWXF+5++uNaT/IVs0WxGK4eNaa7WVbRyJVO1ac79qDru +p0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=BLKQPqjJWCXj54K1Gh8dCITWiEhj21MmdX1oJPKn5pU=; b=YaMdnlKqQNSoH9FYHy7mqpZeEFfr/ZZOF47fSDlBXNLhjnhFCnk/SpflT7DhEBl9RE tgOSgPQG23NCpm735pni8N7cxLLpKdcA3PerdFT+l0NyAMZBnGZQ0otNtMQJS/u3Npkt ebdqZXUpSaAA9eZKH7RX1OVQwKDbZtVv7CLJQyztgld3f7vhwwAIUAHIMNoPHWjFD1QC FOL20udyJR+HNx6FLpBZ2OknkRH1IF7IBQJLqIvzdiVjVVAI4zCn0PZTpKQtR3aXHtGz QSb8NBYyhvxfoqstKMG4Wkc9J6HhOLcrbw/RvrYmP6bn7kD2vKoa9MRQCB+1QRx6Grp9 387g== X-Gm-Message-State: AGi0PubA6MsPnSKBAUirl/NRitU9RGVbMDJT7gCa5kbFmMZ1P/IXxPCN 7T9o51ZuXr0xmFXgwCZOkB8Oh1trmKRKbxDqYsETag== X-Google-Smtp-Source: APiQypLxlHUaHqzSMnOzFJ6rwiV35lPZDV1gcTIwFgzueXJeEYd4GHV98su8ulBIOQEVDFvPxTEqJw60MFJ8YwP2nms= X-Received: by 2002:a0c:b44c:: with SMTP id e12mr541590qvf.30.1588904086730; Thu, 07 May 2020 19:14:46 -0700 (PDT) MIME-Version: 1.0 References: <20200507215946.22589-1-gpiccoli@canonical.com> <20200507160438.ed336a1e00c23c6863d75ae5@linux-foundation.org> In-Reply-To: <20200507160438.ed336a1e00c23c6863d75ae5@linux-foundation.org> From: "Guilherme G. Piccoli" Date: Thu, 7 May 2020 23:14:10 -0300 Message-ID: Subject: Re: [PATCH] mm, compaction: Indicate when compaction is manually triggered by sysctl To: Andrew Morton Cc: "Guilherme G. Piccoli" , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Gavin Guo , Mel Gorman Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.005721, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, May 7, 2020 at 8:04 PM Andrew Morton wrote: > > Could add it to vmstat? Hi Andrew, thanks for your suggestion! I thought the same, as a second potential solution for this..was planning to add as a comment below the "---" but forgot heheh I agree that would be great in vmstat, do you have a name suggestion for it? "compaction_triggered" maybe? > Userspace could write to /dev/kmsg when it decides to trigger > compaction? Although using the kernel log seems a fairly lame way for > userspace to record its own actions... Well...you can think that the problem we are trying to solve was more like...admin forgot if they triggered or not the compaction hehe So, counting on the user to keep track of it is what I'd like to avoid. And thinking about drop_caches (that have an indication when triggered) makes me think this indeed does make sense for compaction too. Cheers, Guilherme