From: Yafang Shao <laoar.shao@gmail.com>
To: Petr Mladek <pmladek@suse.com>,
Matthew Wilcox <willy@infradead.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
David Hildenbrand <david@redhat.com>,
Miaohe Lin <linmiaohe@huawei.com>,
Vlastimil Babka <vbabka@suse.cz>,
Christoph Lameter <cl@linux.com>,
penberg@kernel.org, David Rientjes <rientjes@google.com>,
iamjoonsoo.kim@lge.com,
Andrew Morton <akpm@linux-foundation.org>,
Steven Rostedt <rostedt@goodmis.org>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Joe Perches <joe@perches.com>
Cc: Linux MM <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
kbuild test robot <lkp@intel.com>
Subject: Re: [PATCH v6 resend 0/3] mm, vsprintf: dump full information of page flags in pGp
Date: Fri, 19 Mar 2021 18:15:19 +0800 [thread overview]
Message-ID: <CALOAHbAO+2ZHjF8RH4aGFh2Zh9y0-Uwu+rv-NrQjF49YjA-j2w@mail.gmail.com> (raw)
In-Reply-To: <20210319101246.73513-1-laoar.shao@gmail.com>
On Fri, Mar 19, 2021 at 6:13 PM Yafang Shao <laoar.shao@gmail.com> wrote:
>
> The existed pGp shows the names of page flags only, rather than the full
> information including section, node, zone, last cpuipid and kasan tag.
> While it is not easy to parse these information manually because there
> are so many flavors. We'd better interpret them in printf.
>
> To be compitable with the existed format of pGp, the new introduced ones
> also use '|' as the separator, then the user tools parsing pGp won't
> need to make change, suggested by Matthew. The new added information is
> tracked onto the end of the existed one, e.g.
> [ 8838.835456] Slab 0x000000002828b78a objects=33 used=3 fp=0x00000000d04efc88 flags=0x17ffffc0010200(slab|head|node=0|zone=2|lastcpupid=0x1fffff)
>
> The documentation and test cases are also updated. The result of the
> test cases as follows,
> [68599.816764] test_printf: loaded.
> [68599.819068] test_printf: all 388 tests passed
> [68599.830367] test_printf: unloaded.
>
> This patchset also includes some code cleanup in mm/slub.c.
>
> v6:
> - fixes the build failure and test failure reported by kernel test robot
>
> v5:
> - remove the bitmap and better name the struct, per Petr
>
> v4:
> - extend %pGp instead of introducing new format, per Matthew
>
> v3:
> - coding improvement, per Joe and Andy
> - the possible impact on debugfs and the fix of it, per Joe and Matthew
> - introduce new format instead of changing pGp, per Andy
>
> v2:
> - various coding improvement, per Joe, Miaohe, Vlastimil and Andy
> - remove the prefix completely in patch #2, per Vlastimil
> - Update the test cases, per Andy
>
> Yafang Shao (3):
> mm, slub: use pGp to print page flags
> mm, slub: don't combine pr_err with INFO
> vsprintf: dump full information of page flags in pGp
>
> Documentation/core-api/printk-formats.rst | 2 +-
> lib/test_printf.c | 90 ++++++++++++++++++++---
> lib/vsprintf.c | 66 +++++++++++++++--
> mm/slub.c | 13 ++--
> 4 files changed, 149 insertions(+), 22 deletions(-)
>
> --
> 2.18.2
>
Hi Petr,
Any comments on this version ?
Thanks
Yafang
next prev parent reply other threads:[~2021-03-19 10:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-19 10:12 [PATCH v6 resend 0/3] mm, vsprintf: dump full information of page flags in pGp Yafang Shao
2021-03-19 10:12 ` [PATCH v6 resend 1/3] mm, slub: use pGp to print page flags Yafang Shao
2021-03-19 10:12 ` [PATCH v6 resend 2/3] mm, slub: don't combine pr_err with INFO Yafang Shao
2021-03-19 10:12 ` [PATCH v6 resend 3/3] vsprintf: dump full information of page flags in pGp Yafang Shao
2021-03-19 15:27 ` Petr Mladek
2021-03-19 10:15 ` Yafang Shao [this message]
2021-03-19 12:22 ` [PATCH v6 resend 0/3] mm, " Petr Mladek
2021-03-19 15:03 ` Sergey Senozhatsky
2021-03-19 16:05 ` Petr Mladek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALOAHbAO+2ZHjF8RH4aGFh2Zh9y0-Uwu+rv-NrQjF49YjA-j2w@mail.gmail.com \
--to=laoar.shao@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=cl@linux.com \
--cc=david@redhat.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=joe@perches.com \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lkp@intel.com \
--cc=penberg@kernel.org \
--cc=pmladek@suse.com \
--cc=rientjes@google.com \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky@gmail.com \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).