From: Yafang Shao <laoar.shao@gmail.com>
To: Michal Hocko <mhocko@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Johannes Weiner <hannes@cmpxchg.org>,
Matthew Wilcox <willy@infradead.org>,
Vladimir Davydov <vdavydov.dev@gmail.com>,
Linux MM <linux-mm@kvack.org>
Subject: Re: [PATCH v3] mm, memcg: fix error return value of mem_cgroup_css_alloc()
Date: Thu, 9 Apr 2020 21:59:42 +0800 [thread overview]
Message-ID: <CALOAHbAVDVk8ieugP=yrRSJH2AKpmbjAJfy+F6bU7LXNZugyqA@mail.gmail.com> (raw)
In-Reply-To: <20200409065722.GA18386@dhcp22.suse.cz>
On Thu, Apr 9, 2020 at 2:57 PM Michal Hocko <mhocko@kernel.org> wrote:
>
> On Wed 08-04-20 18:29:56, Andrew Morton wrote:
> > On Tue, 7 Apr 2020 14:10:12 -0400 Johannes Weiner <hannes@cmpxchg.org> wrote:
> >
> > > Given how unlikely this is to affect real setups, I don't think this
> > > patch is stable material.
> >
> > OK, thanks, done.
> >
> > I didn't notice any acks - is this patch otherwise good to go upstream?
>
> I will ack it if s@EBUSY@ENOSPC@
>
BTW, there's no EBUSY in man page of write(2) neither.
But when we echo some procs into cgroup.subtree_control of a non-root
cgroup, it will return EBUSY. See also cgroup_subtree_control_write().
Pls. correct me if I missed something.
We have to admit that the man page is out of date.
Thanks
Yafang
next prev parent reply other threads:[~2020-04-09 14:00 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-06 16:56 [PATCH v3] mm, memcg: fix error return value of mem_cgroup_css_alloc() Yafang Shao
2020-04-06 23:23 ` Andrew Morton
2020-04-07 3:02 ` Yafang Shao
2020-04-07 3:09 ` Andrew Morton
2020-04-07 3:11 ` Yafang Shao
2020-04-07 6:43 ` Michal Hocko
2020-04-07 9:31 ` Yafang Shao
2020-04-07 11:10 ` Michal Hocko
2020-04-07 18:10 ` Johannes Weiner
2020-04-09 1:29 ` Andrew Morton
2020-04-09 6:57 ` Michal Hocko
2020-04-09 13:59 ` Yafang Shao [this message]
2020-04-09 14:07 ` Michal Hocko
2020-04-20 23:44 ` Andrew Morton
2020-04-21 14:44 ` Johannes Weiner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALOAHbAVDVk8ieugP=yrRSJH2AKpmbjAJfy+F6bU7LXNZugyqA@mail.gmail.com' \
--to=laoar.shao@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=vdavydov.dev@gmail.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).