From: Yafang Shao <laoar.shao@gmail.com>
To: Chris Down <chris@chrisdown.name>
Cc: Naresh Kamboju <naresh.kamboju@linaro.org>,
Andrew Morton <akpm@linux-foundation.org>,
Michal Hocko <mhocko@kernel.org>,
Johannes Weiner <hannes@cmpxchg.org>,
Roman Gushchin <guro@fb.com>, linux-mm <linux-mm@kvack.org>,
Cgroups <cgroups@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
lkft-triage@lists.linaro.org
Subject: Re: [PATCH v3 2/2] mm, memcg: Decouple e{low,min} state mutations from protection checks
Date: Sat, 23 May 2020 00:27:24 +0800 [thread overview]
Message-ID: <CALOAHbArZ3NsuR3mCnx_kbSF8ktpjhUF2kaaTa7Mb7ocJajsQg@mail.gmail.com> (raw)
In-Reply-To: <20200522160709.GC1112005@chrisdown.name>
On Sat, May 23, 2020 at 12:07 AM Chris Down <chris@chrisdown.name> wrote:
>
> Chris Down writes:
> >Yafang Shao writes:
> >>I will do it.
> >>If no one has objection to my proposal, I will send it tomorrow.
> >
> >If the fixup patch works, just send that. Otherwise, sure.
>
> Oh, I see the other reply from Naresh now saying it didn't help.
>
> Sure, feel free to do that for now then while we work out what the real problem
> is.
Regarding the root cause, my guess is it makes a similar mistake that
I tried to fix in the previous patch that the direct reclaimer read a
stale protection value. But I don't think it is worth to add another
fix. The best way is to revert this commit.
--
Thanks
Yafang
prev parent reply other threads:[~2020-05-22 16:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-05 8:41 [PATCH v3 0/2] mm: memcontrol: memory.{low,min} reclaim fix & cleanup Yafang Shao
2020-05-05 8:41 ` [PATCH v3 1/2] mm, memcg: Avoid stale protection values when cgroup is above protection Yafang Shao
2020-05-05 8:41 ` [PATCH v3 2/2] mm, memcg: Decouple e{low,min} state mutations from protection checks Yafang Shao
2020-05-22 11:01 ` Naresh Kamboju
2020-05-22 11:45 ` Chris Down
2020-05-22 15:41 ` Naresh Kamboju
2020-05-22 12:18 ` Yafang Shao
2020-05-22 15:52 ` Naresh Kamboju
2020-05-22 15:59 ` Yafang Shao
2020-05-22 16:06 ` Chris Down
2020-05-22 16:07 ` Chris Down
2020-05-22 16:27 ` Yafang Shao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALOAHbArZ3NsuR3mCnx_kbSF8ktpjhUF2kaaTa7Mb7ocJajsQg@mail.gmail.com \
--to=laoar.shao@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=chris@chrisdown.name \
--cc=guro@fb.com \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lkft-triage@lists.linaro.org \
--cc=mhocko@kernel.org \
--cc=naresh.kamboju@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).