From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD577C43219 for ; Wed, 13 Oct 2021 05:21:53 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6172060F23 for ; Wed, 13 Oct 2021 05:21:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 6172060F23 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 0C19C6B006C; Wed, 13 Oct 2021 01:21:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 072666B0072; Wed, 13 Oct 2021 01:21:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EA29F6B0073; Wed, 13 Oct 2021 01:21:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0228.hostedemail.com [216.40.44.228]) by kanga.kvack.org (Postfix) with ESMTP id DFA7E6B006C for ; Wed, 13 Oct 2021 01:21:52 -0400 (EDT) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 98FA42D4CE for ; Wed, 13 Oct 2021 05:21:52 +0000 (UTC) X-FDA: 78690267264.28.8FBF4E2 Received: from mail-io1-f48.google.com (mail-io1-f48.google.com [209.85.166.48]) by imf23.hostedemail.com (Postfix) with ESMTP id 7849690000A6 for ; Wed, 13 Oct 2021 05:21:51 +0000 (UTC) Received: by mail-io1-f48.google.com with SMTP id s17so1391038ioa.13 for ; Tue, 12 Oct 2021 22:21:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=gyJ8kN8oJWfGr08zGj+0SkC3bV9t+4iWtaeslGNeU9k=; b=YymdToNiznbQkrTlUyCmW0JQA2oEFixJ1Rx54AA+w3/ghD/YSjHkZs6ZXc8htr5lzN NEv4n8qJNnEEyTQEm6Khba7DaXShzLmCSUA12LU2RKgC2jV7HKQUYFLsUgnzWl1pXUfi qWVGmNHb5gFlOjW4PCZAvRAorNfPLF7/7wDGACHr9Jra51N3n987vJe3U1DmXxyOooxG ZjX66uq90x3Wi3Z/zdi+tijmyKHd2jS+uqxYInDCEU+9V84cHlCDSufxo5sTIbm/0LRw +sqDtIoMCARBBf0Vk0ccshaKVW2UmVAIOscgnOIO8vq5w4KvicDFqUhggUAu1bgOFght 1P4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=gyJ8kN8oJWfGr08zGj+0SkC3bV9t+4iWtaeslGNeU9k=; b=zp/pzdf13xF4TcbFbsMTJJ9EGEkWXKdNyRR2XwhNCoXGSq035O5NcWAB2U7uUt7/91 be28YnGa0a+ppB1YCKTXzR8nHpvCmU6ttby7oonNFDBuEk9QUBCr4k/wpyPmie+MqG+t Ocxs8k221uUPNrLxlapO9kLSLV6kr2ZpEb7V86GH+nIcPxHwxegTSqkR5I7daDv/p6iq KWH0Bhaj3GELiO6xbXBfSrILVird1vZzCxNh87+Tl4VipXh/kXeQxxXm7dKS9v31+ea+ 5R6Ao7/DRZtsO/5loesrsfY2eAmNYU55HN3/cMk07kEzZgPC6qa0loM5N8DyGCVrziPj kSNA== X-Gm-Message-State: AOAM531xL0L68q/8MOZ1Ql9stC2H6oWql3bmXK63tAeC7mJHbCqCuLWr eKmYB2Gr8jhbheP2DXORI6DEkcYhx8IZeZ7x9bU= X-Google-Smtp-Source: ABdhPJzl58PBK1bIEn9v47J4ReoitP0DKecP8QhWdEHKuNafz93ifN5nPrrLUV8lloR/ATJN7XnGK3Psnq55LUGXth8= X-Received: by 2002:a02:a60a:: with SMTP id c10mr8551446jam.139.1634102511733; Tue, 12 Oct 2021 22:21:51 -0700 (PDT) MIME-Version: 1.0 References: <20211012182647.1605095-1-willy@infradead.org> <20211012182647.1605095-4-willy@infradead.org> In-Reply-To: <20211012182647.1605095-4-willy@infradead.org> From: Yafang Shao Date: Wed, 13 Oct 2021 13:21:15 +0800 Message-ID: Subject: Re: [PATCH 3/5] test_printf: Remove custom appending of '|' To: "Matthew Wilcox (Oracle)" Cc: Sergey Senozhatsky , Petr Mladek , Linux MM , Vlastimil Babka , Rasmus Villemoes Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 7849690000A6 X-Stat-Signature: iyrsn7dbyo9waddncyc8xdu877c3x77w Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=YymdToNi; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf23.hostedemail.com: domain of laoar.shao@gmail.com designates 209.85.166.48 as permitted sender) smtp.mailfrom=laoar.shao@gmail.com X-HE-Tag: 1634102511-141891 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000024, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Oct 13, 2021 at 2:32 AM Matthew Wilcox (Oracle) wrote: > > Instead of having an ifdef to decide whether to print a |, use the > 'append' functionality of the main loop to print it. > > Signed-off-by: Matthew Wilcox (Oracle) Reviewed-by: Yafang Shao > --- > lib/test_printf.c | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/lib/test_printf.c b/lib/test_printf.c > index f744b0498672..60cdf4ba991e 100644 > --- a/lib/test_printf.c > +++ b/lib/test_printf.c > @@ -616,12 +616,7 @@ page_flags_test(int section, int node, int zone, int last_cpupid, > if (flags & PAGEFLAGS_MASK) { > snprintf(cmp_buf + size, BUF_SIZE - size, "%s", name); > size = strlen(cmp_buf); > -#if SECTIONS_WIDTH || NODES_WIDTH || ZONES_WIDTH || \ > - LAST_CPUPID_WIDTH || KASAN_TAG_WIDTH > - /* Other information also included in page flags */ > - snprintf(cmp_buf + size, BUF_SIZE - size, "|"); > - size = strlen(cmp_buf); > -#endif > + append = true; > } > > for (i = 0; i < ARRAY_SIZE(pft); i++) { > -- > 2.32.0 > -- Thanks Yafang