From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF1E4C4361B for ; Tue, 8 Dec 2020 03:04:09 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 38537238E5 for ; Tue, 8 Dec 2020 03:04:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 38537238E5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id ACD638D0003; Mon, 7 Dec 2020 22:04:08 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A54988D0001; Mon, 7 Dec 2020 22:04:08 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 91C518D0003; Mon, 7 Dec 2020 22:04:08 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0049.hostedemail.com [216.40.44.49]) by kanga.kvack.org (Postfix) with ESMTP id 788778D0001 for ; Mon, 7 Dec 2020 22:04:08 -0500 (EST) Received: from smtpin21.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 3F525181AEF1D for ; Tue, 8 Dec 2020 03:04:08 +0000 (UTC) X-FDA: 77568620976.21.cable23_580934b273e3 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin21.hostedemail.com (Postfix) with ESMTP id 1D4A8180442C3 for ; Tue, 8 Dec 2020 03:04:08 +0000 (UTC) X-HE-Tag: cable23_580934b273e3 X-Filterd-Recvd-Size: 4342 Received: from mail-il1-f194.google.com (mail-il1-f194.google.com [209.85.166.194]) by imf41.hostedemail.com (Postfix) with ESMTP for ; Tue, 8 Dec 2020 03:04:07 +0000 (UTC) Received: by mail-il1-f194.google.com with SMTP id p5so10534567ilm.12 for ; Mon, 07 Dec 2020 19:04:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=fqV+RZduulUj6NbGqyUOp9hoM7sI3vwmhR3qosb54tw=; b=dj3psY39njc3nsUNvx5F87Ydsh/VPUG3DePATtF8R5QDSa/ZQYcFtM08dZKZz0cpga vqA6FqcIrRvQ8N214nzx/+md9sVh6EN377hOmUWjPkeRqHDhN4W6kvkShQWhCaj1SLVd NyYsWXEmU2+dBOWWVreKQ851/BIXKM0AAJNJIbzDSgdGQ99gZ2pBlTbsVN5/5295k8tS SAzxpmg1PLKBJr3dqEcK51UQfP3t75kA2h3RJ6NATAH5ELnTOenXkv5JXJr55TdS6w2r t0eh5Vnv7EuyMe2AgdLPY2xc/+O41MpCY8bT8hPwD1LNqRzZXI8XVti3GaqbNbQOgFXk 8IgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=fqV+RZduulUj6NbGqyUOp9hoM7sI3vwmhR3qosb54tw=; b=MR4WrlqxlvMz5nkOSSkrNP6yZtNZOjz+5h+4ktgtwB2LvbWuJ0F8tXbn5h3pcz0NyI 7a4BSedgcg3N+B7aUGYnuXEubOB+DjeOmAOVO+QgXNufQjWXrnXUeow9mJBlngn12v+c c2B+B93ceD8i9xjHFEUL4MdkPYCffCFXwBvMLqKlWZuK29X54jcHQnh3cvoAW27ovQIL rZPgMszhkIYUAUqXv93SJeIu9L/3vCsv0/KZo6jFVFTYwtXpPKrfEtksGvwwZZzmN5DB Gp+aDRVr81GIdc0Nl7Mf3uVeB8qVJwZTmVTSC+KwG3NEweCSO1YtnEQA8Uvf4f+MNd5M FEQQ== X-Gm-Message-State: AOAM531/b0I+cAWkVRy+rkty4NckDdlbnhKQ1vebAEI4jvOP8PXk5Z2d UpHAwcFuqbqVLWUtXitvrVJyr8l5Aiv5eQlhC/E= X-Google-Smtp-Source: ABdhPJzYL1yRHIfcv/yWDBMbtYSBYQ5IsNwznZbZh4rfJfdR29NH+nqOy74D8K+MjJGY5+ETdEjkP/+n+puhVHGd8Do= X-Received: by 2002:a92:ae10:: with SMTP id s16mr25678688ilh.142.1607396647025; Mon, 07 Dec 2020 19:04:07 -0800 (PST) MIME-Version: 1.0 References: <20201208021543.76501-1-laoar.shao@gmail.com> <20201208021543.76501-5-laoar.shao@gmail.com> <20201208024158.GF7338@casper.infradead.org> In-Reply-To: <20201208024158.GF7338@casper.infradead.org> From: Yafang Shao Date: Tue, 8 Dec 2020 11:03:31 +0800 Message-ID: Subject: Re: [PATCH v10 4/4] xfs: use current->journal_info to avoid transaction reservation recursion To: Matthew Wilcox Cc: "Darrick J. Wong" , Dave Chinner , Christoph Hellwig , Michal Hocko , Andrew Morton , David Howells , jlayton@redhat.com, linux-fsdevel@vger.kernel.org, linux-cachefs@redhat.com, linux-xfs@vger.kernel.org, Linux MM , Christoph Hellwig Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Dec 8, 2020 at 10:42 AM Matthew Wilcox wrote: > > On Tue, Dec 08, 2020 at 10:15:43AM +0800, Yafang Shao wrote: > > - /* > > - * Given that we do not allow direct reclaim to call us, we should > > - * never be called in a recursive filesystem reclaim context. > > - */ > > - if (WARN_ON_ONCE(current->flags & PF_MEMALLOC_NOFS)) > > - goto redirty; > > - > > /* > > * Is this page beyond the end of the file? > > * > > diff --git a/fs/xfs/xfs_aops.c b/fs/xfs/xfs_aops.c > > index 2371187b7615..28db93d0da97 100644 > > --- a/fs/xfs/xfs_aops.c > > +++ b/fs/xfs/xfs_aops.c > > @@ -568,6 +568,16 @@ xfs_vm_writepage( > > { > > struct xfs_writepage_ctx wpc = { }; > > > > + /* > > + * Given that we do not allow direct reclaim to call us, we should > > + * never be called while in a filesystem transaction. > > + */ > > + if (xfs_trans_context_active()) { > > + redirty_page_for_writepage(wbc, page); > > + unlock_page(page); > > + return 0; > > + } > > Dave specifically asked for this one to WARN too. I put the warn in xfs_trans_context_active(), pls. see the definition of it. Is that okay ? -- Thanks Yafang