From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3C8DC433E0 for ; Fri, 7 Aug 2020 04:06:04 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8A24622CAF for ; Fri, 7 Aug 2020 04:06:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YZgjSCHs" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8A24622CAF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 0816C6B0002; Fri, 7 Aug 2020 00:06:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 032B36B0003; Fri, 7 Aug 2020 00:06:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E62E56B0005; Fri, 7 Aug 2020 00:06:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0061.hostedemail.com [216.40.44.61]) by kanga.kvack.org (Postfix) with ESMTP id CD11C6B0002 for ; Fri, 7 Aug 2020 00:06:03 -0400 (EDT) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 5CA1D8249980 for ; Fri, 7 Aug 2020 04:06:03 +0000 (UTC) X-FDA: 77122434606.28.judge34_4d171a026fbd Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin28.hostedemail.com (Postfix) with ESMTP id 311266D76 for ; Fri, 7 Aug 2020 04:06:03 +0000 (UTC) X-HE-Tag: judge34_4d171a026fbd X-Filterd-Recvd-Size: 5115 Received: from mail-il1-f194.google.com (mail-il1-f194.google.com [209.85.166.194]) by imf03.hostedemail.com (Postfix) with ESMTP for ; Fri, 7 Aug 2020 04:06:02 +0000 (UTC) Received: by mail-il1-f194.google.com with SMTP id c16so693223ils.8 for ; Thu, 06 Aug 2020 21:06:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=22pRHAFZJwrfnEhk4YQP203Cfv3TA8Rs89eV33L4ZBs=; b=YZgjSCHs6FSoDdnfZTJpYf8+Ul+BG9YRyrszbLuy5jGv0njvBGAFPQIl4LGPEB9CTv 2ELzO2IKrmVSIfRwmOybhOGUnRJUWTflUkTVJ7vaXNU8S6qk6p8y7qN8y6PlmAQAavrm q7uUERJnYeRmaaFGXcjB9I9lhashK2rxsw0SZuBYVDwIvCqc2iwRZuNGStHSviBW4T+G zbajQPdAYsOsyFJ8a+bdDo0aEDaY+gqBTZok9uLM739OXX89M2L8Pp+ll8Em0C1qOQsj U6hTPxk6C4roxt8bztsgjELgxouakxenkNPGCkta7++R8Rw5ygGytcSuZivmCah06wpn V4kw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=22pRHAFZJwrfnEhk4YQP203Cfv3TA8Rs89eV33L4ZBs=; b=hCNkoFkqKy+nMM8Xw8l/6lbolJSL/TTByst6veVBtfGqoKXt/CsC5FvX93C6r4omSX Ra164wuOfZUGolpKj914DY66oPFo8gvCVSEHEOgLVpqHSHkzrMdBVwh8ZuqQf7PxWCqR W05EARLPWWR8foZRzUcNn9b/YM9fSGbqrj4X5bD9N2YHR9wWG3NolfQIxjUqH61oazX3 lKlkKbuF9SMGoE94OVulrT8jLrfUnUtNMhfrfagm7YlPF4iidbLoTCH7O+alJnCUwq0R 7LVLzyQM1wYnTcoyCZLygNX8QBTiPAtmkOpv9lCiJES7huWuhvvRCDaukD0G2gqaoIQ6 /exw== X-Gm-Message-State: AOAM532q12a/kQiWrgmdwvLiaDdCrnw8wQMzvXYzrlctWRKAvZwA49xK 6+2cM9lfj+GqzBxVyYg2C/w51ACSIQNOORuek6g= X-Google-Smtp-Source: ABdhPJzqnhnjlpDxMTDIaECEw3N7oTXu2H1Q6Mb/jsKJyoZd0/52AQHq7PgXUz1hCBSvhA+QtCVMkmynvQacvfEWxPA= X-Received: by 2002:a92:9a4d:: with SMTP id t74mr2462379ili.203.1596773162081; Thu, 06 Aug 2020 21:06:02 -0700 (PDT) MIME-Version: 1.0 References: <20200801154632.866356-1-laoar.shao@gmail.com> <20200801154632.866356-2-laoar.shao@gmail.com> <20200804232005.GD2114@dread.disaster.area> <20200804235038.GL23808@casper.infradead.org> <20200805012809.GF2114@dread.disaster.area> In-Reply-To: <20200805012809.GF2114@dread.disaster.area> From: Yafang Shao Date: Fri, 7 Aug 2020 12:05:26 +0800 Message-ID: Subject: Re: [PATCH v4 1/2] xfs: avoid double restore PF_MEMALLOC_NOFS if transaction reservation fails To: Dave Chinner Cc: Matthew Wilcox , Christoph Hellwig , "Darrick J. Wong" , Michal Hocko , linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, Linux MM , Yafang Shao Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 311266D76 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam02 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Aug 5, 2020 at 9:28 AM Dave Chinner wrote: > > On Wed, Aug 05, 2020 at 12:50:38AM +0100, Matthew Wilcox wrote: > > On Wed, Aug 05, 2020 at 09:20:05AM +1000, Dave Chinner wrote: > > > Also, please convert these to memalloc_nofs_save()/restore() calls > > > as that is the way we are supposed to mark these regions now. > > > > I have a patch for that! > > Did you compile test it? :) > > > --- > > fs/xfs/kmem.c | 2 +- > > fs/xfs/xfs_aops.c | 4 ++-- > > fs/xfs/xfs_buf.c | 2 +- > > fs/xfs/xfs_linux.h | 6 ------ > > fs/xfs/xfs_trans.c | 14 +++++++------- > > fs/xfs/xfs_trans.h | 2 +- > > 6 files changed, 12 insertions(+), 18 deletions(-) > > ..... > > > diff --git a/fs/xfs/xfs_linux.h b/fs/xfs/xfs_linux.h > > index 9f70d2f68e05..e1daf242a53b 100644 > > --- a/fs/xfs/xfs_linux.h > > +++ b/fs/xfs/xfs_linux.h > > @@ -104,12 +104,6 @@ typedef __u32 xfs_nlink_t; > > #define current_cpu() (raw_smp_processor_id()) > > #define current_pid() (current->pid) > > #define current_test_flags(f) (current->flags & (f)) > > -#define current_set_flags_nested(sp, f) \ > > - (*(sp) = current->flags, current->flags |= (f)) > > -#define current_clear_flags_nested(sp, f) \ > > - (*(sp) = current->flags, current->flags &= ~(f)) > > -#define current_restore_flags_nested(sp, f) \ > > - (current->flags = ((current->flags & ~(f)) | (*(sp) & (f)))) > > current_set_flags_nested() and current_restore_flags_nested() > are used in xfs_btree_split_worker() in fs/xfs/libxfs/xfs_btree.c > and that's not a file you modified in this patch... > It is in Willy's another patch "mm: Add become_kswapd and restore_kswapd"[1], which can be committed independently from "Overhaul memalloc_no*" series. I will carry it in the next version. [1] https://lore.kernel.org/linux-mm/20200625113122.7540-3-willy@infradead.org/#t [2] https://lore.kernel.org/linux-mm/20200625113122.7540-1-willy@infradead.org/ -- Thanks Yafang