From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E732C433EF for ; Fri, 22 Oct 2021 15:13:22 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0148C6108D for ; Fri, 22 Oct 2021 15:13:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 0148C6108D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 7DAF1900004; Fri, 22 Oct 2021 11:13:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 76397900003; Fri, 22 Oct 2021 11:13:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6041E900004; Fri, 22 Oct 2021 11:13:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0082.hostedemail.com [216.40.44.82]) by kanga.kvack.org (Postfix) with ESMTP id 4EF22900003 for ; Fri, 22 Oct 2021 11:13:21 -0400 (EDT) Received: from smtpin02.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 1329F3209F for ; Fri, 22 Oct 2021 15:13:21 +0000 (UTC) X-FDA: 78724417002.02.CE482E7 Received: from mail-io1-f54.google.com (mail-io1-f54.google.com [209.85.166.54]) by imf12.hostedemail.com (Postfix) with ESMTP id B4AD310000B5 for ; Fri, 22 Oct 2021 15:13:20 +0000 (UTC) Received: by mail-io1-f54.google.com with SMTP id p142so5874367iod.0 for ; Fri, 22 Oct 2021 08:13:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=8gvYbxzRzeM+H2zN3ef+Tc04hCGiovJf9FOAIWkptOM=; b=MoYu/hTHKaOLHwzyd3xxdqf28c16f7nEEum9zp1ApA0/xGH5zf6dXiOB6EPQeB+/rt hnHbwEFko7pb54zhiHyEdPiKpPuWwQgwLvoRiZuLzhApWNM9LaKH9Ot9FfQah7dS3/mp 3YSdDLV8qeEBJU60DKVwU/sSnD/02P9Ml81YqCxnvcevjcvt9FWwbkEgAxwYo3RlTvc8 CRfj8YUoI7nZ7Zo0VAH72G1MWMf03UPgc568KvURsHrZwcXpsvpExVr6Hv89W16csmuy ETsVTgSaitjHhL6jjPPhsMbxzzcE0UcTSg7YcHbjSQTh0HP3IdIkUfKvpVws8pFDjs3q vIOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=8gvYbxzRzeM+H2zN3ef+Tc04hCGiovJf9FOAIWkptOM=; b=oS8GcBqi5cJMWwr3lkwqrm0PyWhKirQSOz2HTz8LNhiaABqkh/a0lIQafRg0Md5RLo 6MfG3VJd4kradKueRvzhNcEDLehQmFjELwgJJIVxCRrzaYkDDGau5u4YcYIofwzhdPCc LvHP3uHZSsOvkrDncq8+rYD/5NM/bti2MccTNBBlkbdCLfUutCYS441CA8hoczu3Kw7p 6KVcA8ptyy8BmU63deqt1gUSJfEPmSpHNuri4a0biSGlC7xnJQ/w4+Mxg3GDONVzn4eN sIY4N9NSf3F/B8EJsGS4BilcyU6cJ95GlfyqmysmjhLLGM20Wqn+wlRrj1xmmM8YhDT5 PweQ== X-Gm-Message-State: AOAM5313gGSmz2co2DpngBaf/ErHbONtBd1yQoy3mYlO/sj4tgmMW2R4 O4ITZwWokIbJR3HkB3cVMyjAPUGICX9nlt1lpMM= X-Google-Smtp-Source: ABdhPJwwn8ow9dYINMThHJMrc+ZTGkiMdX7Yxv/mVXbby9g/6dQZDhc0mN/uhd7FtjlLTJ/zaVRgswgMSSHhCIhYDxo= X-Received: by 2002:a05:6638:2724:: with SMTP id m36mr280123jav.49.1634915600005; Fri, 22 Oct 2021 08:13:20 -0700 (PDT) MIME-Version: 1.0 References: <20211019142621.2810043-1-willy@infradead.org> <20211019142621.2810043-3-willy@infradead.org> In-Reply-To: <20211019142621.2810043-3-willy@infradead.org> From: Yafang Shao Date: Fri, 22 Oct 2021 23:12:43 +0800 Message-ID: Subject: Re: [PATCH v2 2/5] test_printf: Remove separate page_flags variable To: "Matthew Wilcox (Oracle)" Cc: Sergey Senozhatsky , Petr Mladek , Linux MM , Vlastimil Babka , Rasmus Villemoes Content-Type: text/plain; charset="UTF-8" X-Stat-Signature: y9yhj9z794b3wcwjh9cbwi71rkiknxwf Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b="MoYu/hTH"; spf=pass (imf12.hostedemail.com: domain of laoar.shao@gmail.com designates 209.85.166.54 as permitted sender) smtp.mailfrom=laoar.shao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: B4AD310000B5 X-HE-Tag: 1634915600-976157 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Oct 19, 2021 at 10:30 PM Matthew Wilcox (Oracle) wrote: > > Keep flags intact so that we also test what happens when unknown flags > are passed to %pGp. > > Signed-off-by: Matthew Wilcox (Oracle) Reviewed-by: Yafang Shao > --- > lib/test_printf.c | 12 +++++------- > 1 file changed, 5 insertions(+), 7 deletions(-) > > diff --git a/lib/test_printf.c b/lib/test_printf.c > index a52c1c3a55ba..4531063afd45 100644 > --- a/lib/test_printf.c > +++ b/lib/test_printf.c > @@ -605,17 +605,15 @@ static const struct page_flags_test pft[] = { > > static void __init > page_flags_test(int section, int node, int zone, int last_cpupid, > - int kasan_tag, int flags, const char *name, char *cmp_buf) > + int kasan_tag, unsigned long flags, const char *name, > + char *cmp_buf) > { > unsigned long values[] = {section, node, zone, last_cpupid, kasan_tag}; > - unsigned long page_flags = 0; > unsigned long size = 0; > bool append = false; > int i; > > - flags &= PAGEFLAGS_MASK; > - if (flags) { > - page_flags |= flags; > + if (flags & PAGEFLAGS_MASK) { > snprintf(cmp_buf + size, BUF_SIZE - size, "%s", name); > size = strlen(cmp_buf); > #if SECTIONS_WIDTH || NODES_WIDTH || ZONES_WIDTH || \ > @@ -635,7 +633,7 @@ page_flags_test(int section, int node, int zone, int last_cpupid, > size = strlen(cmp_buf); > } > > - page_flags |= (values[i] & pft[i].mask) << pft[i].shift; > + flags |= (values[i] & pft[i].mask) << pft[i].shift; > snprintf(cmp_buf + size, BUF_SIZE - size, "%s=", pft[i].name); > size = strlen(cmp_buf); > snprintf(cmp_buf + size, BUF_SIZE - size, pft[i].fmt, > @@ -644,7 +642,7 @@ page_flags_test(int section, int node, int zone, int last_cpupid, > append = true; > } > > - test(cmp_buf, "%pGp", &page_flags); > + test(cmp_buf, "%pGp", &flags); > } > > static void __init > -- > 2.32.0 > -- Thanks Yafang