From: Dan Streetman <ddstreet@ieee.org>
To: Srividya Desireddy <srividya.dr@samsung.com>
Cc: "sjenning@redhat.com" <sjenning@redhat.com>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Dinakar Reddy Pathireddy <dinakar.p@samsung.com>,
RAJIB BASU <rajib.basu@samsung.com>,
Srikanth Mandalapu <srikanth.m@samsung.com>,
SHARAN ALLUR <sharan.allur@samsung.com>,
JUHUN KIM <juhunkim@samsung.com>,
"srividya.desireddy@gmail.com" <srividya.desireddy@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH v2] zswap: Update with same-value filled page feature
Date: Wed, 6 Dec 2017 10:20:25 -0500 [thread overview]
Message-ID: <CALZtONAAE7KNJyBRWD0mzKTF7qAXUwRX47dzNtD_Oz2WpJ-Qeg@mail.gmail.com> (raw)
In-Reply-To: <20171206114852epcms5p6973b02a9f455d5d3c765eafda0fe2631@epcms5p6>
On Wed, Dec 6, 2017 at 6:48 AM, Srividya Desireddy
<srividya.dr@samsung.com> wrote:
> From: Srividya Desireddy <srividya.dr@samsung.com>
> Date: Wed, 6 Dec 2017 16:29:50 +0530
> Subject: [PATCH v2] zswap: Update with same-value filled page feature
>
> Changes since v1:
> Updated to clarify about zswap.same_filled_pages_enabled parameter.
>
> Updated zswap document with details on same-value filled
> pages identification feature.
> The usage of zswap.same_filled_pages_enabled module parameter
> is explained.
>
> Signed-off-by: Srividya Desireddy <srividya.dr@samsung.com>
Acked-by: Dan Streetman <ddstreet@ieee.org>
> ---
> Documentation/vm/zswap.txt | 22 +++++++++++++++++++++-
> 1 file changed, 21 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/vm/zswap.txt b/Documentation/vm/zswap.txt
> index 89fff7d..0b3a114 100644
> --- a/Documentation/vm/zswap.txt
> +++ b/Documentation/vm/zswap.txt
> @@ -98,5 +98,25 @@ request is made for a page in an old zpool, it is uncompressed using its
> original compressor. Once all pages are removed from an old zpool, the zpool
> and its compressor are freed.
>
> +Some of the pages in zswap are same-value filled pages (i.e. contents of the
> +page have same value or repetitive pattern). These pages include zero-filled
> +pages and they are handled differently. During store operation, a page is
> +checked if it is a same-value filled page before compressing it. If true, the
> +compressed length of the page is set to zero and the pattern or same-filled
> +value is stored.
> +
> +Same-value filled pages identification feature is enabled by default and can be
> +disabled at boot time by setting the "same_filled_pages_enabled" attribute to 0,
> +e.g. zswap.same_filled_pages_enabled=0. It can also be enabled and disabled at
> +runtime using the sysfs "same_filled_pages_enabled" attribute, e.g.
> +
> +echo 1 > /sys/module/zswap/parameters/same_filled_pages_enabled
> +
> +When zswap same-filled page identification is disabled at runtime, it will stop
> +checking for the same-value filled pages during store operation. However, the
> +existing pages which are marked as same-value filled pages remain stored
> +unchanged in zswap until they are either loaded or invalidated.
> +
> A debugfs interface is provided for various statistic about pool size, number
> -of pages stored, and various counters for the reasons pages are rejected.
> +of pages stored, same-value filled pages and various counters for the reasons
> +pages are rejected.
> --
> 2.7.4
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-12-06 15:21 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20171018104832epcms5p1b2232e2236258de3d03d1344dde9fce0@epcms5p1>
2017-10-18 10:48 ` [PATCH] zswap: Same-filled pages handling Srividya Desireddy
2017-10-18 12:34 ` Matthew Wilcox
2017-10-18 13:33 ` Timofey Titovets
2017-10-18 14:11 ` Matthew Wilcox
2017-10-18 20:43 ` Andi Kleen
2017-10-19 1:10 ` Matthew Wilcox
2017-10-19 4:30 ` Andi Kleen
2017-10-19 13:24 ` Matthew Wilcox
2017-10-18 21:31 ` Timofey Titovets
2017-10-19 1:08 ` Matthew Wilcox
[not found] ` <CGME20171018104832epcms5p1b2232e2236258de3d03d1344dde9fce0@epcms5p3>
2017-11-02 15:08 ` Srividya Desireddy
2017-11-17 22:10 ` Dan Streetman
2017-11-17 22:07 ` Dan Streetman
2017-11-17 21:27 ` Dan Streetman
2017-11-20 23:46 ` Andrew Morton
2017-11-28 11:35 ` Dan Streetman
[not found] ` <CGME20171018104832epcms5p1b2232e2236258de3d03d1344dde9fce0@epcms5p6>
2017-11-29 15:34 ` [PATCH] zswap: Update with same-value filled page feature Srividya Desireddy
2017-11-29 21:29 ` Dan Streetman
2017-12-06 11:48 ` [PATCH v2] " Srividya Desireddy
2017-12-06 15:20 ` Dan Streetman [this message]
[not found] ` <CGME20171018104832epcms5p1b2232e2236258de3d03d1344dde9fce0@epcms5p4>
2017-11-21 14:18 ` [PATCH v2] zswap: Same-filled pages handling Srividya Desireddy
2017-10-18 14:43 ` [PATCH] " Srividya Desireddy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALZtONAAE7KNJyBRWD0mzKTF7qAXUwRX47dzNtD_Oz2WpJ-Qeg@mail.gmail.com \
--to=ddstreet@ieee.org \
--cc=akpm@linux-foundation.org \
--cc=dinakar.p@samsung.com \
--cc=juhunkim@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rajib.basu@samsung.com \
--cc=sharan.allur@samsung.com \
--cc=sjenning@redhat.com \
--cc=srikanth.m@samsung.com \
--cc=srividya.desireddy@gmail.com \
--cc=srividya.dr@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).