Linux-mm Archive on lore.kernel.org
 help / color / Atom feed
From: Dan Streetman <ddstreet@ieee.org>
To: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Cc: Minchan Kim <minchan@kernel.org>, Nitin Gupta <ngupta@vflare.org>,
	Ganesh Mahendran <opensource.ganesh@gmail.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Seth Jennings <sjenning@redhat.com>, Yu Zhao <yuzhao@google.com>,
	Linux-MM <linux-mm@kvack.org>,
	Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Dan Streetman <dan.streetman@canonical.com>
Subject: Re: [PATCHv2] mm/zsmalloc: don't fail if can't create debugfs info
Date: Fri, 20 May 2016 06:32:46 -0400
Message-ID: <CALZtONCq-V-r7xYLmkJNsqYf3CbR=mPjRP7Fjp=n-9TaKvHqZw@mail.gmail.com> (raw)
In-Reply-To: <20160520040836.GA573@swordfish>

On Fri, May 20, 2016 at 12:08 AM, Sergey Senozhatsky
<sergey.senozhatsky.work@gmail.com> wrote:
> On (05/19/16 11:18), Dan Streetman wrote:
> [..]
>>       zs_stat_root = debugfs_create_dir("zsmalloc", NULL);
>>       if (!zs_stat_root)
>> -             return -ENOMEM;
>> -
>> -     return 0;
>> +             pr_warn("debugfs 'zsmalloc' stat dir creation failed\n");
>>  }
>>
>>  static void __exit zs_stat_exit(void)
>> @@ -573,17 +575,19 @@ static const struct file_operations zs_stat_size_ops = {
>>       .release        = single_release,
>>  };
>>
>> -static int zs_pool_stat_create(struct zs_pool *pool, const char *name)
>> +static void zs_pool_stat_create(struct zs_pool *pool, const char *name)
>>  {
>>       struct dentry *entry;
>>
>> -     if (!zs_stat_root)
>> -             return -ENODEV;
>> +     if (!zs_stat_root) {
>> +             pr_warn("no root stat dir, not creating <%s> stat dir\n", name);
>> +             return;
>> +     }
>
> just a small nit, there are basically two warn messages now for
> `!zs_stat_root':
>
>         debugfs 'zsmalloc' stat dir creation failed
>         no root stat dir, not creating <%s> stat dir

They're logged at different times though, the first at module load
time, the second at every pool creation time.  So while they may be
logged together if the module is loaded because a pool is being
created, any later pools created will only log the second message.

>
> may be we need only one of them; but no strong opinions.

If we drop either, I'd drop the first, but I think it could be useful
also in case zsmalloc is built-in or manually loaded without creating
a pool.

>
>         -ss

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply index

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-28 15:36 [PATCH] " Dan Streetman
2016-04-28 22:07 ` Andrew Morton
2016-04-29  0:38   ` Sergey Senozhatsky
2016-04-29  5:37     ` Minchan Kim
2016-04-29 14:50       ` Dan Streetman
2016-04-29 15:33         ` Minchan Kim
2016-05-03  2:18 ` Ganesh Mahendran
2016-05-19 15:18   ` [PATCHv2] " Dan Streetman
2016-05-20  2:33     ` Ganesh Mahendran
2016-05-20  4:08     ` Sergey Senozhatsky
2016-05-20 10:32       ` Dan Streetman [this message]
2016-05-23  3:03     ` Minchan Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CALZtONCq-V-r7xYLmkJNsqYf3CbR=mPjRP7Fjp=n-9TaKvHqZw@mail.gmail.com' \
    --to=ddstreet@ieee.org \
    --cc=akpm@linux-foundation.org \
    --cc=dan.streetman@canonical.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=minchan@kernel.org \
    --cc=ngupta@vflare.org \
    --cc=opensource.ganesh@gmail.com \
    --cc=sergey.senozhatsky.work@gmail.com \
    --cc=sergey.senozhatsky@gmail.com \
    --cc=sjenning@redhat.com \
    --cc=yuzhao@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-mm Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-mm/0 linux-mm/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-mm linux-mm/ https://lore.kernel.org/linux-mm \
		linux-mm@kvack.org
	public-inbox-index linux-mm

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kvack.linux-mm


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git