* [PATCH 00/10] Hi,
@ 2020-02-12 8:57 Michal Simek
2020-02-12 8:57 ` [PATCH 02/10] microblaze: Remove architecture tlb.h and use generic one Michal Simek
` (3 more replies)
0 siblings, 4 replies; 11+ messages in thread
From: Michal Simek @ 2020-02-12 8:57 UTC (permalink / raw)
To: linux-kernel, monstr, michal.simek, git, arnd
Cc: Andrew Morton, Aneesh Kumar K.V, Arvind Sankar, Borislav Petkov,
Cornelia Huck, Geert Uytterhoeven, Greg Kroah-Hartman,
Greg Ungerer, Heiko Carstens, Kees Cook, Masahiro Yamada,
Mike Rapoport, Mubin Sayyed, Nicholas Piggin, Oleg Nesterov,
Palmer Dabbelt, Paolo Bonzini, Peter Zijlstra, Randy Dunlap,
Rob Herring, Shubhrajyoti Datta, Siva Durga Prasad Paladugu,
Stefan Asserhall, Vladimir Murzin, Will Deacon, linux-arch,
linux-mm
I am sending this series as before SMP support.
Most of these patches are clean ups and should be easy to review them. I
expect there will be more discussions about SMP support.
There could be some optimization added based on
https://lkml.org/lkml/2020/2/10/1528
Thanks,
Michal
Michal Simek (6):
microblaze: Convert headers to SPDX license
microblaze: Remove architecture tlb.h and use generic one
microblaze: Remove early printk setup
microblaze: Remove empty headers
microblaze: Remove unused boot_cpuid variable
microblaze: Use asm generic cmpxchg.h for !SMP case
Stefan Asserhall (4):
microblaze: Define microblaze barrier
microblaze: Add sync to tlb operations
microblaze: Add missing irqflags.h header
microblaze: Define percpu sestion in linker file
arch/microblaze/include/asm/Kbuild | 4 +-
arch/microblaze/include/asm/barrier.h | 13 ++++++
arch/microblaze/include/asm/cache.h | 5 +--
arch/microblaze/include/asm/cacheflush.h | 6 +--
arch/microblaze/include/asm/checksum.h | 5 +--
arch/microblaze/include/asm/cmpxchg.h | 40 ++-----------------
arch/microblaze/include/asm/cpuinfo.h | 5 +--
arch/microblaze/include/asm/cputable.h | 1 -
arch/microblaze/include/asm/current.h | 5 +--
arch/microblaze/include/asm/delay.h | 7 +---
arch/microblaze/include/asm/dma.h | 5 +--
arch/microblaze/include/asm/elf.h | 5 +--
arch/microblaze/include/asm/entry.h | 5 +--
arch/microblaze/include/asm/exceptions.h | 5 +--
arch/microblaze/include/asm/fixmap.h | 5 +--
arch/microblaze/include/asm/flat.h | 5 +--
arch/microblaze/include/asm/hw_irq.h | 1 -
arch/microblaze/include/asm/io.h | 5 +--
arch/microblaze/include/asm/irq.h | 5 +--
arch/microblaze/include/asm/irqflags.h | 5 +--
arch/microblaze/include/asm/mmu.h | 5 +--
arch/microblaze/include/asm/mmu_context_mm.h | 5 +--
arch/microblaze/include/asm/module.h | 5 +--
arch/microblaze/include/asm/page.h | 5 +--
arch/microblaze/include/asm/pgalloc.h | 5 +--
arch/microblaze/include/asm/pgtable.h | 5 +--
arch/microblaze/include/asm/processor.h | 5 +--
arch/microblaze/include/asm/ptrace.h | 5 +--
arch/microblaze/include/asm/pvr.h | 5 +--
arch/microblaze/include/asm/registers.h | 5 +--
arch/microblaze/include/asm/sections.h | 5 +--
arch/microblaze/include/asm/setup.h | 7 +---
arch/microblaze/include/asm/string.h | 5 +--
arch/microblaze/include/asm/switch_to.h | 5 +--
arch/microblaze/include/asm/thread_info.h | 5 +--
arch/microblaze/include/asm/timex.h | 5 +--
arch/microblaze/include/asm/tlb.h | 17 --------
arch/microblaze/include/asm/tlbflush.h | 5 +--
arch/microblaze/include/asm/uaccess.h | 5 +--
arch/microblaze/include/asm/unaligned.h | 5 +--
arch/microblaze/include/asm/unistd.h | 5 +--
arch/microblaze/include/asm/unwind.h | 5 +--
arch/microblaze/include/asm/user.h | 1 -
arch/microblaze/kernel/cpu/cpuinfo-pvr-full.c | 7 +---
arch/microblaze/kernel/cpu/pvr.c | 1 +
arch/microblaze/kernel/misc.S | 3 +-
arch/microblaze/kernel/setup.c | 1 -
arch/microblaze/kernel/vmlinux.lds.S | 3 ++
48 files changed, 62 insertions(+), 215 deletions(-)
create mode 100644 arch/microblaze/include/asm/barrier.h
delete mode 100644 arch/microblaze/include/asm/cputable.h
delete mode 100644 arch/microblaze/include/asm/hw_irq.h
delete mode 100644 arch/microblaze/include/asm/tlb.h
delete mode 100644 arch/microblaze/include/asm/user.h
--
2.25.0
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH 02/10] microblaze: Remove architecture tlb.h and use generic one
2020-02-12 8:57 [PATCH 00/10] Hi, Michal Simek
@ 2020-02-12 8:57 ` Michal Simek
2020-02-12 13:02 ` [PATCH 00/10] Hi, Arnd Bergmann
` (2 subsequent siblings)
3 siblings, 0 replies; 11+ messages in thread
From: Michal Simek @ 2020-02-12 8:57 UTC (permalink / raw)
To: linux-kernel, monstr, michal.simek, git, arnd
Cc: Stefan Asserhall, Andrew Morton, Aneesh Kumar K.V, Cornelia Huck,
Greg Kroah-Hartman, Masahiro Yamada, Nick Piggin, Paolo Bonzini,
Peter Zijlstra, Will Deacon, linux-arch, linux-mm
There is no reason to have this empty file if it is just link to
asm-generic/tlb.h.
Signed-off-by: Michal Simek <michal.simek@xilinx.com>
Reviewed-by: Stefan Asserhall <stefan.asserhall@xilinx.com>
---
arch/microblaze/include/asm/Kbuild | 1 +
arch/microblaze/include/asm/tlb.h | 17 -----------------
2 files changed, 1 insertion(+), 17 deletions(-)
delete mode 100644 arch/microblaze/include/asm/tlb.h
diff --git a/arch/microblaze/include/asm/Kbuild b/arch/microblaze/include/asm/Kbuild
index e5c9170a07fc..7ae427f73105 100644
--- a/arch/microblaze/include/asm/Kbuild
+++ b/arch/microblaze/include/asm/Kbuild
@@ -31,6 +31,7 @@ generic-y += preempt.h
generic-y += serial.h
generic-y += shmparam.h
generic-y += syscalls.h
+generic-y += tlb.h
generic-y += topology.h
generic-y += trace_clock.h
generic-y += vga.h
diff --git a/arch/microblaze/include/asm/tlb.h b/arch/microblaze/include/asm/tlb.h
deleted file mode 100644
index 628a78ee0a72..000000000000
--- a/arch/microblaze/include/asm/tlb.h
+++ /dev/null
@@ -1,17 +0,0 @@
-/*
- * Copyright (C) 2008-2009 Michal Simek <monstr@monstr.eu>
- * Copyright (C) 2008-2009 PetaLogix
- * Copyright (C) 2006 Atmark Techno, Inc.
- *
- * This file is subject to the terms and conditions of the GNU General Public
- * License. See the file "COPYING" in the main directory of this archive
- * for more details.
- */
-
-#ifndef _ASM_MICROBLAZE_TLB_H
-#define _ASM_MICROBLAZE_TLB_H
-
-#include <linux/pagemap.h>
-#include <asm-generic/tlb.h>
-
-#endif /* _ASM_MICROBLAZE_TLB_H */
--
2.25.0
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH 00/10] Hi,
2020-02-12 8:57 [PATCH 00/10] Hi, Michal Simek
2020-02-12 8:57 ` [PATCH 02/10] microblaze: Remove architecture tlb.h and use generic one Michal Simek
@ 2020-02-12 13:02 ` Arnd Bergmann
2020-02-12 13:32 ` Michal Simek
2020-02-13 23:47 ` Rob Herring
2020-02-25 11:34 ` Michal Simek
3 siblings, 1 reply; 11+ messages in thread
From: Arnd Bergmann @ 2020-02-12 13:02 UTC (permalink / raw)
To: Michal Simek
Cc: linux-kernel, Michal Simek, git, Andrew Morton, Aneesh Kumar K.V,
Arvind Sankar, Borislav Petkov, Cornelia Huck,
Geert Uytterhoeven, Greg Kroah-Hartman, Greg Ungerer,
Heiko Carstens, Kees Cook, Masahiro Yamada, Mike Rapoport,
Mubin Sayyed, Nicholas Piggin, Oleg Nesterov, Palmer Dabbelt,
Paolo Bonzini, Peter Zijlstra, Randy Dunlap, Rob Herring,
Shubhrajyoti Datta, Siva Durga Prasad Paladugu, Stefan Asserhall,
Vladimir Murzin, Will Deacon, linux-arch, Linux-MM
On Wed, Feb 12, 2020 at 9:58 AM Michal Simek <michal.simek@xilinx.com> wrote:
>
>
> I am sending this series as before SMP support.
> Most of these patches are clean ups and should be easy to review them. I
> expect there will be more discussions about SMP support.
Agreed.
I had one question about a detail, other than that:
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 00/10] Hi,
2020-02-12 13:02 ` [PATCH 00/10] Hi, Arnd Bergmann
@ 2020-02-12 13:32 ` Michal Simek
0 siblings, 0 replies; 11+ messages in thread
From: Michal Simek @ 2020-02-12 13:32 UTC (permalink / raw)
To: Arnd Bergmann, Michal Simek
Cc: linux-kernel, Michal Simek, git, Andrew Morton, Aneesh Kumar K.V,
Arvind Sankar, Borislav Petkov, Cornelia Huck,
Geert Uytterhoeven, Greg Kroah-Hartman, Greg Ungerer,
Heiko Carstens, Kees Cook, Masahiro Yamada, Mike Rapoport,
Mubin Sayyed, Nicholas Piggin, Oleg Nesterov, Palmer Dabbelt,
Paolo Bonzini, Peter Zijlstra, Randy Dunlap, Rob Herring,
Shubhrajyoti Datta, Siva Durga Prasad Paladugu, Stefan Asserhall,
Vladimir Murzin, Will Deacon, linux-arch, Linux-MM
On 12. 02. 20 14:02, Arnd Bergmann wrote:
> On Wed, Feb 12, 2020 at 9:58 AM Michal Simek <michal.simek@xilinx.com> wrote:
>>
>>
>> I am sending this series as before SMP support.
>> Most of these patches are clean ups and should be easy to review them. I
>> expect there will be more discussions about SMP support.
>
> Agreed.
>
> I had one question about a detail, other than that:
>
> Reviewed-by: Arnd Bergmann <arnd@arndb.de>
Thanks,
Michal
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 00/10] Hi,
2020-02-12 8:57 [PATCH 00/10] Hi, Michal Simek
2020-02-12 8:57 ` [PATCH 02/10] microblaze: Remove architecture tlb.h and use generic one Michal Simek
2020-02-12 13:02 ` [PATCH 00/10] Hi, Arnd Bergmann
@ 2020-02-13 23:47 ` Rob Herring
2020-02-17 14:27 ` Michal Simek
2020-02-25 11:34 ` Michal Simek
3 siblings, 1 reply; 11+ messages in thread
From: Rob Herring @ 2020-02-13 23:47 UTC (permalink / raw)
To: Michal Simek
Cc: linux-kernel, Michal Simek, git, Arnd Bergmann, Andrew Morton,
Aneesh Kumar K.V, Arvind Sankar, Borislav Petkov, Cornelia Huck,
Geert Uytterhoeven, Greg Kroah-Hartman, Greg Ungerer,
Heiko Carstens, Kees Cook, Masahiro Yamada, Mike Rapoport,
Mubin Sayyed, Nicholas Piggin, Oleg Nesterov, Palmer Dabbelt,
Paolo Bonzini, Peter Zijlstra, Randy Dunlap, Shubhrajyoti Datta,
Siva Durga Prasad Paladugu, Stefan Asserhall, Vladimir Murzin,
Will Deacon, open list:GENERIC INCLUDE/ASM HEADER FILES,
linux-mm
On Wed, Feb 12, 2020 at 2:58 AM Michal Simek <michal.simek@xilinx.com> wrote:
>
>
> I am sending this series as before SMP support.
> Most of these patches are clean ups and should be easy to review them. I
> expect there will be more discussions about SMP support.
While not really related to adding SMP, any chance you or someone
could look at moving microblaze PCI support to drivers/pci/? I suspect
much of the code should drop out as we have common helpers for much of
it now. That would leave only powerpc and mips for DT+PCI platforms.
Rob
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 00/10] Hi,
2020-02-13 23:47 ` Rob Herring
@ 2020-02-17 14:27 ` Michal Simek
2020-02-25 16:32 ` Rob Herring
0 siblings, 1 reply; 11+ messages in thread
From: Michal Simek @ 2020-02-17 14:27 UTC (permalink / raw)
To: Rob Herring, Michal Simek
Cc: linux-kernel, Michal Simek, git, Arnd Bergmann, Andrew Morton,
Aneesh Kumar K.V, Arvind Sankar, Borislav Petkov, Cornelia Huck,
Geert Uytterhoeven, Greg Kroah-Hartman, Greg Ungerer,
Heiko Carstens, Kees Cook, Masahiro Yamada, Mike Rapoport,
Mubin Sayyed, Nicholas Piggin, Oleg Nesterov, Palmer Dabbelt,
Paolo Bonzini, Peter Zijlstra, Randy Dunlap, Shubhrajyoti Datta,
Siva Durga Prasad Paladugu, Stefan Asserhall, Vladimir Murzin,
Will Deacon, open list:GENERIC INCLUDE/ASM HEADER FILES,
linux-mm, Bharat Kumar Gogada
Hi Rob,
On 14. 02. 20 0:47, Rob Herring wrote:
> On Wed, Feb 12, 2020 at 2:58 AM Michal Simek <michal.simek@xilinx.com> wrote:
>>
>>
>> I am sending this series as before SMP support.
>> Most of these patches are clean ups and should be easy to review them. I
>> expect there will be more discussions about SMP support.
>
> While not really related to adding SMP, any chance you or someone
> could look at moving microblaze PCI support to drivers/pci/? I suspect
> much of the code should drop out as we have common helpers for much of
> it now. That would leave only powerpc and mips for DT+PCI platforms.
can you please suggest changes which could be done?
I have CC Bharat and he could look at it.
Thanks,
Michal
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 00/10] Hi,
2020-02-12 8:57 [PATCH 00/10] Hi, Michal Simek
` (2 preceding siblings ...)
2020-02-13 23:47 ` Rob Herring
@ 2020-02-25 11:34 ` Michal Simek
3 siblings, 0 replies; 11+ messages in thread
From: Michal Simek @ 2020-02-25 11:34 UTC (permalink / raw)
To: Michal Simek, linux-kernel, git, arnd
Cc: Andrew Morton, Aneesh Kumar K.V, Arvind Sankar, Borislav Petkov,
Cornelia Huck, Geert Uytterhoeven, Greg Kroah-Hartman,
Greg Ungerer, Heiko Carstens, Kees Cook, Masahiro Yamada,
Mike Rapoport, Mubin Sayyed, Nicholas Piggin, Oleg Nesterov,
Palmer Dabbelt, Paolo Bonzini, Peter Zijlstra, Randy Dunlap,
Rob Herring, Shubhrajyoti Datta, Siva Durga Prasad Paladugu,
Stefan Asserhall, Vladimir Murzin, Will Deacon, linux-arch,
linux-mm
[-- Attachment #1.1: Type: text/plain, Size: 4409 bytes --]
On 12. 02. 20 9:57, Michal Simek wrote:
>
> I am sending this series as before SMP support.
> Most of these patches are clean ups and should be easy to review them. I
> expect there will be more discussions about SMP support.
>
> There could be some optimization added based on
> https://lkml.org/lkml/2020/2/10/1528
>
> Thanks,
> Michal
>
>
> Michal Simek (6):
> microblaze: Convert headers to SPDX license
> microblaze: Remove architecture tlb.h and use generic one
> microblaze: Remove early printk setup
> microblaze: Remove empty headers
> microblaze: Remove unused boot_cpuid variable
> microblaze: Use asm generic cmpxchg.h for !SMP case
>
> Stefan Asserhall (4):
> microblaze: Define microblaze barrier
> microblaze: Add sync to tlb operations
> microblaze: Add missing irqflags.h header
> microblaze: Define percpu sestion in linker file
>
> arch/microblaze/include/asm/Kbuild | 4 +-
> arch/microblaze/include/asm/barrier.h | 13 ++++++
> arch/microblaze/include/asm/cache.h | 5 +--
> arch/microblaze/include/asm/cacheflush.h | 6 +--
> arch/microblaze/include/asm/checksum.h | 5 +--
> arch/microblaze/include/asm/cmpxchg.h | 40 ++-----------------
> arch/microblaze/include/asm/cpuinfo.h | 5 +--
> arch/microblaze/include/asm/cputable.h | 1 -
> arch/microblaze/include/asm/current.h | 5 +--
> arch/microblaze/include/asm/delay.h | 7 +---
> arch/microblaze/include/asm/dma.h | 5 +--
> arch/microblaze/include/asm/elf.h | 5 +--
> arch/microblaze/include/asm/entry.h | 5 +--
> arch/microblaze/include/asm/exceptions.h | 5 +--
> arch/microblaze/include/asm/fixmap.h | 5 +--
> arch/microblaze/include/asm/flat.h | 5 +--
> arch/microblaze/include/asm/hw_irq.h | 1 -
> arch/microblaze/include/asm/io.h | 5 +--
> arch/microblaze/include/asm/irq.h | 5 +--
> arch/microblaze/include/asm/irqflags.h | 5 +--
> arch/microblaze/include/asm/mmu.h | 5 +--
> arch/microblaze/include/asm/mmu_context_mm.h | 5 +--
> arch/microblaze/include/asm/module.h | 5 +--
> arch/microblaze/include/asm/page.h | 5 +--
> arch/microblaze/include/asm/pgalloc.h | 5 +--
> arch/microblaze/include/asm/pgtable.h | 5 +--
> arch/microblaze/include/asm/processor.h | 5 +--
> arch/microblaze/include/asm/ptrace.h | 5 +--
> arch/microblaze/include/asm/pvr.h | 5 +--
> arch/microblaze/include/asm/registers.h | 5 +--
> arch/microblaze/include/asm/sections.h | 5 +--
> arch/microblaze/include/asm/setup.h | 7 +---
> arch/microblaze/include/asm/string.h | 5 +--
> arch/microblaze/include/asm/switch_to.h | 5 +--
> arch/microblaze/include/asm/thread_info.h | 5 +--
> arch/microblaze/include/asm/timex.h | 5 +--
> arch/microblaze/include/asm/tlb.h | 17 --------
> arch/microblaze/include/asm/tlbflush.h | 5 +--
> arch/microblaze/include/asm/uaccess.h | 5 +--
> arch/microblaze/include/asm/unaligned.h | 5 +--
> arch/microblaze/include/asm/unistd.h | 5 +--
> arch/microblaze/include/asm/unwind.h | 5 +--
> arch/microblaze/include/asm/user.h | 1 -
> arch/microblaze/kernel/cpu/cpuinfo-pvr-full.c | 7 +---
> arch/microblaze/kernel/cpu/pvr.c | 1 +
> arch/microblaze/kernel/misc.S | 3 +-
> arch/microblaze/kernel/setup.c | 1 -
> arch/microblaze/kernel/vmlinux.lds.S | 3 ++
> 48 files changed, 62 insertions(+), 215 deletions(-)
> create mode 100644 arch/microblaze/include/asm/barrier.h
> delete mode 100644 arch/microblaze/include/asm/cputable.h
> delete mode 100644 arch/microblaze/include/asm/hw_irq.h
> delete mode 100644 arch/microblaze/include/asm/tlb.h
> delete mode 100644 arch/microblaze/include/asm/user.h
>
applied all.
M
--
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Xilinx Microblaze
Maintainer of Linux kernel - Xilinx Zynq ARM and ZynqMP ARM64 SoCs
U-Boot custodian - Xilinx Microblaze/Zynq/ZynqMP/Versal SoCs
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 00/10] Hi,
2020-02-17 14:27 ` Michal Simek
@ 2020-02-25 16:32 ` Rob Herring
2020-02-27 7:31 ` Michal Simek
0 siblings, 1 reply; 11+ messages in thread
From: Rob Herring @ 2020-02-25 16:32 UTC (permalink / raw)
To: Michal Simek
Cc: linux-kernel, Michal Simek, git, Arnd Bergmann, Andrew Morton,
Aneesh Kumar K.V, Arvind Sankar, Borislav Petkov, Cornelia Huck,
Geert Uytterhoeven, Greg Kroah-Hartman, Greg Ungerer,
Heiko Carstens, Kees Cook, Masahiro Yamada, Mike Rapoport,
Mubin Sayyed, Nicholas Piggin, Oleg Nesterov, Palmer Dabbelt,
Paolo Bonzini, Peter Zijlstra, Randy Dunlap, Shubhrajyoti Datta,
Siva Durga Prasad Paladugu, Stefan Asserhall, Vladimir Murzin,
Will Deacon, open list:GENERIC INCLUDE/ASM HEADER FILES,
linux-mm, Bharat Kumar Gogada
On Mon, Feb 17, 2020 at 8:28 AM Michal Simek <michal.simek@xilinx.com> wrote:
>
> Hi Rob,
>
> On 14. 02. 20 0:47, Rob Herring wrote:
> > On Wed, Feb 12, 2020 at 2:58 AM Michal Simek <michal.simek@xilinx.com> wrote:
> >>
> >>
> >> I am sending this series as before SMP support.
> >> Most of these patches are clean ups and should be easy to review them. I
> >> expect there will be more discussions about SMP support.
> >
> > While not really related to adding SMP, any chance you or someone
> > could look at moving microblaze PCI support to drivers/pci/? I suspect
> > much of the code should drop out as we have common helpers for much of
> > it now. That would leave only powerpc and mips for DT+PCI platforms.
>
> can you please suggest changes which could be done?
> I have CC Bharat and he could look at it.
Look at the host controller drivers in drivers/pci/controller/.
pci-host-{generic,common}.c is a good template to start with as that's
a controller with standard config space accesses and no h/w setup
needed. Essentially you need to call devm_pci_alloc_host_bridge(),
pci_parse_request_of_pci_ranges() and pci_host_probe() with whatever
h/w setup you need in between those calls.
Looking at the microblaze PCI code, looks like you may need custom
config space accessors which is quite common. Probably all the
resource and device scanning can be removed. If you look at arm64, all
the arch PCI code is just for ACPI.
Rob
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 00/10] Hi,
2020-02-25 16:32 ` Rob Herring
@ 2020-02-27 7:31 ` Michal Simek
2020-06-01 4:22 ` Bharat Kumar Gogada
0 siblings, 1 reply; 11+ messages in thread
From: Michal Simek @ 2020-02-27 7:31 UTC (permalink / raw)
To: Rob Herring, Michal Simek
Cc: linux-kernel, Michal Simek, git, Arnd Bergmann, Andrew Morton,
Aneesh Kumar K.V, Arvind Sankar, Borislav Petkov, Cornelia Huck,
Geert Uytterhoeven, Greg Kroah-Hartman, Greg Ungerer,
Heiko Carstens, Kees Cook, Masahiro Yamada, Mike Rapoport,
Mubin Sayyed, Nicholas Piggin, Oleg Nesterov, Palmer Dabbelt,
Paolo Bonzini, Peter Zijlstra, Randy Dunlap, Shubhrajyoti Datta,
Siva Durga Prasad Paladugu, Stefan Asserhall, Vladimir Murzin,
Will Deacon, open list:GENERIC INCLUDE/ASM HEADER FILES,
linux-mm, Bharat Kumar Gogada
On 25. 02. 20 17:32, Rob Herring wrote:
> On Mon, Feb 17, 2020 at 8:28 AM Michal Simek <michal.simek@xilinx.com> wrote:
>>
>> Hi Rob,
>>
>> On 14. 02. 20 0:47, Rob Herring wrote:
>>> On Wed, Feb 12, 2020 at 2:58 AM Michal Simek <michal.simek@xilinx.com> wrote:
>>>>
>>>>
>>>> I am sending this series as before SMP support.
>>>> Most of these patches are clean ups and should be easy to review them. I
>>>> expect there will be more discussions about SMP support.
>>>
>>> While not really related to adding SMP, any chance you or someone
>>> could look at moving microblaze PCI support to drivers/pci/? I suspect
>>> much of the code should drop out as we have common helpers for much of
>>> it now. That would leave only powerpc and mips for DT+PCI platforms.
>>
>> can you please suggest changes which could be done?
>> I have CC Bharat and he could look at it.
>
> Look at the host controller drivers in drivers/pci/controller/.
> pci-host-{generic,common}.c is a good template to start with as that's
> a controller with standard config space accesses and no h/w setup
> needed. Essentially you need to call devm_pci_alloc_host_bridge(),
> pci_parse_request_of_pci_ranges() and pci_host_probe() with whatever
> h/w setup you need in between those calls.
>
> Looking at the microblaze PCI code, looks like you may need custom
> config space accessors which is quite common. Probably all the
> resource and device scanning can be removed. If you look at arm64, all
> the arch PCI code is just for ACPI.
Thanks Rob.
Bharat: Can you please take a look?
Thanks,
Michal
^ permalink raw reply [flat|nested] 11+ messages in thread
* RE: [PATCH 00/10] Hi,
2020-02-27 7:31 ` Michal Simek
@ 2020-06-01 4:22 ` Bharat Kumar Gogada
2020-06-01 14:05 ` Rob Herring
0 siblings, 1 reply; 11+ messages in thread
From: Bharat Kumar Gogada @ 2020-06-01 4:22 UTC (permalink / raw)
To: Michal Simek, Rob Herring, Michal Simek
Cc: linux-kernel, monstr, git, Arnd Bergmann, Andrew Morton,
Aneesh Kumar K.V, Arvind Sankar, Borislav Petkov, Cornelia Huck,
Geert Uytterhoeven, Greg Kroah-Hartman, Greg Ungerer,
Heiko Carstens, Kees Cook, Masahiro Yamada, Mike Rapoport,
Mubin Usman Sayyed, Nicholas Piggin, Oleg Nesterov,
Palmer Dabbelt, Paolo Bonzini, Peter Zijlstra, Randy Dunlap,
Shubhrajyoti Datta, Siva Durga Prasad Paladugu, Stefan Asserhall,
Vladimir Murzin, Will Deacon,
open list:GENERIC INCLUDE/ASM HEADER FILES, linux-mm
> On 25. 02. 20 17:32, Rob Herring wrote:
> > On Mon, Feb 17, 2020 at 8:28 AM Michal Simek <michal.simek@xilinx.com>
> wrote:
> >>
> >> Hi Rob,
> >>
> >> On 14. 02. 20 0:47, Rob Herring wrote:
> >>> On Wed, Feb 12, 2020 at 2:58 AM Michal Simek
> <michal.simek@xilinx.com> wrote:
> >>>>
> >>>>
> >>>> I am sending this series as before SMP support.
> >>>> Most of these patches are clean ups and should be easy to review
> >>>> them. I expect there will be more discussions about SMP support.
> >>>
> >>> While not really related to adding SMP, any chance you or someone
> >>> could look at moving microblaze PCI support to drivers/pci/? I
> >>> suspect much of the code should drop out as we have common helpers
> >>> for much of it now. That would leave only powerpc and mips for DT+PCI
> platforms.
> >>
> >> can you please suggest changes which could be done?
> >> I have CC Bharat and he could look at it.
> >
> > Look at the host controller drivers in drivers/pci/controller/.
> > pci-host-{generic,common}.c is a good template to start with as that's
> > a controller with standard config space accesses and no h/w setup
> > needed. Essentially you need to call devm_pci_alloc_host_bridge(),
> > pci_parse_request_of_pci_ranges() and pci_host_probe() with whatever
> > h/w setup you need in between those calls.
> >
> > Looking at the microblaze PCI code, looks like you may need custom
> > config space accessors which is quite common. Probably all the
> > resource and device scanning can be removed. If you look at arm64, all
> > the arch PCI code is just for ACPI.
Hi Rob,
Can you please let us know why we might need custom config space accessors ?
We tested pci_generic_config_read/write accessors on microblaze, and we
did not see any issues.
Regards,
Bharat
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 00/10] Hi,
2020-06-01 4:22 ` Bharat Kumar Gogada
@ 2020-06-01 14:05 ` Rob Herring
0 siblings, 0 replies; 11+ messages in thread
From: Rob Herring @ 2020-06-01 14:05 UTC (permalink / raw)
To: Bharat Kumar Gogada
Cc: Michal Simek, linux-kernel, monstr, git, Arnd Bergmann,
Andrew Morton, Aneesh Kumar K.V, Arvind Sankar, Borislav Petkov,
Cornelia Huck, Geert Uytterhoeven, Greg Kroah-Hartman,
Greg Ungerer, Heiko Carstens, Kees Cook, Masahiro Yamada,
Mike Rapoport, Mubin Usman Sayyed, Nicholas Piggin,
Oleg Nesterov, Palmer Dabbelt, Paolo Bonzini, Peter Zijlstra,
Randy Dunlap, Shubhrajyoti Datta, Siva Durga Prasad Paladugu,
Stefan Asserhall, Vladimir Murzin, Will Deacon,
open list:GENERIC INCLUDE/ASM HEADER FILES, linux-mm
On Sun, May 31, 2020 at 10:22 PM Bharat Kumar Gogada
<bharatku@xilinx.com> wrote:
>
> > On 25. 02. 20 17:32, Rob Herring wrote:
> > > On Mon, Feb 17, 2020 at 8:28 AM Michal Simek <michal.simek@xilinx.com>
> > wrote:
> > >>
> > >> Hi Rob,
> > >>
> > >> On 14. 02. 20 0:47, Rob Herring wrote:
> > >>> On Wed, Feb 12, 2020 at 2:58 AM Michal Simek
> > <michal.simek@xilinx.com> wrote:
> > >>>>
> > >>>>
> > >>>> I am sending this series as before SMP support.
> > >>>> Most of these patches are clean ups and should be easy to review
> > >>>> them. I expect there will be more discussions about SMP support.
> > >>>
> > >>> While not really related to adding SMP, any chance you or someone
> > >>> could look at moving microblaze PCI support to drivers/pci/? I
> > >>> suspect much of the code should drop out as we have common helpers
> > >>> for much of it now. That would leave only powerpc and mips for DT+PCI
> > platforms.
> > >>
> > >> can you please suggest changes which could be done?
> > >> I have CC Bharat and he could look at it.
> > >
> > > Look at the host controller drivers in drivers/pci/controller/.
> > > pci-host-{generic,common}.c is a good template to start with as that's
> > > a controller with standard config space accesses and no h/w setup
> > > needed. Essentially you need to call devm_pci_alloc_host_bridge(),
> > > pci_parse_request_of_pci_ranges() and pci_host_probe() with whatever
> > > h/w setup you need in between those calls.
> > >
> > > Looking at the microblaze PCI code, looks like you may need custom
> > > config space accessors which is quite common. Probably all the
> > > resource and device scanning can be removed. If you look at arm64, all
> > > the arch PCI code is just for ACPI.
> Hi Rob,
>
> Can you please let us know why we might need custom config space accessors ?
> We tested pci_generic_config_read/write accessors on microblaze, and we
> did not see any issues.
I was thinking maybe the indirect code might have to be custom, but
maybe everything can be handled in .map_bus().
Rob
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2020-06-01 14:06 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-12 8:57 [PATCH 00/10] Hi, Michal Simek
2020-02-12 8:57 ` [PATCH 02/10] microblaze: Remove architecture tlb.h and use generic one Michal Simek
2020-02-12 13:02 ` [PATCH 00/10] Hi, Arnd Bergmann
2020-02-12 13:32 ` Michal Simek
2020-02-13 23:47 ` Rob Herring
2020-02-17 14:27 ` Michal Simek
2020-02-25 16:32 ` Rob Herring
2020-02-27 7:31 ` Michal Simek
2020-06-01 4:22 ` Bharat Kumar Gogada
2020-06-01 14:05 ` Rob Herring
2020-02-25 11:34 ` Michal Simek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).