From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 596FEC35E01 for ; Tue, 25 Feb 2020 16:32:20 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 1AA1E2082F for ; Tue, 25 Feb 2020 16:32:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="ZGLTuMvQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1AA1E2082F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A27B06B0006; Tue, 25 Feb 2020 11:32:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9FD4E6B0007; Tue, 25 Feb 2020 11:32:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8C5026B0008; Tue, 25 Feb 2020 11:32:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0245.hostedemail.com [216.40.44.245]) by kanga.kvack.org (Postfix) with ESMTP id 733726B0006 for ; Tue, 25 Feb 2020 11:32:19 -0500 (EST) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 2AFF02470 for ; Tue, 25 Feb 2020 16:32:19 +0000 (UTC) X-FDA: 76529191998.24.boys50_314329b54fa53 X-HE-Tag: boys50_314329b54fa53 X-Filterd-Recvd-Size: 4813 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf43.hostedemail.com (Postfix) with ESMTP for ; Tue, 25 Feb 2020 16:32:18 +0000 (UTC) Received: from mail-qt1-f180.google.com (mail-qt1-f180.google.com [209.85.160.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7FB4B218AC for ; Tue, 25 Feb 2020 16:32:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582648337; bh=MCrV5uIeOq1NBjKfFArVww7a5Bwy8RsEAJR83B5u/ts=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=ZGLTuMvQXqzA7Q6QXxkMg3mcTzv5qXduW8wwCbUw4s2O5ULGcL7EikLJ7hul50m5b o68Fq03A9pqAEFEgbXVAz3C9jQ3WpK3QpSLfn6eG9pVBVE2ACUHj+9hHTjMJStB9TG /6MGOspZd0qqHuYzFcHI2sBt42nrTEVEquWkRBgU= Received: by mail-qt1-f180.google.com with SMTP id d9so34477qte.12 for ; Tue, 25 Feb 2020 08:32:17 -0800 (PST) X-Gm-Message-State: APjAAAXz7tvFrnVByGWFyAy4sTRxepTxFiv2wZ/6P4QitT1YaebUt81M sU/Wku5uCesVpn91PycLkmUtyLKB6dmfnVVaBw== X-Google-Smtp-Source: APXvYqwaelGAkne5AZQ+7QJShUjrcFRgO3DLk3emKjSAc4go5pZt6/PclR5bStzZ+o8zDjvqFxxc6Irx4VX8P8w0noY= X-Received: by 2002:ac8:6747:: with SMTP id n7mr7137190qtp.224.1582648336578; Tue, 25 Feb 2020 08:32:16 -0800 (PST) MIME-Version: 1.0 References: <0f8140c1-da6f-ef04-0809-252d6de6a5d7@xilinx.com> In-Reply-To: <0f8140c1-da6f-ef04-0809-252d6de6a5d7@xilinx.com> From: Rob Herring Date: Tue, 25 Feb 2020 10:32:05 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 00/10] Hi, To: Michal Simek Cc: "linux-kernel@vger.kernel.org" , Michal Simek , git , Arnd Bergmann , Andrew Morton , "Aneesh Kumar K.V" , Arvind Sankar , Borislav Petkov , Cornelia Huck , Geert Uytterhoeven , Greg Kroah-Hartman , Greg Ungerer , Heiko Carstens , Kees Cook , Masahiro Yamada , Mike Rapoport , Mubin Sayyed , Nicholas Piggin , Oleg Nesterov , Palmer Dabbelt , Paolo Bonzini , Peter Zijlstra , Randy Dunlap , Shubhrajyoti Datta , Siva Durga Prasad Paladugu , Stefan Asserhall , Vladimir Murzin , Will Deacon , "open list:GENERIC INCLUDE/ASM HEADER FILES" , linux-mm@kvack.org, Bharat Kumar Gogada Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Feb 17, 2020 at 8:28 AM Michal Simek wrote: > > Hi Rob, > > On 14. 02. 20 0:47, Rob Herring wrote: > > On Wed, Feb 12, 2020 at 2:58 AM Michal Simek wrote: > >> > >> > >> I am sending this series as before SMP support. > >> Most of these patches are clean ups and should be easy to review them. I > >> expect there will be more discussions about SMP support. > > > > While not really related to adding SMP, any chance you or someone > > could look at moving microblaze PCI support to drivers/pci/? I suspect > > much of the code should drop out as we have common helpers for much of > > it now. That would leave only powerpc and mips for DT+PCI platforms. > > can you please suggest changes which could be done? > I have CC Bharat and he could look at it. Look at the host controller drivers in drivers/pci/controller/. pci-host-{generic,common}.c is a good template to start with as that's a controller with standard config space accesses and no h/w setup needed. Essentially you need to call devm_pci_alloc_host_bridge(), pci_parse_request_of_pci_ranges() and pci_host_probe() with whatever h/w setup you need in between those calls. Looking at the microblaze PCI code, looks like you may need custom config space accessors which is quite common. Probably all the resource and device scanning can be removed. If you look at arm64, all the arch PCI code is just for ACPI. Rob