From: kushal kothari <kushalkothari285@gmail.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: rppt@kernel.org, akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org,
Mike Rapoport <mike.rapoport@gmail.com>,
kushalkothari2850@gmail.com
Subject: Re: [PATCH] staging: mm: Fix ERROR:do not initialise statics to 0 or NULL in memblock.c
Date: Wed, 3 Nov 2021 18:12:57 +0530 [thread overview]
Message-ID: <CALtHPQv1Gs4vMUfiNfDpQvjaW0Q3vkFQAvtVJvy+jQLxo_MHAA@mail.gmail.com> (raw)
In-Reply-To: <YX/8DKt4I0kf9Eau@casper.infradead.org>
[-- Attachment #1: Type: text/plain, Size: 1167 bytes --]
>Why does the subject line say "staging"? What tool reports this as an
>"ERROR"?
Sorry. I made a mistake there while writing the subject line and adding
<stdbool.h>.
I am fixing it in v2.
I ran the checkpatch.pl script which reported this error.
On Mon, Nov 1, 2021 at 8:10 PM Matthew Wilcox <willy@infradead.org> wrote:
> On Mon, Nov 01, 2021 at 03:47:19PM +0530, Kushal Kothari wrote:
> > The default value of static variable is zero and bool is false so
> > not need to set it here.
> > This patch fixes this ERROR in memblock.c
>
> Why does the subject line say "staging"? What tool reports this as an
> "ERROR"?
>
> > Signed-off-by: Kushal Kothari <kushalkothari285@gmail.com>
> > ---
> > mm/memblock.c | 8 ++++----
> > 1 file changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/mm/memblock.c b/mm/memblock.c
> > index 5c3503c98b2f..57b9153b2278 100644
> > --- a/mm/memblock.c
> > +++ b/mm/memblock.c
> > @@ -16,7 +16,7 @@
> > #include <linux/kmemleak.h>
> > #include <linux/seq_file.h>
> > #include <linux/memblock.h>
> > -
> > +#include<stdbool.h>
>
> Why are you including stdbool here? Why do you not justify it in the
> changelog?
>
>
[-- Attachment #2: Type: text/html, Size: 1926 bytes --]
prev parent reply other threads:[~2021-11-03 12:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-01 10:17 [PATCH] staging: mm: Fix ERROR:do not initialise statics to 0 or NULL in memblock.c Kushal Kothari
2021-11-01 14:39 ` Matthew Wilcox
2021-11-03 12:42 ` kushal kothari [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALtHPQv1Gs4vMUfiNfDpQvjaW0Q3vkFQAvtVJvy+jQLxo_MHAA@mail.gmail.com \
--to=kushalkothari285@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=kushalkothari2850@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mike.rapoport@gmail.com \
--cc=rppt@kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).