From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=0.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2E53C433DB for ; Sun, 24 Jan 2021 04:36:27 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7D64F22CA1 for ; Sun, 24 Jan 2021 04:36:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7D64F22CA1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 878976B0005; Sat, 23 Jan 2021 23:36:26 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 82BEB6B0007; Sat, 23 Jan 2021 23:36:26 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6F1C26B0008; Sat, 23 Jan 2021 23:36:26 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0204.hostedemail.com [216.40.44.204]) by kanga.kvack.org (Postfix) with ESMTP id 596356B0005 for ; Sat, 23 Jan 2021 23:36:26 -0500 (EST) Received: from smtpin09.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 0011B181AF5C4 for ; Sun, 24 Jan 2021 04:36:25 +0000 (UTC) X-FDA: 77739407172.09.fruit96_1c049332757a Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin09.hostedemail.com (Postfix) with ESMTP id D3C33180AD838 for ; Sun, 24 Jan 2021 04:36:25 +0000 (UTC) X-HE-Tag: fruit96_1c049332757a X-Filterd-Recvd-Size: 4507 Received: from mail-yb1-f172.google.com (mail-yb1-f172.google.com [209.85.219.172]) by imf34.hostedemail.com (Postfix) with ESMTP for ; Sun, 24 Jan 2021 04:36:25 +0000 (UTC) Received: by mail-yb1-f172.google.com with SMTP id p185so9840324ybg.8 for ; Sat, 23 Jan 2021 20:36:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=FgAE1Z29PlQgkGYrDhwHgCBNkzqEv8Jpun+PRApidCM=; b=PHL1SlwR0cxMP2Hjgk6i++L9PQ03cwbdC7rdPQkLNThQLbOAVXF4wRrrC/Q7yMAbh+ BRt0btOFLQ1pMcKGCECCfWxEspK+5OBLOvpgy2Exc9ODAtK+sL+EdGEucDKsORqyBMfW 9dDnDFvwEkWB1wYUWTcDC3La3RsxQVefkZ7lhQX1ga8qfeWwt8s+bFtPXq/zQfVzJPfa QZHpsVuK4vgcY5jp17qgzmkseP18AV4AfspmKpUkFhffOuMhkhJdas+j2uDltOkgXyXC KlIZXFGMnv89tk4cEAyHydiSyvF8mSqFIBaScpu1gb/NqBmAs63umedBF/HFX2ChkD/K PrmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=FgAE1Z29PlQgkGYrDhwHgCBNkzqEv8Jpun+PRApidCM=; b=B2sUekKZqFP9Cgn51m98ShsLG09a7hvD7pwkQb+XN8b8XQgJWVs6V+J3IXRv2bk1v1 8YzPud1sa3E/djxWyG8aDVCnzvbFt52AojG9lHHVQTFigxVasy+e/G+NMf2nvP85yBmE sCCWKnUWhJuP0BI9IuTA+WkBBVyN2/on42H5atVJh8cdNn9U0SLYKl9hPa7K+22lgN7M 8nPLQm9puQbgE+UAF4pi/O8Dx5IdImophDbERw+IHZvXqD8RP0CaGE46vZwGHk+zIJSt vs+4kQxhZUiRHn+5iv3sd62TICvYvrCAZ+2pvSK33XVefMzt+EDHEGvGoqI+CssS9F2r m2UQ== X-Gm-Message-State: AOAM531yGOF8b7GgqTCi8rhmjQ6qmVMp2YQkk8+ZQU5JAaz3Yz20PLW2 SccAsHm3eH5d+i0KP5LDdT2FWrdgWLiEp0pJ4rc= X-Google-Smtp-Source: ABdhPJwTSD1nsciT2pa9i2JKkMgoBc+p+kdObk6W36zEo/aZLyuw1v+GzR509gSFc2lejSjkZPvX2fFsBIKz7e9ZE8o= X-Received: by 2002:a25:9a04:: with SMTP id x4mr2339041ybn.184.1611462984895; Sat, 23 Jan 2021 20:36:24 -0800 (PST) MIME-Version: 1.0 References: <1611455017-2210-1-git-send-email-stephenzhangzsd@gmail.com> <20210124040656.GB308988@casper.infradead.org> In-Reply-To: <20210124040656.GB308988@casper.infradead.org> From: Stephen Zhang Date: Sun, 24 Jan 2021 12:36:12 +0800 Message-ID: Subject: Re: [PATCH] mm/memfd: replace strcpy() by strscpy() To: Matthew Wilcox Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: multipart/alternative; boundary="000000000000c891ae05b99df6e8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --000000000000c891ae05b99df6e8 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Thanks for your suggestions. I just thought both of them are better than the deprecated strcpy(). Should I resubmit the patch after making changes or just leave it as it originally is? Matthew Wilcox =E4=BA=8E2021=E5=B9=B41=E6=9C=8824=E6= =97=A5=E5=91=A8=E6=97=A5 =E4=B8=8B=E5=8D=8812:08=E5=86=99=E9=81=93=EF=BC=9A > On Sun, Jan 24, 2021 at 10:23:37AM +0800, Stephen Zhang wrote: > > - strcpy(name, MFD_NAME_PREFIX); > > + strscpy(name, MFD_NAME_PREFIX, len + MFD_NAME_PREFIX_LEN); > > This is silly. Use memcpy() if you must remove strcpy. > --000000000000c891ae05b99df6e8 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks for your suggestions. I just thought both of them a= re better than the deprecated strcpy().
Should I resubmit the patch aft= er making changes or just leave it as it originally is?

=
Matthew Wi= lcox <willy@infradead.org>= =E4=BA=8E2021=E5=B9=B41=E6=9C=8824=E6=97=A5=E5=91=A8=E6=97=A5 =E4=B8=8B=E5= =8D=8812:08=E5=86=99=E9=81=93=EF=BC=9A
On Sun, Jan 24, 2021 at 10:23:37AM +0800, Stephen Zh= ang wrote:
> -=C2=A0 =C2=A0 =C2=A0strcpy(name, MFD_NAME_PREFIX);
> +=C2=A0 =C2=A0 =C2=A0strscpy(name, MFD_NAME_PREFIX, len + MFD_NAME_PRE= FIX_LEN);

This is silly.=C2=A0 Use memcpy() if you must remove strcpy.
--000000000000c891ae05b99df6e8--