From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2ED3CC433EF for ; Mon, 18 Oct 2021 15:07:36 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C69F7610A1 for ; Mon, 18 Oct 2021 15:07:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org C69F7610A1 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 4D15F900003; Mon, 18 Oct 2021 11:07:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4810C900002; Mon, 18 Oct 2021 11:07:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 36F5E900003; Mon, 18 Oct 2021 11:07:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0009.hostedemail.com [216.40.44.9]) by kanga.kvack.org (Postfix) with ESMTP id 27C95900002 for ; Mon, 18 Oct 2021 11:07:35 -0400 (EDT) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id ACCF61BCBA for ; Mon, 18 Oct 2021 15:07:34 +0000 (UTC) X-FDA: 78709887228.13.9748A14 Received: from mail-lf1-f42.google.com (mail-lf1-f42.google.com [209.85.167.42]) by imf06.hostedemail.com (Postfix) with ESMTP id B00F5801A8A8 for ; Mon, 18 Oct 2021 15:07:33 +0000 (UTC) Received: by mail-lf1-f42.google.com with SMTP id r19so328960lfe.10 for ; Mon, 18 Oct 2021 08:07:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=6bRJbqa6xT34/h7NxHqqr/Wrj4ooiVPcZ2S2RE7msX0=; b=tD7pGpPfZPhaSJpFmCQHjE8kNfwVnGkla3JDhKVEXmEq1jfKNyRz9nnFit+58lszlJ WlNab+RrKfHDmFdjRl05B7+DTrm4zLtlznOneffVIV5/jMgTSknMxa2PQ4hVjTUZEafw PhNcTjrFsTpdCPYFrDGtdBqvhUenjTpujzRQp2/tEhySHtn5hsSzVvpD3r+E4feXnuW5 eAWFmBWQ1CB5tiJDO2xUyzQazBKDDNjpnCkkjdhpwhdMMuBERyvKVr5dr672S9Pq/0hL g8+zyVv0DxEwLoun1bQvj9ls/CruLgbDWQl+p7d2GS92pO6OHGf7RefsBkcTzHavFLOR KMog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=6bRJbqa6xT34/h7NxHqqr/Wrj4ooiVPcZ2S2RE7msX0=; b=roIy3rl3CzTu/w18ImS3Ljs9ZNTCRb6LmvyIGBMnzSyZU2/fFoYuE8pcCIl2MppTC/ /kbCQZP0TNvRl9jRTNkDj7/hEUaaQ8ROw42O8qr2rzl/phXvSg6tNI0livSVKno58FQK SbtmvERpDGkhL6+p/FGmiZU/mZLwoIh5Sv7rRhR+shqjQo7hFpfDBoa+TDdEofAYK83K IvtZ10ax46bmkKpjwbWxB+ZP9dM5/ektM/KYfGm6vZ87vbcu3Olo7W2LNimVrAvJL1Fq 8ry+YgtcJ/OYamN2dQrA0ST/YPoMKIfJXhQRJ8RDjWcZSL2a/cr9UKsLBesEZG91y8Hx gXgw== X-Gm-Message-State: AOAM530Uju6C90Xrkz/u43wgt5O8XeW99abOfPAcLibToEm5lyaoWMfC Ot9RbuxraMJx/duoaa9NZKYjUVwP9npN7GvIulUSkg== X-Google-Smtp-Source: ABdhPJzkcQbJmHIcmsSv23CmJ8pvuIgse7txYaY63YZogGKFZIVhvM5S+K8nNQYkOLgWxlGU6DrXAruX57i0Qu7+Z9s= X-Received: by 2002:ac2:5a0b:: with SMTP id q11mr327244lfn.40.1634569652473; Mon, 18 Oct 2021 08:07:32 -0700 (PDT) MIME-Version: 1.0 References: <9d10df01-0127-fb40-81c3-cc53c9733c3e@virtuozzo.com> <6b751abe-aa52-d1d8-2631-ec471975cc3a@virtuozzo.com> <27dc0c49-a0d6-875b-49c6-0ef5c0cc3ac8@virtuozzo.com> In-Reply-To: From: Shakeel Butt Date: Mon, 18 Oct 2021 08:07:20 -0700 Message-ID: Subject: Re: [PATCH memcg 0/1] false global OOM triggered by memcg-limited task To: Michal Hocko Cc: Vasily Averin , Johannes Weiner , Vladimir Davydov , Andrew Morton , Roman Gushchin , Uladzislau Rezki , Vlastimil Babka , Mel Gorman , Cgroups , Linux MM , LKML , kernel@openvz.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: B00F5801A8A8 X-Stat-Signature: ft7c66mscf3w46k48dowq1u5nn8bcoqg Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=tD7pGpPf; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf06.hostedemail.com: domain of shakeelb@google.com designates 209.85.167.42 as permitted sender) smtp.mailfrom=shakeelb@google.com X-Rspamd-Server: rspam02 X-HE-Tag: 1634569653-480954 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Oct 18, 2021 at 5:27 AM Michal Hocko wrote: > > [restore the cc list] > > On Mon 18-10-21 15:14:26, Vasily Averin wrote: > > On 18.10.2021 14:53, Michal Hocko wrote: > > > On Mon 18-10-21 13:05:35, Vasily Averin wrote: > > >> On 18.10.2021 12:04, Michal Hocko wrote: > > >> Here we call try_charge_memcg() that return success and approve the allocation, > > >> however then we hit into kmem limit and fail the allocation. > > > > > > Just to make sure I understand this would be for the v1 kmem explicit > > > limit, correct? > > > > yes, I mean this limit. > > OK, thanks for the clarification. This is a known problem. Have a look > at I think we consider that one to 0158115f702b ("memcg, kmem: deprecate > kmem.limit_in_bytes"). We are reporting the deprecated and to-be removed > status since 2019 without any actual report sugested by the kernel > message. Maybe we should try and remove it and see whether that prompts > some pushback. > Yes, I think now should be the right time to take the next step for deprecation of kmem limits: https://lore.kernel.org/all/20201118175726.2453120-1-shakeelb@google.com/