From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A9F1C433DF for ; Wed, 17 Jun 2020 03:03:22 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 28C6D2073E for ; Wed, 17 Jun 2020 03:03:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="Z43V3rGp" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 28C6D2073E Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id AF9736B0007; Tue, 16 Jun 2020 23:03:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AAA2B6B0008; Tue, 16 Jun 2020 23:03:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9BEF26B000A; Tue, 16 Jun 2020 23:03:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 811A36B0007 for ; Tue, 16 Jun 2020 23:03:21 -0400 (EDT) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 071E0181AC9BF for ; Wed, 17 Jun 2020 03:03:21 +0000 (UTC) X-FDA: 76937207802.15.drop25_38124cc26e04 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin15.hostedemail.com (Postfix) with ESMTP id CEDDC1814B0C1 for ; Wed, 17 Jun 2020 03:03:20 +0000 (UTC) X-HE-Tag: drop25_38124cc26e04 X-Filterd-Recvd-Size: 4020 Received: from mail-lj1-f195.google.com (mail-lj1-f195.google.com [209.85.208.195]) by imf34.hostedemail.com (Postfix) with ESMTP for ; Wed, 17 Jun 2020 03:03:20 +0000 (UTC) Received: by mail-lj1-f195.google.com with SMTP id x18so1033167lji.1 for ; Tue, 16 Jun 2020 20:03:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=7RnSVVEnBBsu4D/UiZN7uiJr3tgDhgWeBzkH6jHbetY=; b=Z43V3rGplsGrRdtlpzG+sdV/9AWhyCvWfxGJQ+G3L1HmgWOze77eH6d7/xzS9+T1Ph gC+wUnaIb4jsER8lC++pKCCZBgIbF6c3UAmMbAxHkdBRI9FuCYf5wTyhEOMi0InlRXsr XaXL82y9JcCwIlb3kuiUI/yi7/cq8n3rEQo7WbMrmOpp/7TDIeHqZ/VeE39O/LaRjnvD e48t4+xGJRRDWsvoXb8lljGAJeYsLqoitld4NM4VJfFNN6jOfvDi2YfJI2zSprzBuN+A 8C7v4Pv8BTjB6GUEHv3Myx8BUZHFfxv0djymKr4BXvzVphg6y49l7STRyVJdOqETZoem cIsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=7RnSVVEnBBsu4D/UiZN7uiJr3tgDhgWeBzkH6jHbetY=; b=YgZJVYM/Uipdc1gIJ10vNIjL1FHbcpmdjRnORKGwdHqpQgCYP/LpR39WgTTYv+w6ZM sU6b8jjqIG/9+k1uPHHSGSWgcmJmOKfKxH21eoouh45OiqUwyOYWxmAS1S6q6d9PYEuw kzzI+e2G7+H2Iv+0avnvIba1tQsLCGwkF7X41Ly+SHD7JuXKn79nKA/Gezrzk3Ehud8h kofECJruk2d9Th+x0EUBL18pEtIU8W3THT09wmsdHKT744u0KfnW3RsMDhN/hrWuu54y FPUC14MjxESW1ExUeHV++P4ZoNG6mWH+ZZi0iMqwmjlLPlqvxe75f6jBxb+O7XJilCWF 1/GA== X-Gm-Message-State: AOAM532t8rKfUNCrQ7XpnsZSc9b+LzuWx7LeLMz4+VcImvwh9/sO9CMl MS911vkNL74D9P8K8IGzCSbG3uXZuZrEm6Mt6v/svQ== X-Google-Smtp-Source: ABdhPJxJlE0jNp92WgtycAxCuUj8SatZ+DUjVgrym603dBI9GYvoelsNyekA9VCNasLnULWjYOAOXfnGrPnXNQW5LGA= X-Received: by 2002:a2e:8754:: with SMTP id q20mr2956941ljj.270.1592362998332; Tue, 16 Jun 2020 20:03:18 -0700 (PDT) MIME-Version: 1.0 References: <20200608230654.828134-1-guro@fb.com> <20200608230654.828134-4-guro@fb.com> In-Reply-To: <20200608230654.828134-4-guro@fb.com> From: Shakeel Butt Date: Tue, 16 Jun 2020 20:03:07 -0700 Message-ID: Subject: Re: [PATCH v6 03/19] mm: memcg: convert vmstat slab counters to bytes To: Roman Gushchin Cc: Andrew Morton , Christoph Lameter , Johannes Weiner , Michal Hocko , Linux MM , Vlastimil Babka , Kernel Team , LKML Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: CEDDC1814B0C1 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam01 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jun 8, 2020 at 4:07 PM Roman Gushchin wrote: > > In order to prepare for per-object slab memory accounting, convert > NR_SLAB_RECLAIMABLE and NR_SLAB_UNRECLAIMABLE vmstat items to bytes. > > To make it obvious, rename them to NR_SLAB_RECLAIMABLE_B and > NR_SLAB_UNRECLAIMABLE_B (similar to NR_KERNEL_STACK_KB). > > Internally global and per-node counters are stored in pages, > however memcg and lruvec counters are stored in bytes. > This scheme may look weird, but only for now. As soon as slab > pages will be shared between multiple cgroups, global and > node counters will reflect the total number of slab pages. > However memcg and lruvec counters will be used for per-memcg > slab memory tracking, which will take separate kernel objects > in the account. Keeping global and node counters in pages helps > to avoid additional overhead. > > The size of slab memory shouldn't exceed 4Gb on 32-bit machines, > so it will fit into atomic_long_t we use for vmstats. > > Signed-off-by: Roman Gushchin > Acked-by: Johannes Weiner > Acked-by: Vlastimil Babka Reviewed-by: Shakeel Butt