From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B861C433EF for ; Tue, 23 Nov 2021 17:18:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8899E6B0074; Tue, 23 Nov 2021 12:17:40 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 837EE6B0075; Tue, 23 Nov 2021 12:17:40 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6FFE96B0078; Tue, 23 Nov 2021 12:17:40 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0218.hostedemail.com [216.40.44.218]) by kanga.kvack.org (Postfix) with ESMTP id 633BE6B0074 for ; Tue, 23 Nov 2021 12:17:40 -0500 (EST) Received: from smtpin29.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 219728B759 for ; Tue, 23 Nov 2021 17:17:30 +0000 (UTC) X-FDA: 78840851460.29.86287AF Received: from mail-lf1-f47.google.com (mail-lf1-f47.google.com [209.85.167.47]) by imf31.hostedemail.com (Postfix) with ESMTP id DA17B1046315 for ; Tue, 23 Nov 2021 17:17:23 +0000 (UTC) Received: by mail-lf1-f47.google.com with SMTP id l22so92515102lfg.7 for ; Tue, 23 Nov 2021 09:17:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=iRJYbAOMl4yq+oKHujSPycwNua95Irf6sHCjaFIgmNs=; b=DLxZDsA2cqPy9/18+P1387n4BSb4+l8Kz1+wHrEyjGk4+2ZcGt6Ihue86vMzQohzCH 4FAfzMdQGVi/6T8Go3oFMGK+4i3b/Z+tV2agG89gXC07jPoqbecYnVEdLPvfyG+Y1V4a alUDeEU4vUsn9IpsK1VuHVvUliV7Oq3McWIiO5msC8idRqmk4v91vglGUqSzkO3e5BIa +3u1gN7gt/656oZb5/bgH/fYkcQTytanrcDNFm1vRNIDJpX5i0XhPiUqjO6VYsrlRPko +1+N9Crdc6RQ9E2A07jJdMoi7xVhKjWp1NowhQVuXaOIyxQ6wWn2bWqKhttaaQZigNju yz2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=iRJYbAOMl4yq+oKHujSPycwNua95Irf6sHCjaFIgmNs=; b=K5stvOyktnWgN8h510wZEvNHDtTrmB7u1dfoZhi3fjC6yoqsbP58TkrPbq4OKQTD6h QePejnjFt3lhxA1nrnfcKW/YwFsL+553SqeI3mLquUB4kxIiU6n879p4FaQgSVLvZGrl cISUFx76CWKpG558A+DcLk5IPNsrkrn5C6/IzIt5+eJdD8M70QeOVSZJrJlQkfNx8Ieb I2375tPVF9Rg85dJdvwhRN4N4T4J5wLJ18BhMYKCmQ+VVW+hM0Mya3rL63DQVDvAcfcw 5yD09PjmJbdRucn1Xs6dob4Aep8VOnVdW+wSUy+ByIJokSaOEveSFMz3ZB6PQLC9I3xK EsVQ== X-Gm-Message-State: AOAM531npfYw8px6SqSFZ33GgNsxZD299nW9TOOkhCy/mKFyCQmpKeAi GIZg+40ES3ZOyV8E02+h5YyGkKZZrOoWZPYLktN8Og== X-Google-Smtp-Source: ABdhPJxDJDfdaWIdd6LYTEnc768rpM1TuoJj9qR8hKwwqHz1F8twoMwoRI4lCmNRU3mLrA/QhjUAfftSh1LFA1abbU4= X-Received: by 2002:ac2:4e02:: with SMTP id e2mr6753456lfr.264.1637687847964; Tue, 23 Nov 2021 09:17:27 -0800 (PST) MIME-Version: 1.0 References: <20211120201230.920082-1-shakeelb@google.com> <25b36a5c-5bbd-5423-0c67-05cd6c1432a7@redhat.com> <1b30d06d-f9c0-1737-13e6-2d1a7d7b8507@redhat.com> <92fe0c31-b083-28c4-d306-da8a3cd891a3@redhat.com> In-Reply-To: <92fe0c31-b083-28c4-d306-da8a3cd891a3@redhat.com> From: Shakeel Butt Date: Tue, 23 Nov 2021 09:17:16 -0800 Message-ID: Subject: Re: [PATCH] mm: split thp synchronously on MADV_DONTNEED To: David Hildenbrand Cc: "Kirill A . Shutemov" , Yang Shi , Zi Yan , Matthew Wilcox , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: DA17B1046315 X-Stat-Signature: znr5hioo78n5yytjaaeiorwf9hasepyq Authentication-Results: imf31.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=DLxZDsA2; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf31.hostedemail.com: domain of shakeelb@google.com designates 209.85.167.47 as permitted sender) smtp.mailfrom=shakeelb@google.com X-HE-Tag: 1637687843-89356 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000137, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Nov 23, 2021 at 8:57 AM David Hildenbrand wrote: > [...] > >> > >> I do wonder which these locking contexts are exactly, and if we could > >> also do the same thing on ordinary munmap -- because I assume it can be > >> similarly problematic for some applications. > > > > This is a good question regarding munmap. One main difference is > > munmap takes mmap_lock in write mode and usually performance critical > > applications avoid such operations. > > Maybe we can extend it too most page zapping, if that makes things simpler. > Do you mean doing sync THP split for most of page zapping functions (but only if that makes things simpler)?