From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 254D0C4320A for ; Thu, 29 Jul 2021 14:40:49 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B5D1D60FE7 for ; Thu, 29 Jul 2021 14:40:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org B5D1D60FE7 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 5E95F6B0036; Thu, 29 Jul 2021 10:40:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 572288D0001; Thu, 29 Jul 2021 10:40:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 43A706B006C; Thu, 29 Jul 2021 10:40:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0088.hostedemail.com [216.40.44.88]) by kanga.kvack.org (Postfix) with ESMTP id 2A3306B0036 for ; Thu, 29 Jul 2021 10:40:48 -0400 (EDT) Received: from smtpin27.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id C36F11810F5FA for ; Thu, 29 Jul 2021 14:40:47 +0000 (UTC) X-FDA: 78415886934.27.8521D14 Received: from mail-lj1-f178.google.com (mail-lj1-f178.google.com [209.85.208.178]) by imf18.hostedemail.com (Postfix) with ESMTP id 7F7524002095 for ; Thu, 29 Jul 2021 14:40:47 +0000 (UTC) Received: by mail-lj1-f178.google.com with SMTP id h9so7848659ljq.8 for ; Thu, 29 Jul 2021 07:40:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=g5bAj8ty5oGdKwNlb8K8CLCbwch75jyi8lukuavge1w=; b=Pt/myiUcp/HcWkRJqwMsshxtVCmbTMQkOHiiYTWtRrlpIQtfIwP/TshXg/Sv8sShX9 o2MFa/ULWHD9UC3jmOcqn1lmGxaT4wKLBTj9EmJNBAHOi7Q8KcOqOF0BKQN7ZPWxNCSJ XetW0whmTlm+G5aufSYRe0G9VUSjiNZ+WQeflOuu8nWflrnK9K1ff6Rd2RAu58nxE+Y6 7qbJdt29eO3qn86prpYrCpSIiyM4hC29igxet+IGxGq7kaFkObrd4BxwXuAznFdcDM9l 95jP6Xt6Saju2kAdhuCdAVe/F79H2aNR8AMySTMNEDU2FRE0HLzx6Q07o0jseAYwQdQb 9Rcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=g5bAj8ty5oGdKwNlb8K8CLCbwch75jyi8lukuavge1w=; b=cLR+LlvbvrTXR/9jTmH3tmxzN3MUOtixmUccPQTijhZ1PPXuj7vw8kVVsEVhI+bHba wWfBDiNAOOqciHja3EId7vyInRuC5s3Aedv2MpiT6MS4Bi2XWSdqyTSFLxom6w6pCAn0 z/7K/mVgXxxQ2I4XkL4LtI6JXm1yRX1jNW+KeTlgXCisOZxrEY/iBt6M2JIp3kBlJmJk dU4tVtquARhmvmyUYBcp7sys6GgNCRganHEE5rujmqUZ0untmP+SSrLo4mZ0k+MQg8Ja zExWFYmboJh1BiQdiPeJkASJjN+i6UAB/XJmyJoxYMuR6e0wJ9c8dghy11zSbRy4sFjo 79Kg== X-Gm-Message-State: AOAM531mBRTnt6vynjcF11yElbiHbIvd79JaxKYi5U9AO+vgozMI9smZ cAyWahKBJKeHm8fyIRQ4e03LzBKFVAtmBFrkK0TftQ== X-Google-Smtp-Source: ABdhPJy0WHl5s9+K9hYnC4buzSwLhc4EudrWVzNl4PYmMwFv350CnGn+D/62ehgVRJhSUPwN8mqn74ibwIDnHFvWGvY= X-Received: by 2002:a05:651c:1211:: with SMTP id i17mr3201903lja.122.1627569645751; Thu, 29 Jul 2021 07:40:45 -0700 (PDT) MIME-Version: 1.0 References: <20210729125755.16871-1-linmiaohe@huawei.com> <20210729125755.16871-4-linmiaohe@huawei.com> In-Reply-To: <20210729125755.16871-4-linmiaohe@huawei.com> From: Shakeel Butt Date: Thu, 29 Jul 2021 07:40:34 -0700 Message-ID: Subject: Re: [PATCH 3/5] mm, memcg: save some atomic ops when flush is already true To: Miaohe Lin Cc: Johannes Weiner , Michal Hocko , Vladimir Davydov , Andrew Morton , Roman Gushchin , Matthew Wilcox , alexs@kernel.org, Wei Yang , Muchun Song , Linux MM , LKML , Cgroups Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 7F7524002095 Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=google.com header.s=20161025 header.b="Pt/myiUc"; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf18.hostedemail.com: domain of shakeelb@google.com designates 209.85.208.178 as permitted sender) smtp.mailfrom=shakeelb@google.com X-Stat-Signature: ktj6kf9tgujcxq4mww7xo1tf7xer45is X-HE-Tag: 1627569647-753361 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jul 29, 2021 at 5:58 AM Miaohe Lin wrote: > > Add 'else' to save some atomic ops in obj_stock_flush_required() when > flush is already true. No functional change intended here. > > Signed-off-by: Miaohe Lin Reviewed-by: Shakeel Butt