From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 337F3C54FCC for ; Tue, 21 Apr 2020 19:13:49 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id EC12C2072D for ; Tue, 21 Apr 2020 19:13:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="bUWoO33Y" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EC12C2072D Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 86A468E0005; Tue, 21 Apr 2020 15:13:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7F3F28E0003; Tue, 21 Apr 2020 15:13:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6BA758E0005; Tue, 21 Apr 2020 15:13:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0203.hostedemail.com [216.40.44.203]) by kanga.kvack.org (Postfix) with ESMTP id 50E968E0003 for ; Tue, 21 Apr 2020 15:13:48 -0400 (EDT) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 07D16181AEF23 for ; Tue, 21 Apr 2020 19:13:48 +0000 (UTC) X-FDA: 76732811736.23.chalk06_3e3c381494b20 X-HE-Tag: chalk06_3e3c381494b20 X-Filterd-Recvd-Size: 3456 Received: from mail-lj1-f194.google.com (mail-lj1-f194.google.com [209.85.208.194]) by imf48.hostedemail.com (Postfix) with ESMTP for ; Tue, 21 Apr 2020 19:13:47 +0000 (UTC) Received: by mail-lj1-f194.google.com with SMTP id z26so15166326ljz.11 for ; Tue, 21 Apr 2020 12:13:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=a/+YOMpTdK2B7DWfew1yvduwiCraaW2/kuntapldYZ0=; b=bUWoO33YlTxWoYWiORjP3cfd0fXYcJlwyVFVKaoJXnsvHiP4GSzVRDCjxFF08py8lN 5ZUrKIqEk822Szjrlp1a4M6EooH0kyC/WpUqGiVwtSTYmjBfkxKXaIUk0OCxAPeXkyQt /6fuXhRJIF6ZD/CXoAAPg2r9Quv9ZDfp9xAv0Cx9MdvuVu74+9KjyhWDEj5qnLon4d8u nXYnLbO9ypaVJ5RXViyX+EC3kVxDVZ/QAZZ0OD1acVRZBUPXSJSR2gBVHUcVu1xrfS9Y rXdzeb62flwCVklON1DT44s3z++HTQophQ/mY77/dUZF7wNPPJZa/MEoe1DHqIarJdWt LZ4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=a/+YOMpTdK2B7DWfew1yvduwiCraaW2/kuntapldYZ0=; b=becS1R9dFk+/+nPPzaSlEjD6j9lmo4pahmh+591mjb2mhH7Eh8Sma+bBpPPHH4qQBR JX978JyWqzkJGbkrfERkqCynfmBxEF8eo6CAXUv2se5bRIMA0HKEV6v00RD/DVpwtg5J XZrPgb2fDKfEcYy4p0BVhK6DM3bvXPHOK1ymxfGNMLxbKaspzshcoh7aQQ752mrAUsvD DTJ3ZU1TfHg714SwM3DUENXVPtYvwfdr6TBuXReCAdIHgbuuXq8RAMNoA4atFCK8oHnO vXU51nkomc+d3U6QSVIIURVNdUVV+xUlZpjMQ7eKfbBkDy93EI2loj5eA6eYG4Tv3WDx fc+A== X-Gm-Message-State: AGi0PuYGmGQVXgGeH7vVZPbsXv/y60uXDQS6qLeeFFi2s/qoiQpm6yVF OHfeWgEtKt39NkQtaTgs6bWkPckPL3E3Zo1HgULgYA== X-Google-Smtp-Source: APiQypKipAK8wadINnlUb+Uo4VCJh7LWj2FEF1/+sowHcDfqmnlaXFG2Y5WcttyQhyOio2DlQGMNfqNHgxfZn6kUa2o= X-Received: by 2002:a05:651c:1209:: with SMTP id i9mr12984953lja.250.1587496425813; Tue, 21 Apr 2020 12:13:45 -0700 (PDT) MIME-Version: 1.0 References: <20200420221126.341272-1-hannes@cmpxchg.org> <20200420221126.341272-2-hannes@cmpxchg.org> In-Reply-To: <20200420221126.341272-2-hannes@cmpxchg.org> From: Shakeel Butt Date: Tue, 21 Apr 2020 12:13:34 -0700 Message-ID: Subject: Re: [PATCH 01/18] mm: fix NUMA node file count error in replace_page_cache() To: Johannes Weiner Cc: Joonsoo Kim , Alex Shi , Hugh Dickins , Michal Hocko , "Kirill A. Shutemov" , Roman Gushchin , Linux MM , Cgroups , LKML , Kernel Team Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Apr 20, 2020 at 3:11 PM Johannes Weiner wrote: > > When replacing one page with another one in the cache, we have to > decrease the file count of the old page's NUMA node and increase the > one of the new NUMA node, otherwise the old node leaks the count and > the new node eventually underflows its counter. > > Fixes: 74d609585d8b ("page cache: Add and replace pages using the XArray") > Signed-off-by: Johannes Weiner Reviewed-by: Shakeel Butt