From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3D86C433C1 for ; Fri, 19 Mar 2021 18:42:07 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6F9F561974 for ; Fri, 19 Mar 2021 18:42:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6F9F561974 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id CCF4E6B006E; Fri, 19 Mar 2021 14:42:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CA5E06B0070; Fri, 19 Mar 2021 14:42:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B6DE26B0071; Fri, 19 Mar 2021 14:42:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0091.hostedemail.com [216.40.44.91]) by kanga.kvack.org (Postfix) with ESMTP id 9D4556B006E for ; Fri, 19 Mar 2021 14:42:06 -0400 (EDT) Received: from smtpin32.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 4FD5B18019243 for ; Fri, 19 Mar 2021 18:42:06 +0000 (UTC) X-FDA: 77937493452.32.F5B497C Received: from mail-lf1-f41.google.com (mail-lf1-f41.google.com [209.85.167.41]) by imf14.hostedemail.com (Postfix) with ESMTP id 06BE3C0633E6 for ; Fri, 19 Mar 2021 18:41:56 +0000 (UTC) Received: by mail-lf1-f41.google.com with SMTP id b83so11489958lfd.11 for ; Fri, 19 Mar 2021 11:41:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=cXH+dcJq1Qlcq3WMXI8ATU9OtVilMFQ65bMjs0UMHDg=; b=TNj0S4RC7TT5fCBMitvVKqaFLnlJcsF4VguNB2RglBNykJKE60t/iViTRdbuGJSTdW Jom/CweL61c9Awm1E7Vni+jExZ6YjT0S8087YMEicMdkwhqLtAfuNv04zroDU/nWW0p2 Qg+nT/q1zls7iPv8jQD4WpC1Ms55Sx/gL1l1BiK32+aZPZSoe/n3dADP754AUvRSU5Gg XQvWAzp6B+V3hTMZ+OO7HleYi/IG3wS3/5YA1fiPCBnh9PyTjS1e/J1+/1wxiG2/axn2 gEFIdQTLmR02h7X5lHRtGj0jlQdVljlzUm0Z/hMLWRGyXDDhyr89qEuMsqxvc0o42D82 qwMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=cXH+dcJq1Qlcq3WMXI8ATU9OtVilMFQ65bMjs0UMHDg=; b=C095Etz68tcpsP4fghFV2Ul2gzH11XVrBUcMax9jywd0fzHOzkD07Riwsy8q2gKt1L BMEVvJDq5caFGRkvLLOtwYVmTSE2awSJPCMpVEK4Kl98bWeqa5Z6Ozmb6TfQf7oSBwMX XNcYTUOnqc8dvmwUA6fpLow6jE+hqP1tNQCPdPdPwE3E+EKFHwcOD6ukCNf77Lj/8Xnq 9lh3zhoPaKekEWDpXAnUlNLu57CvF8/lULmAN5b/s6X3Vxa1H0w9Xs6JpVwZqiHxHrnW D8jImMpddvwliu8qgsFhZMqhc1KsHAZqOtrqxoGAu/de4MT70o5EZruFMotbj7z+9/73 rgOQ== X-Gm-Message-State: AOAM5335oeDhrHDTuv/bHgL4sQ4B2nGHEH2JWfbNScyd2Zw2UueJHyrs vhCJbTKcSzlinufqAd8/nc0/hAaW1anV7JJgQokFXQ== X-Google-Smtp-Source: ABdhPJyrAfzmjkQYw4/g8LnPrVLlVrXyj52MFJSwFtLn0VxSQB/GR7s/IV7p/Dh+hfLKc9FbdEOXyeebzZQzD5wrKmo= X-Received: by 2002:a05:6512:b93:: with SMTP id b19mr1519816lfv.432.1616179309422; Fri, 19 Mar 2021 11:41:49 -0700 (PDT) MIME-Version: 1.0 References: <20210319163821.20704-1-songmuchun@bytedance.com> <20210319163821.20704-7-songmuchun@bytedance.com> In-Reply-To: <20210319163821.20704-7-songmuchun@bytedance.com> From: Shakeel Butt Date: Fri, 19 Mar 2021 11:41:37 -0700 Message-ID: Subject: Re: [PATCH v5 6/7] mm: memcontrol: inline __memcg_kmem_{un}charge() into obj_cgroup_{un}charge_pages() To: Muchun Song Cc: Roman Gushchin , Johannes Weiner , Michal Hocko , Andrew Morton , Vladimir Davydov , LKML , Linux MM , Xiongchun duan Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 06BE3C0633E6 X-Stat-Signature: cu1prznx5r7cgjs7ysf5e3sbhfejppaz Received-SPF: none (google.com>: No applicable sender policy available) receiver=imf14; identity=mailfrom; envelope-from=""; helo=mail-lf1-f41.google.com; client-ip=209.85.167.41 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1616179316-562591 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Mar 19, 2021 at 9:39 AM Muchun Song wrote: > > There is only one user of __memcg_kmem_charge(), so manually inline > __memcg_kmem_charge() to obj_cgroup_charge_pages(). Similarly manually > inline __memcg_kmem_uncharge() into obj_cgroup_uncharge_pages() and > call obj_cgroup_uncharge_pages() in obj_cgroup_release(). > > This is just code cleanup without any functionality changes. > > Signed-off-by: Muchun Song Reviewed-by: Shakeel Butt