From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87760C433DB for ; Wed, 13 Jan 2021 00:18:59 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3E9892312F for ; Wed, 13 Jan 2021 00:18:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3E9892312F Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C091E6B012E; Tue, 12 Jan 2021 19:18:58 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BB9E36B0130; Tue, 12 Jan 2021 19:18:58 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AD1256B0131; Tue, 12 Jan 2021 19:18:58 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0098.hostedemail.com [216.40.44.98]) by kanga.kvack.org (Postfix) with ESMTP id 96C706B012E for ; Tue, 12 Jan 2021 19:18:58 -0500 (EST) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 5F8AA1EE6 for ; Wed, 13 Jan 2021 00:18:58 +0000 (UTC) X-FDA: 77698841556.16.shake83_1a0695a27519 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin16.hostedemail.com (Postfix) with ESMTP id 3790E100E690C for ; Wed, 13 Jan 2021 00:18:58 +0000 (UTC) X-HE-Tag: shake83_1a0695a27519 X-Filterd-Recvd-Size: 3784 Received: from mail-lj1-f172.google.com (mail-lj1-f172.google.com [209.85.208.172]) by imf01.hostedemail.com (Postfix) with ESMTP for ; Wed, 13 Jan 2021 00:18:57 +0000 (UTC) Received: by mail-lj1-f172.google.com with SMTP id y22so543695ljn.9 for ; Tue, 12 Jan 2021 16:18:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=xDSBLu/dQ/DU7FQZj8b6YPh8lI8akCH+mH01uvaPees=; b=oKYBO4SPdgSBJUsDMIW5CP9v8Ehx9/bCarB8oGP/mHA4+sLd3xf01hYN8meRfn3Z/C VRExJAQITYqEfrJHkfEK/+BUy2bi9V125dcXdPXwnGIrz1gChJ8Eagc6sfu5NxDOsM7Q s4JHrGiTwBj0egpN48LNdJhwOkgrQljcrnDdfzV8s4tuYkxOP5J3ifDaVQItl+uBWKRi hjaQ04uwbDzWLPPYGOzdK8OrUuidnmRBgEslg8HxcWMOGc+R2HncERyeNHOejDUAcGLp U6ugLoGlBW/HnCUEp1wdREM2Q0knqc9CwXOGdVRuSBw5YniV+N1wwskoAEZ2xBEOuVvD 3xUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=xDSBLu/dQ/DU7FQZj8b6YPh8lI8akCH+mH01uvaPees=; b=Shhlr3J4q4MFQU8mpJPvxQNeOPhSEDcsCvuIe/kKmz8iAfvx1XiP8NCJY7WOHRfJWA FqO3eulAK2EhobcUXFu6tMAt4X+/6F4PzqNhAGfC9eDT9K924hlTQhiXUrvv+4NPWa8B mCq/N+hs7YqvbkVRA1ZDNseUFa3p5tOOYmmV2Y6R2GeYAt9GF8cIz82qF45J5Mz+F6lb iVg7h9MTU2mNkplYtuGJI0Hxe4M84gUo9gZJi8hKHizXIQ2Czy3APLMVZEHawkwYoVBo 41IxtGs9CcGdbyhD4HuH5ZnCcK7QhKraqM3vMg9llqh53OZ5/sc0+FEKa7gU4DVpbBQr axhA== X-Gm-Message-State: AOAM531rQrv58r6CM8FNTOiGGhTJTCiqcg9/kp6Fg8I8vJdSI6GqqmoR WMOQf4/11XREs0Fy+E9LHNciAoI4N5d2bEyP7+64oA== X-Google-Smtp-Source: ABdhPJzLMkGXD6keBgkD1QE7S34ntTTrgx2rICPfCSovNaFVK6UFbwtZ7AQr2ENR3QwGr5QWxwVbsZua9hjphAbv6aQ= X-Received: by 2002:a2e:9a84:: with SMTP id p4mr715148lji.160.1610497136091; Tue, 12 Jan 2021 16:18:56 -0800 (PST) MIME-Version: 1.0 References: <20210112214105.1440932-1-shakeelb@google.com> <20210112233108.GD99586@carbon.dhcp.thefacebook.com> <20210112234822.GA134064@carbon.dhcp.thefacebook.com> In-Reply-To: From: Shakeel Butt Date: Tue, 12 Jan 2021 16:18:44 -0800 Message-ID: Subject: Re: [PATCH] mm: net: memcg accounting for TCP rx zerocopy To: Arjun Roy Cc: Roman Gushchin , Johannes Weiner , Michal Hocko , Eric Dumazet , Andrew Morton , "David S . Miller" , Jakub Kicinski , Linux MM , Cgroups , netdev , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jan 12, 2021 at 4:12 PM Arjun Roy wrote: > > On Tue, Jan 12, 2021 at 3:48 PM Roman Gushchin wrote: > > [snip] > > Historically we have a corresponding vmstat counter to each charged page. > > It helps with finding accounting/stastistics issues: we can check that > > memory.current ~= anon + file + sock + slab + percpu + stack. > > It would be nice to preserve such ability. > > > > Perhaps one option would be to have it count as a file page, or have a > new category. > Oh these are actually already accounted for in NR_FILE_MAPPED.