From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB9ECC433E0 for ; Mon, 8 Feb 2021 02:28:52 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 79C1D64E37 for ; Mon, 8 Feb 2021 02:28:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 79C1D64E37 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id D029D6B006C; Sun, 7 Feb 2021 21:28:51 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CB2CC6B006E; Sun, 7 Feb 2021 21:28:51 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BA1AF6B0070; Sun, 7 Feb 2021 21:28:51 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0246.hostedemail.com [216.40.44.246]) by kanga.kvack.org (Postfix) with ESMTP id A42226B006C for ; Sun, 7 Feb 2021 21:28:51 -0500 (EST) Received: from smtpin07.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 682321EE6 for ; Mon, 8 Feb 2021 02:28:51 +0000 (UTC) X-FDA: 77793517662.07.tree52_2a11266275fb Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin07.hostedemail.com (Postfix) with ESMTP id 459F51803F9AA for ; Mon, 8 Feb 2021 02:28:51 +0000 (UTC) X-HE-Tag: tree52_2a11266275fb X-Filterd-Recvd-Size: 3441 Received: from mail-lj1-f175.google.com (mail-lj1-f175.google.com [209.85.208.175]) by imf46.hostedemail.com (Postfix) with ESMTP for ; Mon, 8 Feb 2021 02:28:50 +0000 (UTC) Received: by mail-lj1-f175.google.com with SMTP id s18so15125537ljg.7 for ; Sun, 07 Feb 2021 18:28:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=prVjlOxJgxegYr5WyW9Puejur2UOLsJUAHlf/hcHxi4=; b=P3vCF0PGHm1O1esy5AM5oRBJYOvhkYL9KaghBGfStowxVodRdE6aeYoKVs07gQqCRV /KDTE5iE1GBcC277I9pstoXCyEU29eULNB63ExV6UmFLrRdZgK8cat9bk3XBYQWEqBKZ /u53kzhG9DHRjLKqrk6f1wV8sTD2D+qeNK6tUSVqb8+zFZWF61kH4Xc8fRs9lLv3r3MI 6HdoVrX+/2iVx51pPmhaEOfLaGjMlZY73hR6+llJr0bs/KK4S8dT42noXnH9cMoNKDav oH6zlOgD5ZCAqGqOIFzXdtV42/msvCRIF4YGwFet67mFYidyVgIrsOpZ9fhTmaF0qdpd wr1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=prVjlOxJgxegYr5WyW9Puejur2UOLsJUAHlf/hcHxi4=; b=JbcJhnfo1w4V3YTKdlqudKKdbR27Tb2zpWDWEnepFiAB0TclS5MSxjA7eavTRtBUCA 034W2t3A0EM+BCQyFWP04Hu/aCOvEoPks7zRNDo/9+yQ59S/aGmuAhV2BKlfKM74Y3Ck CgLTWWv1fQkWhE8MXbdoB4+w2Y1dUISGIUE6FvILXfe7fAKueTZ5U/oGpxYHe3mA81W8 ct6X41IG4yHEGcuDZmsUTCi1cBjjhJi4+COGm1HrY/K91HJYvNUzWkEXu4iWudxxnFX8 OK5uHgLLwcIUamV0hDM7Z0urLCO17rei5vzTHSglUUwzVfapKLHfsHDfOyS82WVXqcfs XQ8Q== X-Gm-Message-State: AOAM530hnmM2IxXZ05sDJUSPsOrwrzDEwOxG/fJHUg5hhav6Ma3nLC6B T+eH+i93uIBY8i2UtoPq/fZi/QYF+s3L/ujcys2OWQ== X-Google-Smtp-Source: ABdhPJyR2XSql3j3ajSmpY3/49a+HuQOKrA+Qf06VGVaO4rMyCBZU/zvyKPc/CticUgxxzDHes9zb693NtXnPSTSvbw= X-Received: by 2002:a2e:9801:: with SMTP id a1mr10029568ljj.122.1612751329278; Sun, 07 Feb 2021 18:28:49 -0800 (PST) MIME-Version: 1.0 References: <20210205182806.17220-1-hannes@cmpxchg.org> <20210205182806.17220-8-hannes@cmpxchg.org> In-Reply-To: <20210205182806.17220-8-hannes@cmpxchg.org> From: Shakeel Butt Date: Sun, 7 Feb 2021 18:28:37 -0800 Message-ID: Subject: Re: [PATCH 7/8] mm: memcontrol: consolidate lruvec stat flushing To: Johannes Weiner Cc: Andrew Morton , Tejun Heo , Michal Hocko , Roman Gushchin , Linux MM , Cgroups , LKML , Kernel Team Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Feb 5, 2021 at 10:28 AM Johannes Weiner wrote: > > There are two functions to flush the per-cpu data of an lruvec into > the rest of the cgroup tree: when the cgroup is being freed, and when > a CPU disappears during hotplug. The difference is whether all CPUs or > just one is being collected, but the rest of the flushing code is the > same. Merge them into one function and share the common code. > > Signed-off-by: Johannes Weiner Reviewed-by: Shakeel Butt BTW what about the lruvec stats? Why not convert them to rstat as well?