From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99FC9C433E0 for ; Wed, 10 Feb 2021 14:19:49 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2608564E6F for ; Wed, 10 Feb 2021 14:19:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2608564E6F Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id AAB0F6B0006; Wed, 10 Feb 2021 09:19:48 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A5B416B006C; Wed, 10 Feb 2021 09:19:48 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 94A796B006E; Wed, 10 Feb 2021 09:19:48 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0142.hostedemail.com [216.40.44.142]) by kanga.kvack.org (Postfix) with ESMTP id 80A396B0006 for ; Wed, 10 Feb 2021 09:19:48 -0500 (EST) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 521BF1AB77 for ; Wed, 10 Feb 2021 14:19:48 +0000 (UTC) X-FDA: 77802566856.24.skirt64_4b174cc27610 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin24.hostedemail.com (Postfix) with ESMTP id 358571AB60 for ; Wed, 10 Feb 2021 14:19:48 +0000 (UTC) X-HE-Tag: skirt64_4b174cc27610 X-Filterd-Recvd-Size: 3617 Received: from mail-lj1-f175.google.com (mail-lj1-f175.google.com [209.85.208.175]) by imf09.hostedemail.com (Postfix) with ESMTP for ; Wed, 10 Feb 2021 14:19:47 +0000 (UTC) Received: by mail-lj1-f175.google.com with SMTP id s18so3032524ljg.7 for ; Wed, 10 Feb 2021 06:19:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=STanyo0VxqectlsIzMPDjmIhDAwFO8ShwKQAZIMHAJ8=; b=JJVIO8cTw0DZ7TaBIt9ZD/qu+pTbwmSPSxu3ZJtHq1HYVFkYlnvumMMA6oQOCsCnxy DBWFDzx8MQqA1M1aqWSA2E94JTTCiXpkqFB/z+J6GMfHWF9rQQlyzwSjmBvp9fQGi06T 3DfnG8GC8iCIuKLidmGvDyhrs9Fz9AHI/eAeUzpKFcsMJ5POyJT5tudlakqmdm30sBuZ TVfg5KqdzEozPxuVerAvCYuvBE0RUf9XzhSkm+oNX86BRPdXpNDprDI9dutzfQK1pILf hjDMhaGqKnI2Njmb1uT9fhTQ2kLt3Y49uNlsDdeBzeiOKYuE/ixIjrIvIj6jJKhVqJU9 +njQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=STanyo0VxqectlsIzMPDjmIhDAwFO8ShwKQAZIMHAJ8=; b=t1r0OrOdyWPlVf3coRk0+ga0IQwSm5AtDL1z9cXatZePptcHwTI9RKoCmR7wyNXSmx 5D6nd3YXu0ZeJInCg05V5neTqb235CfCsDQT/IlH9kwHhXpNjTrlAit25eLC8Va6IzFZ BU80M+SUyfkjr91JPZbpP4ZaRstpbXXpW9ecVvDx4qp5PbQ+zzycLbIKCNpp35sS1dfq O4wQPwHB09EqYP/9nc8/8AXWQtJhjV1KSnQSXXYS2E772cwc2ohLwXy6l0YNFeaVppfv amL77VvMTPXS90L8hSP4QLlyF5o92ghYdD32zECXqp4+rhgiQc+R5lz22vCkMHrrPKaf PcMg== X-Gm-Message-State: AOAM530AkdYehV2+ea2U1cmxZHy2pRgoFyBrIpHdhLM3RWQcRLAM6bGF cZgMY5On1N8RM3dj104i3cIA3RCTLP3eLrgKCrRD4A== X-Google-Smtp-Source: ABdhPJxMnEHrTizG5GfHfjzb+C5dLVyw57d8HYLUk3hc88l0K4uvHzlXl2BcBR+I9W7Kk6l3XwqVEzjhJe/BNkWaUmM= X-Received: by 2002:a2e:9801:: with SMTP id a1mr2227628ljj.122.1612966786152; Wed, 10 Feb 2021 06:19:46 -0800 (PST) MIME-Version: 1.0 References: <20210209174646.1310591-1-shy828301@gmail.com> <20210209174646.1310591-3-shy828301@gmail.com> In-Reply-To: <20210209174646.1310591-3-shy828301@gmail.com> From: Shakeel Butt Date: Wed, 10 Feb 2021 06:19:35 -0800 Message-ID: Subject: Re: [v7 PATCH 02/12] mm: vmscan: consolidate shrinker_maps handling code To: Yang Shi Cc: Roman Gushchin , Kirill Tkhai , Vlastimil Babka , Dave Chinner , Johannes Weiner , Michal Hocko , Andrew Morton , Linux MM , linux-fsdevel , LKML Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Feb 9, 2021 at 9:47 AM Yang Shi wrote: > > The shrinker map management is not purely memcg specific, it is at the intersection > between memory cgroup and shrinkers. It's allocation and assignment of a structure, > and the only memcg bit is the map is being stored in a memcg structure. So move the > shrinker_maps handling code into vmscan.c for tighter integration with shrinker code, > and remove the "memcg_" prefix. There is no functional change. > > Acked-by: Vlastimil Babka > Acked-by: Kirill Tkhai > Signed-off-by: Yang Shi Reviewed-by: Shakeel Butt