From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0DCF3C433E0 for ; Wed, 17 Jun 2020 03:05:54 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id BD1472082E for ; Wed, 17 Jun 2020 03:05:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="opcJEqdq" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BD1472082E Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 57A546B0007; Tue, 16 Jun 2020 23:05:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 52B846B0008; Tue, 16 Jun 2020 23:05:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 440686B000A; Tue, 16 Jun 2020 23:05:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0236.hostedemail.com [216.40.44.236]) by kanga.kvack.org (Postfix) with ESMTP id 2FE166B0007 for ; Tue, 16 Jun 2020 23:05:53 -0400 (EDT) Received: from smtpin14.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 91AC21EE6 for ; Wed, 17 Jun 2020 03:05:52 +0000 (UTC) X-FDA: 76937214144.14.key70_4d0deb726e04 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin14.hostedemail.com (Postfix) with ESMTP id 6CE1D18229818 for ; Wed, 17 Jun 2020 03:05:52 +0000 (UTC) X-HE-Tag: key70_4d0deb726e04 X-Filterd-Recvd-Size: 3565 Received: from mail-lj1-f193.google.com (mail-lj1-f193.google.com [209.85.208.193]) by imf18.hostedemail.com (Postfix) with ESMTP for ; Wed, 17 Jun 2020 03:05:51 +0000 (UTC) Received: by mail-lj1-f193.google.com with SMTP id i3so1030639ljg.3 for ; Tue, 16 Jun 2020 20:05:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=tQx8E/fB3k29lyIQ38d8XnedyxWcLShKOFMHcE8vB1Q=; b=opcJEqdqdKrRLwNOEgXE+/VJFQOuvOpk+ey32Q6SBcm876qMXsBjwbTgbhOK5acdSh cV5AmOUj1y1k3NmLM4+bqr3wtrh74f8Ac6u6UEBm+8YHixwc8lK6jkr95aN9tAT7XHXg R9SN2gzPZO4/abwtjG1aMYs74ftgPXqYbMMqsnDPyWq+W5rxRiYysGIa0gAE7qVNliUo 2HmEssQz0XgQW+IQeaRqpmePHNjP2fBzFdeGEWkEaFJ0W6SmAXbQdQXF/hOH8uTl/UWk Is4oxxrhgYVh5x4iATLKwfDT4K+54sdGm4aUSSudzT46352RORBCv+ay7vG7rvewcK16 A37Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=tQx8E/fB3k29lyIQ38d8XnedyxWcLShKOFMHcE8vB1Q=; b=rxaWhHLoWNg6tueoStN5F2Fv+pRdMr4lzTK05Af6T+h/s6MYocNY5iPyoifsoHyaOr ItDmvrXHDuMbRkvqZIYRRC261M46+Febdt8SARSkbNTD1GOydkRbYK8lkVwBVrV5YAps fiXoidRJuEshTM8mSG8XlV/Rd07pxpOaJE9GQaD+RWEbU94uWNWOwYh9KbgynZo+rrdp lzzGm0WxxZVyW0lPVcRuKYIVAGszReIc6x8wbhYzzy2yPAu6M7f0vPCOccngHKZXkC1r biHea0M/tRDWuwDUfXOqOAmi+j0fALuWOPXktrCYM3ClvRQmoxJ8QQM0VK8vzmpIhwJ3 gOKg== X-Gm-Message-State: AOAM533BjvCCEQW7sF2Shuw8J8fQ2AVgiKb3mkNPaaki88BaUutn2vzP KHlPk52pfkBwaTZsFILpDdKAwKCii2UXsm0Jz2fDyQ== X-Google-Smtp-Source: ABdhPJzg35tT8uYQ9Br0aeQHkR+wNCa2X7Tul4YFymy+TjNnZEQjHWKVv1JhrHhCDG4J7heNuJY2c9s7DEVWLpkPZiU= X-Received: by 2002:a2e:960b:: with SMTP id v11mr2874001ljh.77.1592363150545; Tue, 16 Jun 2020 20:05:50 -0700 (PDT) MIME-Version: 1.0 References: <20200608230654.828134-1-guro@fb.com> <20200617024147.GA10812@carbon.lan> In-Reply-To: <20200617024147.GA10812@carbon.lan> From: Shakeel Butt Date: Tue, 16 Jun 2020 20:05:39 -0700 Message-ID: Subject: Re: [PATCH v6 00/19] The new cgroup slab memory controller To: Roman Gushchin Cc: Andrew Morton , Christoph Lameter , Johannes Weiner , Michal Hocko , Linux MM , Vlastimil Babka , Kernel Team , LKML Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 6CE1D18229818 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam01 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jun 16, 2020 at 7:41 PM Roman Gushchin wrote: > > On Tue, Jun 16, 2020 at 06:46:56PM -0700, Shakeel Butt wrote: > > On Mon, Jun 8, 2020 at 4:07 PM Roman Gushchin wrote: > > > [...] > > > > Have you performed any [perf] testing on SLAB with this patchset? > > The accounting part is the same for SLAB and SLUB, so there should be no > significant difference. I've checked that it compiles, boots and passes > kselftests. And that memory savings are there. > What about performance? Also you mentioned that sharing kmem-cache between accounted and non-accounted can have additional overhead. Any difference between SLAB and SLUB for such a case?