From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52AF3C433EF for ; Thu, 25 Nov 2021 17:15:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B292D6B0074; Thu, 25 Nov 2021 12:14:54 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AD8176B0075; Thu, 25 Nov 2021 12:14:54 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9A0536B0078; Thu, 25 Nov 2021 12:14:54 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0081.hostedemail.com [216.40.44.81]) by kanga.kvack.org (Postfix) with ESMTP id 8AA506B0074 for ; Thu, 25 Nov 2021 12:14:54 -0500 (EST) Received: from smtpin27.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 4E30B184B83CB for ; Thu, 25 Nov 2021 17:14:44 +0000 (UTC) X-FDA: 78848102004.27.32915BF Received: from mail-lf1-f54.google.com (mail-lf1-f54.google.com [209.85.167.54]) by imf15.hostedemail.com (Postfix) with ESMTP id 01031D0000A3 for ; Thu, 25 Nov 2021 17:14:38 +0000 (UTC) Received: by mail-lf1-f54.google.com with SMTP id t26so17887802lfk.9 for ; Thu, 25 Nov 2021 09:14:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=+4bw++geKzggzEo+/4ZRu2MQsYbbAkbBIfq6b5JxF0s=; b=seinNde8Pld/Lxgy1oZgDrIbJIQ4AdF3GzjG+yKQ5OjYANP+s4qsGAg/sid3k2G/Qq qlvp5Bbrg5slnuK8pCoDzZb0pKaqPsNjh/N7glo7ZiOuFzg2BxUeaJB/5v9G5+ggaXMM 99jUghOJG5KtKZaLkUU9iF4W1/mrlbcVPHaQAlL0swrwybwXjtvqDiZkz41WBFnT6xtp nKwqzHC1uMmQpv83xCrASc73KRGjzQt06yBTJw9zUMGUOT6obeDvdD6fQeSwvrcwNvDI iZpZukviJmJUuq5Cg3ug4VxznTVCRd0ftt7JX8TOOXXQcFpXs1wVrcuKFcszMs4zPADO vs3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+4bw++geKzggzEo+/4ZRu2MQsYbbAkbBIfq6b5JxF0s=; b=C/QgkXj5/Tj0+fSIL65QrBmd5zTx4ydpnLhhy20tXlyml0kAN0SkJmJSrmsIiUy4Qt t9EhUyaZGb3MYSwqoNpH5Zd+AcBy/A7p+vsPOLYLgJAX1m+EJqNOgqIEfO/BMGcqGLhA m/G9hKrEenDtpHjPc4Xav72paoie92Tg+Le/GL9WPpoAP5ad6IoOJoKx5ScjOPBdCY6U F5xsvQRFACpD4/T718IXTjy8rk7+5EIPjUyFEPp+IIgcTmVQVqZWZUhi6kLm2LMe1C4f CA3am864rgcGVa9/MsGigK1wXXzg3OsFQsskGuLj6vN8Cj2p4rl/H7eBCzkj0ldIyKiI Rnbw== X-Gm-Message-State: AOAM533lSHv8or48au3m0q+tmjPN42r9JpELA6aawqm6omGfsBqlEVwG wjPCbCClD+gZvl9tvM8kZ93kYUzodr79oN8MSrzmYA== X-Google-Smtp-Source: ABdhPJzhnqN3fgnk04ujllRzvLeZSR5igv8VPqeJoJG0Z1Ew1/+FQe4/pVRQWRKEbXtY7AZoF0QCAgVnBypeTdWXYHg= X-Received: by 2002:a19:6412:: with SMTP id y18mr25444303lfb.494.1637860482082; Thu, 25 Nov 2021 09:14:42 -0800 (PST) MIME-Version: 1.0 References: <25b36a5c-5bbd-5423-0c67-05cd6c1432a7@redhat.com> <1b30d06d-f9c0-1737-13e6-2d1a7d7b8507@redhat.com> <92fe0c31-b083-28c4-d306-da8a3cd891a3@redhat.com> <1b400921-8bef-8073-10f9-a7cbb09cfefe@redhat.com> In-Reply-To: From: Shakeel Butt Date: Thu, 25 Nov 2021 09:14:30 -0800 Message-ID: Subject: Re: [PATCH] mm: split thp synchronously on MADV_DONTNEED To: Peter Xu Cc: David Hildenbrand , "Kirill A . Shutemov" , Yang Shi , Zi Yan , Matthew Wilcox , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 01031D0000A3 X-Stat-Signature: os7ragojmr8piq3pg6zk8aghjxyxbxos Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=seinNde8; spf=pass (imf15.hostedemail.com: domain of shakeelb@google.com designates 209.85.167.54 as permitted sender) smtp.mailfrom=shakeelb@google.com; dmarc=pass (policy=reject) header.from=google.com X-HE-Tag: 1637860478-724315 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Nov 25, 2021 at 2:09 AM Peter Xu wrote: > [...] > > Hi, Shakeel, > > I saw your v2 has started to pass in zap_details, then we need know the side > effect on that skip-swap-entry thing because with your v2 code munmap() will > start to skip swap entry too (while it was not before). > > I saw that you didn't mention this in v2 patch either in commit message or > code, not sure whether you digged that up. I think it needs some double check > (or feel free to start this digging by reviewing my small patch above :). > I remember mentioning in the patch that this has dependency on your rfc patch. Just checked again and yeah I only mentioned in the 'changes since v1' section. I will add it more explicitly in the following versions. I will take a close look at your patch as well.