From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17876C433E0 for ; Mon, 15 Mar 2021 16:30:55 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 990A964F2A for ; Mon, 15 Mar 2021 16:30:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 990A964F2A Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 150C16B0070; Mon, 15 Mar 2021 12:30:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0DA956B0071; Mon, 15 Mar 2021 12:30:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EBDB36B0072; Mon, 15 Mar 2021 12:30:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0028.hostedemail.com [216.40.44.28]) by kanga.kvack.org (Postfix) with ESMTP id CD9666B0070 for ; Mon, 15 Mar 2021 12:30:53 -0400 (EDT) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 7E821180AD820 for ; Mon, 15 Mar 2021 16:30:53 +0000 (UTC) X-FDA: 77922647586.01.E100FF6 Received: from mail-lf1-f42.google.com (mail-lf1-f42.google.com [209.85.167.42]) by imf09.hostedemail.com (Postfix) with ESMTP id A59EC604400D for ; Mon, 15 Mar 2021 15:57:03 +0000 (UTC) Received: by mail-lf1-f42.google.com with SMTP id t18so9876822lfl.3 for ; Mon, 15 Mar 2021 08:57:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=QW3CaHPgPmHox0WmReW9hgPm5r4PklZYtPsrifaA0GA=; b=GjZCh6DFUHNU5yqp7BNiRmI5nNX7N06Cc8wlYDtW8nKcoLEQzliJpSJ0DNTWm7s5UQ OzI2H8rAP9fv6MJpkYit3y/f0XFYxBLyIXnpKCebIFhfyktgK8dZPqGym6ea4aVDL6Kt DxtRQD1wI/o0Oomu+p7cLF4egVxRsePMBgwr9wBG84sD8Lhxumbb0mx0zn9qSiH/qsmX V2Zb7Jn3ycpIGJLBNPdmAJDPohqgDpY1STomDkQzSSaVarcjO9KKT/Ol98VlrRn3U5fE Y1eNX+Q6GCCFYj3qC4KWyfVnypYssQIpMgwsMMSyLLsTEdtpPQxZxp7QLTHARscwqB+x 4lUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=QW3CaHPgPmHox0WmReW9hgPm5r4PklZYtPsrifaA0GA=; b=cwFz1dDmvibt3o9617QR32TJk9qSuh8/IYzoTRbJN+7lo1ckYnoAFo/vc60GVISQwl v6MA0lRfY4NdnfTQYElK1wca4j/1DKPKiUyZbt86xptc9Ti4s4768PB+ervlVvT+NPRs HC1E/wk0N+hZFVuOAJWFTPGJ+ay4D0u/5cg0UdrdKQdxdWiTghkPwY7HdT5hdWuv/QRq 5wCkLxrwEPZPmW0bBF6CSsjtzHY3t6NPzlPY2AEdTLQFJCydKopyfTJQtyCEBm6FlLV4 4uZD1CiM6rqnTvt2skHIw/iKl8IYuLPjdQwyJ+Lrg4msmmXoc15/PwdFR5q4krXkUpZl Hvog== X-Gm-Message-State: AOAM530vLdqhUO5zcozarGzXl1VVX2M/IAvWPDCcn2qEVFxKsWYJ4tVr YK40pR1/dS4MG5ycOGp4Xembouyr4Ia3+mBD6MN0jA/uQvQ= X-Google-Smtp-Source: ABdhPJy0jNIfa3zLOBc0wUD7xD0zn5VCZOlhbzQrXApUIgPNIRQDwI4XWU1HTffe3ikaoAArI+GDjuW2XtpF+EarLPs= X-Received: by 2002:a19:c14a:: with SMTP id r71mr8196489lff.358.1615823821848; Mon, 15 Mar 2021 08:57:01 -0700 (PDT) MIME-Version: 1.0 References: <4eb97c88-b87c-6f6e-3960-b1a61b46d380@virtuozzo.com> In-Reply-To: <4eb97c88-b87c-6f6e-3960-b1a61b46d380@virtuozzo.com> From: Shakeel Butt Date: Mon, 15 Mar 2021 08:56:50 -0700 Message-ID: Subject: Re: [PATCH v2 5/8] memcg: accounting for fasync_cache To: Vasily Averin Cc: Cgroups , Michal Hocko , Linux MM , Johannes Weiner , Vladimir Davydov , Jeff Layton , "J. Bruce Fields" , Alexander Viro Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: A59EC604400D X-Stat-Signature: bxoemb5wse5xnont1opnakkppmggqzbr Received-SPF: none (google.com>: No applicable sender policy available) receiver=imf09; identity=mailfrom; envelope-from=""; helo=mail-lf1-f42.google.com; client-ip=209.85.167.42 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1615823823-357998 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Mar 15, 2021 at 5:23 AM Vasily Averin wrote: > > unprivileged user inside memcg-limited container can trigger > creation of huge number of non-accounted fasync_struct objects You need to make each patch of this series self-contained by including the motivation behind the series (just one or two sentences). For example, for this patch include what's the potential impact of these huge numbers of unaccounted fasync_struct objects? > --- > fs/fcntl.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/fs/fcntl.c b/fs/fcntl.c > index dfc72f1..7941559 100644 > --- a/fs/fcntl.c > +++ b/fs/fcntl.c > @@ -1049,7 +1049,8 @@ static int __init fcntl_init(void) > __FMODE_EXEC | __FMODE_NONOTIFY)); > > fasync_cache = kmem_cache_create("fasync_cache", > - sizeof(struct fasync_struct), 0, SLAB_PANIC, NULL); > + sizeof(struct fasync_struct), 0, > + SLAB_PANIC | SLAB_ACCOUNT, NULL); > return 0; > } > > -- > 1.8.3.1 >