From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.6 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A697C433DF for ; Wed, 24 Jun 2020 01:36:07 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 389312137B for ; Wed, 24 Jun 2020 01:36:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="Gq7KSZM3" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 389312137B Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 9001C6B0002; Tue, 23 Jun 2020 21:36:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8B0E06B0003; Tue, 23 Jun 2020 21:36:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 79FAC6B0005; Tue, 23 Jun 2020 21:36:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0047.hostedemail.com [216.40.44.47]) by kanga.kvack.org (Postfix) with ESMTP id 627416B0002 for ; Tue, 23 Jun 2020 21:36:06 -0400 (EDT) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id D67A8180AD83A for ; Wed, 24 Jun 2020 01:36:05 +0000 (UTC) X-FDA: 76962389490.12.frogs29_261691c26e40 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin12.hostedemail.com (Postfix) with ESMTP id AA04C18005A7C for ; Wed, 24 Jun 2020 01:36:05 +0000 (UTC) X-HE-Tag: frogs29_261691c26e40 X-Filterd-Recvd-Size: 3565 Received: from mail-lj1-f193.google.com (mail-lj1-f193.google.com [209.85.208.193]) by imf23.hostedemail.com (Postfix) with ESMTP for ; Wed, 24 Jun 2020 01:36:05 +0000 (UTC) Received: by mail-lj1-f193.google.com with SMTP id i3so748077ljg.3 for ; Tue, 23 Jun 2020 18:36:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=7pIjJ2I8CWHvSXRl5P0nw8Gdno7bPM7de/tvxRqaCFg=; b=Gq7KSZM381qbz0Jl+qP97fH800pxovHxWOnBpx1iufZGWbLoRKOjcozMUvJtqM+su/ W2721W4kzQuK5yyfLxMtbvTi/uPJU39TMmSiqYJWbPmdZyeXBaPjxDSnZF6QrPYn4UqS YYBSmjmnZU0pambP/0j27dtj3ivrt2l6jNoApO/6mxarXJ56iV4Cxu+dFQucHzlDWw3k /Y/OsKJJZC8c0A3sqKAneGqGwV4Z3qxgV72+4XLPZXuDr3Y9N8IrfX5V+yB/E1tnV0DD U9R9/7/ckT/5oa0aLN+AO6APOmPbQVus8sgCjIijuyu2pM74TAT8Y8WFSlO3j9txsFF1 TRIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=7pIjJ2I8CWHvSXRl5P0nw8Gdno7bPM7de/tvxRqaCFg=; b=JOxpJmHzsqHXT+jQVOLoTCw1WlVQTV+ZSFYHpVp/ZpQIGVCf/RF35gxVq/f92uTLYE SnGwEQJoPaBymYVfaN51zI4km2DMHidp09zm71gUJ3e4lSMILcJbfkLucE6pzZMhiJ8w 9brdDk4aI/g/nBEqffsEKUq8er60fqhHWZOnMaeuP+kMMpt7MTVmtlU4s4SelqeVi9DY u6W9KnoMgGmxGhsC6uprSIeaoaJjeEiw565C68wYOhVmPlyJwEogKnJlLnBw5aVSGEom Ryw/ZXtHd2RyljhYqLTkWcG3hZpZs7RTAl+xK1o8itmpTC9TTbCXyxKbfazQ6y4rsfLV xTww== X-Gm-Message-State: AOAM530hiX9huNO+rhIXM/zcloMI844RkGVfXbyNwkBkRqygC6oH6PQl eRETEQd2AaUfp0V4FlwPV/ZXmLRNsYCJZ7O1jMt+XA== X-Google-Smtp-Source: ABdhPJyX/XZZ07bjXY9YxEuQSJag1qcS/Wpx/76xl21f5ldw4T6ZWTcEtT5g+hMU8xIso2qD2sPVP4AO57c3Qyr347k= X-Received: by 2002:a2e:9395:: with SMTP id g21mr11389976ljh.58.1592962563653; Tue, 23 Jun 2020 18:36:03 -0700 (PDT) MIME-Version: 1.0 References: <20200623184515.4132564-1-guro@fb.com> <20200623184515.4132564-4-guro@fb.com> In-Reply-To: <20200623184515.4132564-4-guro@fb.com> From: Shakeel Butt Date: Tue, 23 Jun 2020 18:35:52 -0700 Message-ID: Subject: Re: [PATCH v3 3/5] mm: memcg/percpu: per-memcg percpu memory statistics To: Roman Gushchin Cc: Andrew Morton , Dennis Zhou , Tejun Heo , Christoph Lameter , Johannes Weiner , Michal Hocko , Linux MM , Kernel Team , LKML Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: AA04C18005A7C X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam04 X-Bogosity: Ham, tests=bogofilter, spamicity=0.047560, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jun 23, 2020 at 11:47 AM Roman Gushchin wrote: > > Percpu memory can represent a noticeable chunk of the total memory > consumption, especially on big machines with many CPUs. Let's track > percpu memory usage for each memcg and display it in memory.stat. > > A percpu allocation is usually scattered over multiple pages (and nodes), > and can be significantly smaller than a page. So let's add a byte-sized > counter on the memcg level: MEMCG_PERCPU_B. Byte-sized vmstat infra > created for slabs can be perfectly reused for percpu case. > > Signed-off-by: Roman Gushchin > Acked-by: Dennis Zhou Reviewed-by: Shakeel Butt