From: Shakeel Butt <shakeelb@google.com>
To: Michal Hocko <mhocko@kernel.org>
Cc: Johannes Weiner <hannes@cmpxchg.org>,
Roman Gushchin <guro@fb.com>, Greg Thelen <gthelen@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
Linux MM <linux-mm@kvack.org>, Cgroups <cgroups@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] memcg: effective memory.high reclaim for remote charging
Date: Thu, 7 May 2020 10:00:07 -0700 [thread overview]
Message-ID: <CALvZod5TmAnDoueej1nu5_VV9rQa6VYVRXqCYuh63P5HN-o9Sw@mail.gmail.com> (raw)
In-Reply-To: <20200507164653.GM6345@dhcp22.suse.cz>
On Thu, May 7, 2020 at 9:47 AM Michal Hocko <mhocko@kernel.org> wrote:
>
> On Thu 07-05-20 09:33:01, Shakeel Butt wrote:
> [...]
> > @@ -2600,8 +2596,23 @@ static int try_charge(struct mem_cgroup *memcg, gfp_t gfp_mask,
> > schedule_work(&memcg->high_work);
> > break;
> > }
> > - current->memcg_nr_pages_over_high += batch;
> > - set_notify_resume(current);
> > +
> > + if (gfpflags_allow_blocking(gfp_mask))
> > + reclaim_over_high(memcg, gfp_mask, batch);
> > +
> > + if (page_counter_read(&memcg->memory) <=
> > + READ_ONCE(memcg->high))
> > + break;
>
> I am half way to a long weekend so bear with me. Shouldn't this be continue? The
> parent memcg might be still in excess even the child got reclaimed,
> right?
>
The reclaim_high() actually already does this walk up to the root and
reclaim from ones who are still over their high limit. Though having
'continue' here is correct too.
> > + /*
> > + * The above reclaim might not be able to do much. Punt
> > + * the high reclaim to return to userland if the current
> > + * task shares the hierarchy.
> > + */
> > + if (current->mm && mm_match_cgroup(current->mm, memcg)) {
> > + current->memcg_nr_pages_over_high += batch;
> > + set_notify_resume(current);
> > + } else
> > + schedule_work(&memcg->high_work);
> > break;
> > }
> > } while ((memcg = parent_mem_cgroup(memcg)));
> > --
> > 2.26.2.526.g744177e7f7-goog
> >
>
> --
> Michal Hocko
> SUSE Labs
next prev parent reply other threads:[~2020-05-07 17:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-07 16:33 [PATCH] memcg: effective memory.high reclaim for remote charging Shakeel Butt
2020-05-07 16:46 ` Michal Hocko
2020-05-07 17:00 ` Shakeel Butt [this message]
2020-05-07 17:49 ` Michal Hocko
2020-05-11 15:56 ` Johannes Weiner
2020-05-11 21:44 ` Shakeel Butt
2020-05-11 10:07 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALvZod5TmAnDoueej1nu5_VV9rQa6VYVRXqCYuh63P5HN-o9Sw@mail.gmail.com \
--to=shakeelb@google.com \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=gthelen@google.com \
--cc=guro@fb.com \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).