From: Shakeel Butt <shakeelb@google.com>
To: "Tejun Heo" <tj@kernel.org>, "Zefan Li" <lizefan.x@bytedance.com>,
"Johannes Weiner" <hannes@cmpxchg.org>,
"Yang Shi" <shy828301@gmail.com>,
"NOMURA JUNICHI(野村 淳一)" <junichi.nomura@nec.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Cgroups <cgroups@vger.kernel.org>, Linux MM <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] cgroup: disable controllers at parse time
Date: Tue, 18 May 2021 11:13:35 -0700 [thread overview]
Message-ID: <CALvZod5a_W8P0v7xg0jdh-TLvy4OUYaQkyjBx-1RSTUBo+YQmg@mail.gmail.com> (raw)
In-Reply-To: <20210512201946.2949351-1-shakeelb@google.com>
On Wed, May 12, 2021 at 1:19 PM Shakeel Butt <shakeelb@google.com> wrote:
>
> This patch effectively reverts the commit a3e72739b7a7 ("cgroup: fix
> too early usage of static_branch_disable()"). The commit 6041186a3258
> ("init: initialize jump labels before command line option parsing") has
> moved the jump_label_init() before parse_args() which has made the
> commit a3e72739b7a7 unnecessary. On the other hand there are
> consequences of disabling the controllers later as there are subsystems
> doing the controller checks for different decisions. One such incident
> is reported [1] regarding the memory controller and its impact on memory
> reclaim code.
>
> [1] https://lore.kernel.org/linux-mm/921e53f3-4b13-aab8-4a9e-e83ff15371e4@nec.com
>
> Signed-off-by: Shakeel Butt <shakeelb@google.com>
> Reported-by: NOMURA JUNICHI(野村 淳一) <junichi.nomura@nec.com>
Nomura, I think you have already tested this patch, so, can you please
add your tested-by tag?
Tejun, any comments or concerns?
Yang, do you think we should add Fixes tag to make sure this patch
lands in 5.13 where your shrinker patches landed?
> ---
> kernel/cgroup/cgroup.c | 13 +++++--------
> 1 file changed, 5 insertions(+), 8 deletions(-)
>
> diff --git a/kernel/cgroup/cgroup.c b/kernel/cgroup/cgroup.c
> index e049edd66776..e7a9a2998245 100644
> --- a/kernel/cgroup/cgroup.c
> +++ b/kernel/cgroup/cgroup.c
> @@ -5634,8 +5634,6 @@ int __init cgroup_init_early(void)
> return 0;
> }
>
> -static u16 cgroup_disable_mask __initdata;
> -
> /**
> * cgroup_init - cgroup initialization
> *
> @@ -5694,12 +5692,8 @@ int __init cgroup_init(void)
> * disabled flag and cftype registration needs kmalloc,
> * both of which aren't available during early_init.
> */
> - if (cgroup_disable_mask & (1 << ssid)) {
> - static_branch_disable(cgroup_subsys_enabled_key[ssid]);
> - printk(KERN_INFO "Disabling %s control group subsystem\n",
> - ss->name);
> + if (!cgroup_ssid_enabled(ssid))
> continue;
> - }
>
> if (cgroup1_ssid_disabled(ssid))
> printk(KERN_INFO "Disabling %s control group subsystem in v1 mounts\n",
> @@ -6214,7 +6208,10 @@ static int __init cgroup_disable(char *str)
> if (strcmp(token, ss->name) &&
> strcmp(token, ss->legacy_name))
> continue;
> - cgroup_disable_mask |= 1 << i;
> +
> + static_branch_disable(cgroup_subsys_enabled_key[i]);
> + pr_info("Disabling %s control group subsystem\n",
> + ss->name);
> }
> }
> return 1;
> --
> 2.31.1.607.g51e8a6a459-goog
>
next prev parent reply other threads:[~2021-05-18 18:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-12 20:19 [PATCH] cgroup: disable controllers at parse time Shakeel Butt
2021-05-18 18:13 ` Shakeel Butt [this message]
2021-05-18 19:54 ` Yang Shi
2021-05-18 23:28 ` ##freemail## " NOMURA JUNICHI(野村 淳一)
2021-05-20 16:30 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALvZod5a_W8P0v7xg0jdh-TLvy4OUYaQkyjBx-1RSTUBo+YQmg@mail.gmail.com \
--to=shakeelb@google.com \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=junichi.nomura@nec.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lizefan.x@bytedance.com \
--cc=shy828301@gmail.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).