From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4262C433F5 for ; Wed, 16 Feb 2022 23:57:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EB3006B0074; Wed, 16 Feb 2022 18:57:53 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E620C6B0075; Wed, 16 Feb 2022 18:57:53 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D02FD6B0078; Wed, 16 Feb 2022 18:57:53 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0101.hostedemail.com [216.40.44.101]) by kanga.kvack.org (Postfix) with ESMTP id BD7BD6B0074 for ; Wed, 16 Feb 2022 18:57:53 -0500 (EST) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 7C60195B1C for ; Wed, 16 Feb 2022 23:57:53 +0000 (UTC) X-FDA: 79150308426.17.0CB9283 Received: from mail-lj1-f179.google.com (mail-lj1-f179.google.com [209.85.208.179]) by imf25.hostedemail.com (Postfix) with ESMTP id 0BD53A0008 for ; Wed, 16 Feb 2022 23:57:52 +0000 (UTC) Received: by mail-lj1-f179.google.com with SMTP id c10so5750835ljr.9 for ; Wed, 16 Feb 2022 15:57:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=uWK5whONmmnAoDJkRJYYxU0Rm8PPAQNrqFAdJzOzSlk=; b=P9FArift4eDIPKRLy5GhzFhl6PV6UtmZRvSUwG9CjwSiIDjkj7m7hgV/dse/URQ8Vr 5MgC918Wf9sS4Ke10RJ9bY30qLZ1DsxHMBMdekuqaHmdj41z69AxJdc0rNDqacs6uNYy S+SPNtrDtahsoY6Pi6Rd8r73gZSZjPk4KMbTIy5r9fxXzZMIrQ73lMb0CJoED5bAtQMK KBNBZq3Rg+tILX05ghNraTx/HevoGqsFuolC7sKKEd9ImzJA2S2r+/qy+z/5uEZKlaF9 7p6sSfyltS5M9IjHOV9Xp6AwelqIqMuDdIWLm4B4yjj0tFXi5Iojvq1wbBIbvgY869nc mCrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=uWK5whONmmnAoDJkRJYYxU0Rm8PPAQNrqFAdJzOzSlk=; b=gUq66MnmIQYsCOEjOyZ2GSPmKr07uGxMjkb4CiauLDR+12HG/2H7C4+53Yu9+Oqksf Dp4iys6LAf+uoajMXyswxW8gmVORl4KbzHzHyD99kjlZscqe9xgn9Pu15JridT/TdayX F35njegmxzJc7iePvsNKDcLYtM0LqAvsKSuoy1czIUbCyCaFyfcO7wIUdnqJuMbx/i9B 5/haioRji+QRPev75HYCKbWbWwf9VssLJTpMxyaFpZ/RXhqa6XT4OfvoZVehIMXOSim3 zRCrrKYPJS/W/PR5QXaMZryj02Oco0K2PigjFzgadFgV2FxUyQJsp7oWZJahjEv+Xt2k LAXg== X-Gm-Message-State: AOAM532pEvU34YWFS093w4usAKNJupt0X65vt0hW4IaiHB/hHUUPG8RF zE0T5b8xhw9Bezh06P0leByOBN7J8dLMgYoTUmC8jw== X-Google-Smtp-Source: ABdhPJwyAf/VMAEPlG6E2SmCP++2oqmX45Yel7NDqSR4h60J4n8MWwUGK3ROfnDeo3uiZrE/h2nRNqAPC74lvgKZstg= X-Received: by 2002:a2e:bd83:0:b0:246:14d6:ccea with SMTP id o3-20020a2ebd83000000b0024614d6cceamr342059ljq.35.1645055871232; Wed, 16 Feb 2022 15:57:51 -0800 (PST) MIME-Version: 1.0 References: <327b9e92-88bb-d66f-e07c-526161db539b@virtuozzo.com> <35486a00-791c-3b1b-14e0-476e6242709b@virtuozzo.com> In-Reply-To: From: Shakeel Butt Date: Wed, 16 Feb 2022 15:57:39 -0800 Message-ID: Subject: Re: tools/cgroup/memcg_slabinfo.py is broken To: Matthew Wilcox Cc: Roman Gushchin , Vasily Averin , Andrew Morton , Linux MM , Vlastimil Babka Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 0BD53A0008 X-Rspam-User: Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=P9FArift; spf=pass (imf25.hostedemail.com: domain of shakeelb@google.com designates 209.85.208.179 as permitted sender) smtp.mailfrom=shakeelb@google.com; dmarc=pass (policy=reject) header.from=google.com X-Stat-Signature: pxrcnmxdp6cypajfe8br11ced4ys3uh6 X-Rspamd-Server: rspam11 X-HE-Tag: 1645055872-265498 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Feb 16, 2022 at 3:12 PM Matthew Wilcox wrote: > [...] > > Here I'd keep _page (or _folio, if you want), because > > it makes it clear that the function goes over all pages > > (and is expensive therefore). > > But there's no intrinsic reason that it should. If that's a > performance problem, you could keep slabs on a separate list > from, eg, file or anon memory. > Is there enough space in the struct slab for that list or do you mean something different?