From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.3 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5BDCC43215 for ; Sat, 16 Nov 2019 06:31:35 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 9C38D20740 for ; Sat, 16 Nov 2019 06:31:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="gF5tsuVz" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9C38D20740 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 36E326B0007; Sat, 16 Nov 2019 01:31:35 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 31EC76B0008; Sat, 16 Nov 2019 01:31:35 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 20D136B000A; Sat, 16 Nov 2019 01:31:35 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0064.hostedemail.com [216.40.44.64]) by kanga.kvack.org (Postfix) with ESMTP id 093196B0007 for ; Sat, 16 Nov 2019 01:31:35 -0500 (EST) Received: from smtpin21.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with SMTP id A3761181AEF1E for ; Sat, 16 Nov 2019 06:31:34 +0000 (UTC) X-FDA: 76161169308.21.magic12_8222b0de31941 X-HE-Tag: magic12_8222b0de31941 X-Filterd-Recvd-Size: 5171 Received: from mail-ot1-f65.google.com (mail-ot1-f65.google.com [209.85.210.65]) by imf07.hostedemail.com (Postfix) with ESMTP for ; Sat, 16 Nov 2019 06:31:34 +0000 (UTC) Received: by mail-ot1-f65.google.com with SMTP id 94so9977604oty.8 for ; Fri, 15 Nov 2019 22:31:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=mpODNTcWa+A401urYWGM84SXXQR7l3TKPlFdQmVBzs0=; b=gF5tsuVznJqnYWo56MgDxdPAGHHFgIvh1vwSch7ES7KJAJagvN85gQi55vmuMMjr8g fAl9TmJtGOhmH9KI53u2YV33HKDJ8GTzQJbR3olwc6IyhHVNXyxed7HTw3rcbH4O5lXg DFBWyLdLVZMA+dXLRbjIYwehUYEqK7HGAZdwGwaXyMuFMJEDQbOtHMaVrIC4JoOFEdrD FtnKLpPZy5bsGy7UUfNuL1Tdyd/MRvKuAOQJSQIf8kI9Mmr9deFM9R29KE4nATXS8TTA T9Afm2+ns3B0dWXdhrrPyZZ0VPSd/wl9QL8b4RH2Lv7wLMh5fKb1HP5Vpcak//Q3Ps9F jZoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=mpODNTcWa+A401urYWGM84SXXQR7l3TKPlFdQmVBzs0=; b=iRQnMu9d9c/4blkS2hwgSCSH9cjp+tknLBOOh+BCjr5t7Hu6cbmM7dhMz9SdMJ+AyJ n+ToWE19VUgWrIWqLSSa6pR9mm0Ts74rxo6LGqhEikhbULXyAhMnxV5mRw9SujnMokuZ PPquYPzETrCjbbdJDKubWZlpxoFUobVXl6sEbLcBCJOncKZl8AfX33QfjMC/fKnYmMcc ww8NSECz4fuIOniKkrfBIqTJyMuUJSTCEsgjJ5oLX2KcH57AQ0kafSyoxz2DlsbUtzm9 5mFNJbr4ElT4vJ8eQuayoFArGGLSdLWSRbgJBXzmmTaZJRwe0k2Mqj5zH3jIzB4PS45f HWAw== X-Gm-Message-State: APjAAAWyV/CDWSYPfCPHpqEIjJKAdo2x57s+C9fEDVFLT9UACienZf77 wPrCaGethfze6JdhxaB0HnAYPJwdNcyXKSOpsHhYlg== X-Google-Smtp-Source: APXvYqy+ZtE/c62xax1ax1pMapTf40gQj6BeNbMWYRA6Pe8p/qNZ7oGWKtS/5hg4q9wMQECRwkR+6tYjUMuHgQwxl6I= X-Received: by 2002:a9d:400d:: with SMTP id m13mr13658836ote.360.1573885893136; Fri, 15 Nov 2019 22:31:33 -0800 (PST) MIME-Version: 1.0 References: <1573874106-23802-1-git-send-email-alex.shi@linux.alibaba.com> <1573874106-23802-3-git-send-email-alex.shi@linux.alibaba.com> In-Reply-To: <1573874106-23802-3-git-send-email-alex.shi@linux.alibaba.com> From: Shakeel Butt Date: Fri, 15 Nov 2019 22:31:22 -0800 Message-ID: Subject: Re: [PATCH v3 2/7] mm/lruvec: add irqsave flags into lruvec struct To: Alex Shi Cc: Cgroups , LKML , Linux MM , Andrew Morton , Mel Gorman , Tejun Heo , Hugh Dickins , Konstantin Khlebnikov , Daniel Jordan , Yang Shi , Matthew Wilcox , Vlastimil Babka , Dan Williams , Michal Hocko , Wei Yang , Johannes Weiner , Arun KS , Rong Chen Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Nov 15, 2019 at 7:15 PM Alex Shi wrote: > > We need a irqflags vaiable to save state when do irqsave action, declare > it here would make code more clear/clean. > > Rong Chen reported the 'irqflags' variable need > move to the tail of lruvec struct otherwise it causes 18% regressions of > vm-scalability testing on his machine. So add the flags and lru_lock to > both near struct tail, even I have no clue of this perf losing. Regressions compared to what? Also no need to have a separate patch. > > Originally-from: Hugh Dickins > Signed-off-by: Alex Shi > Cc: Andrew Morton > Cc: Vlastimil Babka > Cc: Dan Williams > Cc: Michal Hocko > Cc: Mel Gorman > Cc: Wei Yang > Cc: Johannes Weiner > Cc: Arun KS > Cc: Tejun Heo > Cc: Konstantin Khlebnikov > CC: Rong Chen > Cc: cgroups@vger.kernel.org > Cc: linux-mm@kvack.org > Cc: linux-kernel@vger.kernel.org > --- > include/linux/mmzone.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h > index a13b8a602ee5..9b8b8daf4e03 100644 > --- a/include/linux/mmzone.h > +++ b/include/linux/mmzone.h > @@ -269,6 +269,8 @@ struct lruvec { > unsigned long flags; > /* per lruvec lru_lock for memcg */ > spinlock_t lru_lock; > + /* flags for irqsave */ > + unsigned long irqflags; > #ifdef CONFIG_MEMCG > struct pglist_data *pgdat; > #endif > -- > 1.8.3.1 >