From: Shakeel Butt <shakeelb@google.com>
To: Henry Burns <henryburns@google.com>
Cc: Vitaly Wool <vitalywool@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Vitaly Vul <vitaly.vul@sony.com>,
Jonathan Adams <jwadams@google.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Snild Dolkow <snild@sony.com>,
Thomas Gleixner <tglx@linutronix.de>,
Linux MM <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mm/z3fold.c: Allow __GFP_HIGHMEM in z3fold_alloc
Date: Sat, 13 Jul 2019 09:05:27 -0700 [thread overview]
Message-ID: <CALvZod68Ktd3m7p4MFgLdpqku3UucwEGrTVHdMPgi4cOpUOk6A@mail.gmail.com> (raw)
In-Reply-To: <20190712222118.108192-1-henryburns@google.com>
On Fri, Jul 12, 2019 at 3:22 PM Henry Burns <henryburns@google.com> wrote:
>
> One of the gfp flags used to show that a page is movable is
> __GFP_HIGHMEM. Currently z3fold_alloc() fails when __GFP_HIGHMEM is
> passed. Now that z3fold pages are movable, we allow __GFP_HIGHMEM. We
> strip the movability related flags from the call to kmem_cache_alloc()
> for our slots since it is a kernel allocation.
>
> Signed-off-by: Henry Burns <henryburns@google.com>
Reviewed-by: Shakeel Butt <shakeelb@google.com>
> ---
> mm/z3fold.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/mm/z3fold.c b/mm/z3fold.c
> index e78f95284d7c..cb567ddf051c 100644
> --- a/mm/z3fold.c
> +++ b/mm/z3fold.c
> @@ -193,7 +193,8 @@ static inline struct z3fold_buddy_slots *alloc_slots(struct z3fold_pool *pool,
> gfp_t gfp)
> {
> struct z3fold_buddy_slots *slots = kmem_cache_alloc(pool->c_handle,
> - gfp);
> + (gfp & ~(__GFP_HIGHMEM
> + | __GFP_MOVABLE)));
>
> if (slots) {
> memset(slots->slot, 0, sizeof(slots->slot));
> @@ -844,7 +845,7 @@ static int z3fold_alloc(struct z3fold_pool *pool, size_t size, gfp_t gfp,
> enum buddy bud;
> bool can_sleep = gfpflags_allow_blocking(gfp);
>
> - if (!size || (gfp & __GFP_HIGHMEM))
> + if (!size)
> return -EINVAL;
>
> if (size > PAGE_SIZE)
> --
> 2.22.0.510.g264f2c817a-goog
>
prev parent reply other threads:[~2019-07-13 16:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-12 22:21 [PATCH] mm/z3fold.c: Allow __GFP_HIGHMEM in z3fold_alloc Henry Burns
2019-07-13 8:24 ` Vitaly Wool
2019-07-13 16:05 ` Shakeel Butt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALvZod68Ktd3m7p4MFgLdpqku3UucwEGrTVHdMPgi4cOpUOk6A@mail.gmail.com \
--to=shakeelb@google.com \
--cc=akpm@linux-foundation.org \
--cc=gregkh@linuxfoundation.org \
--cc=henryburns@google.com \
--cc=jwadams@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=snild@sony.com \
--cc=tglx@linutronix.de \
--cc=vitaly.vul@sony.com \
--cc=vitalywool@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).